Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <df28cb7b-f19d-fd8e-d1b7-dd893e3d2c77@amd.com>
Date:   Tue, 6 Sep 2022 11:44:53 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Subject: Re: [PATCH linux-next] drm/amd/display: Remove the unneeded result
 variable
Content-Language: en-US
To:     cgel.zte@gmail.com, harry.wentland@amd.com
Cc:     sunpeng.li@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
        daniel@ffwll.ch, wenjing.liu@amd.com, Jun.Lei@amd.com,
        Jimmy.Kizito@amd.com, Jerry.Zuo@amd.com,
        meenakshikumar.somasundaram@amd.com, hanghong.ma@amd.com,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org,
        zhang songyi <zhang.songyi@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
References: <20220902075450.319982-1-zhang.songyi@zte.com.cn>
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
In-Reply-To: <20220902075450.319982-1-zhang.songyi@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aDJrRDRMeG1mNTcrVFBIb2FTbDBGSVk5NzBQcWp0VTl6TC93Wk9xdnFNZVFF?=
 =?utf-8?B?UUtkTE5PcHN1Q0JJOXNNY1o1ZlF3TTVvU0kzS25vMW5ZZ0U5NGMyNjZ5S0U2?=
 =?utf-8?B?eDhqTDRpcFd4OXQwVTU1cVBZREMxc3NYekkvRXFRbk9hMlNxNEhDSTFBeUxs?=
 =?utf-8?B?N0FIVjdZRUxNTzJJR2N3bjkyQlFIcDNPRTNLenh3SHN3ajh4Y3ZSVFVGTTVH?=
 =?utf-8?B?THpLRWljYkUrd0JIYVAxbXNsd2NKYXpEL0lRRDl1TTZWSWZHU25vTVJrTFV2?=
 =?utf-8?B?c3JkN3Vwb0kwUXNUQ0dZekZyYUZqY2dvSzVRMzBUbXpvd2R6cGt3YzBLZnRY?=
 =?utf-8?B?L1lOSndINzY1cUpuRnhEc3l0QmZ1eDQxUTQ1YUV3eFVDdkVUVm1YU2xmMUhT?=
 =?utf-8?B?SE9zSTRTL3JPMkc3VDU1QUhmUitiTTlESkhtcm9hcUN2R2I5T2NNeUtDak1I?=
 =?utf-8?B?RFFrK2kyZ0lRRVVQYzlXWXdlYldqSXREWlJrZXh6dFlhcXc1R0ZrTG5KVlUv?=
 =?utf-8?B?RGVrNy9GeStGWkhOY3hnVER5Z0xwdEU1YS82WERXRG1UNklNbTg2dWlQdWM3?=
 =?utf-8?B?dkgydUZGYnBVVUFFZUY4L0JMeWp1UVVhM3M5eEVjNnErbXh4YVFtVmREVVFv?=
 =?utf-8?B?WGxFY28vOHlLbEdIa3dnRGlVTEpqY0JHVDNIbmJzL09QMHdMOFZCTjZENTF3?=
 =?utf-8?B?ekdDdFFIeXF4dHR6b1FXTzhhTXhvZkpiUHd0U2VDbS8xdW5MeXU2bTdEUHd0?=
 =?utf-8?B?VVd6MXo0bFozN3dRdXhtMTljWG1PVkMzT2JxeXYyOXQ1UnluNmpJREllTlQ1?=
 =?utf-8?B?R1Y4OUJXaGJydzVEa0dtc0FKbTNZcFR5SU1JMUtpVWpkSkl3aWxGaHFJeDEz?=
 =?utf-8?B?TER0MlNQdTE2d0k0SzIzUWpBYnVVbWxQZFFsME9XSDNyU28xNFBhUk8xalFa?=
 =?utf-8?B?M09FZ3dDRytUcFlEU3VKc3kvaElEYkhoNitUNXdGTVZ5VzlkZ2puUlJBQTZR?=
 =?utf-8?B?Z1hlTnlVZlhvby8yWllMVktUUjBLSHdGc3FYUUxUWkJaZlFyTVpjMTBydmtC?=
 =?utf-8?B?dEZVRUxHNEJiOHV4NE95UjdoVnR1VzUyZTdOOFNVRWNQTExrbW9SZzVVQnFO?=
 =?utf-8?B?VzNVbkJqWEJrUTZBcVhzRlhYOUVmNmE3b2xHS2Nhalc3b3pPKzNYR1RvOXdi?=
 =?utf-8?B?WXRSVU9JaWhraXQ3MGtMMnNqU0NwdC9YakRDWkZKOVVZRG5Lb0VoNUhEODFJ?=
 =?utf-8?B?R2ZqM0RpQWk2aUV5Vk4zZkt3N3VPS3NTSTE0MVQ4RGdLQUtJUTZPWFp5bkhQ?=
 =?utf-8?B?dWhCaGFXRmpMY1dwWk9iUVFBeXJVQXFWblZndHNpeGsrZ2t2Q1JmMGZ6TERt?=
 =?utf-8?B?cm1VNGsvUCs5WCtMejBvVytFMjZtZUprV25pbGhVejV6Mkx6UFd5cksxSG92?=
 =?utf-8?B?Zm5vZGFFT3BsRTBiUVJVN2ZKNDZnazRWbm1WdkpCc25yWmpZZ3h4M3dQcXJn?=
 =?utf-8?B?S3U5aDM0L1UzQjd2RVZUL0xTOHgzRklVOEJ4bG5wRXZwd0FUVEUzWDh2djRF?=
 =?utf-8?B?d3B1L0R6TVIyNVFQTktxNjZPRHBXTEtMb0xwWWttd2FXekZ1NkJ3MUZKcDVp?=
 =?utf-8?B?VE5FYUVjQXU5VEtrQUhJYUlHOVdOU3ViNzN2djRwZXFhOExWRTZMdEJsWkQ2?=
 =?utf-8?B?YnAvL09qRFFuampDdSszRGQvb0s0OU91U1h6dWRiQ1VMS1JPalZKVmxGTzBX?=
 =?utf-8?B?cndJM0ZURkdGUjV3ODE5MDZQcmtxR0JFNyt6Q29ySldPMy9KTWJQSDk2V0py?=
 =?utf-8?B?aDlyZmYvRnRQd0JObXBQSythZjllaFN3MW50anFrTzNpdDJsWGdUb2d6TjJC?=
 =?utf-8?B?VTRobjE5eml0OXRVL2J5NVNRK1BZSmVkZ2R0eDczSGdCdlRIcGcxbXk2cmZM?=
 =?utf-8?B?RGROa3AvL0VZSktqSzVSR21BWHpVMHc1bkdxNEtOYkE1ck1IRkd4UHNBN1ls?=
 =?utf-8?B?UjQ2SEpjeE9FSlFMa1d3UmZZa1gzbnRadDZBOXdERkF4Slcxb0ErU2FnbFZY?=
 =?utf-8?B?clZzaFlZSnJTQWEyU0xZQ2gybWN2WitETEZEenFwU2I1dGdLTjBOQXdNUHdD?=
 =?utf-8?Q?Dihc7hbduHqP0DkKwccblEU7g?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 023cc70f-5803-4087-b038-08da901ebf27
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 15:44:55.9782
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CyAopA0kBlhSEUlQRz9H/AxBSJE+r6Bh1X5HJ6pJKeGAai/a0frCtJ9iu9qXO485OYvBRzvskPc1/l0jvhkC2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6971
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-09-02 03:54, cgel.zte@gmail.com wrote:
> From: zhang songyi <zhang.songyi@zte.com.cn>
> 
> Return the enable_link_dp() directly instead of storing it in another
> redundant variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index f9b798b7933c..4ab27e231337 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -2077,11 +2077,7 @@ static enum dc_status enable_link_edp(
>   		struct dc_state *state,
>   		struct pipe_ctx *pipe_ctx)
>   {
> -	enum dc_status status;
> -
> -	status = enable_link_dp(state, pipe_ctx);
> -
> -	return status;
> +	return enable_link_dp(state, pipe_ctx);
>   }
>   
>   static enum dc_status enable_link_dp_mst(

LGTM,

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

and applied to amd-staging-drm-next.

Thanks
Siqueira