Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp4624673rwb; Tue, 6 Sep 2022 10:03:05 -0700 (PDT) X-Google-Smtp-Source: AA6agR53pu3BwNPf0hh5uARPNTo0/yYkpc4TShuU73KwSQPfF7Po8ROJtSG6T3pv+7kbcRixg4DL X-Received: by 2002:a17:902:f684:b0:172:d54d:6f9e with SMTP id l4-20020a170902f68400b00172d54d6f9emr55194926plg.174.1662483785220; Tue, 06 Sep 2022 10:03:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662483785; cv=none; d=google.com; s=arc-20160816; b=NWeVOTdgRMtaKWyNlT0loPrfZSvCQsesM3nVEyTXVyjwlyPNXeuYtJUa1fBtZZ+h4/ tPGlAFrJ1U6DfwHcBMltjaBvwjgzYBYjgYJz5ny9La7E4aqisN7JsL33kFL9yqSVDuEq urHcO5hoDs3nupXlLCJvuoGH7eZUQUQ6G82w1gPBZF5QWTwl8zfYU51/52eUZu/D3zHR UVPfyMogKNY2DPTSuUNXkquZ1bfNXWwxNLRewo2UVF9aDH3awFXwGWa5M+CRtbhtvLre hicJod9+gWQZhBzF2oJUoeIkiu6+rtI1xkMTWVTGvpWrPTzBjYQ6G47igyGve2DtiZr5 0C3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6dIG++yVpXA159njyWJag0eBcSSZz3Dou5JDcEenNb8=; b=yRaX2+rQWajkGPV5/TLZCqxrpn5qimSQUKVlCvA37EPQJKdBE3xJOZwDBxBiZ4wTy0 U++Otie/KBevTKnCNChmRJVSSXWz/Vxe2x4RolOSpIP1zVRuvDUXpRwGS9AvpoiJa5by RhTXGm1vCb5OiLaNJ4ptIMlBTUA624y5SDzQbauNaUy4Pc64/5jlrfZdR8TNO9psO1r8 AmNoAeOkgF7q4W/PijfQBMsJwfKYzDNirSq/TzWzegMzDwLgA57zuIqlxyOOvZk5qizX ERkFlSdCMPp1dLudpLbxIu3fOhP/+MaHSR7zciQyUs9nJ3fsHvlO3X9MGj9gJbkhNSv0 aEaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=SWkQtzUd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l192-20020a6391c9000000b0042bc59df111si13617459pge.305.2022.09.06.10.02.52; Tue, 06 Sep 2022 10:03:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=SWkQtzUd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233573AbiIFQUo (ORCPT + 99 others); Tue, 6 Sep 2022 12:20:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233276AbiIFQUA (ORCPT ); Tue, 6 Sep 2022 12:20:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FF3086FF6 for ; Tue, 6 Sep 2022 08:49:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1BDF661479 for ; Tue, 6 Sep 2022 15:49:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 044A3C433D7; Tue, 6 Sep 2022 15:49:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662479357; bh=/bYSUBxiS/WRbTkvLJc3pRlr8II9MNaiuiZYqjjRNbM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SWkQtzUdMSpQhI24kRSAcctKM38+euqqU0QgokzDtCIibpEuNGXxYxIPQs3Ncwarn 7zgeDQ3Rh0AnyF5jMrswoIdmLBL6BF2BEPDErZ3reBnk+NF4pdht33BVNOK3NviuRa ClFX44OCzgq14sgNhT05h7cZQ28DqHFeI1/KCXfE= Date: Tue, 6 Sep 2022 17:49:14 +0200 From: Greg Kroah-Hartman To: Rodrigo Siqueira Jordao Cc: Harry Wentland , Leo Li , Alex Deuc her , Christian =?iso-8859-1?Q?K=F6nig?= , Xinhui.Pan@amd.com, linux-kernel@vger.kernel.org, David Airlie , Daniel Vetter , Wayne Lin , hersen wu , Wenjing Liu , Patrik Jakobsson , Thelford Williams , Fangzhi Zuo , Yongzhi Liu , Mikita Lipski , Jiapeng Chong , Bhanuprakash Modem , Sean Paul , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup() Message-ID: References: <20220902130105.139138-1-gregkh@linuxfoundation.org> <5f29a2e1-4ecb-9f94-1e57-f7d8d3c7afb2@amd.com> <67fe15fc-bd6a-5eee-4359-5d6244db54ef@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <67fe15fc-bd6a-5eee-4359-5d6244db54ef@amd.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 06, 2022 at 11:39:44AM -0400, Rodrigo Siqueira Jordao wrote: > > > On 2022-09-06 11:06, Greg Kroah-Hartman wrote: > > On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote: > > > > > > > > > On 2022-09-02 09:10, Greg Kroah-Hartman wrote: > > > > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote: > > > > > When calling debugfs_lookup() the result must have dput() called on it, > > > > > otherwise the memory will leak over time. Fix this up by properly > > > > > calling dput(). > > > > > > > > > > Cc: Harry Wentland > > > > > Cc: Leo Li > > > > > Cc: Rodrigo Siqueira > > > > > Cc: Alex Deucher > > > > > Cc: "Christian K?nig" > > > > > Cc: "Pan, Xinhui" > > > > > Cc: David Airlie > > > > > Cc: Daniel Vetter > > > > > Cc: Wayne Lin > > > > > Cc: hersen wu > > > > > Cc: Wenjing Liu > > > > > Cc: Patrik Jakobsson > > > > > Cc: Thelford Williams > > > > > Cc: Fangzhi Zuo > > > > > Cc: Yongzhi Liu > > > > > Cc: Mikita Lipski > > > > > Cc: Jiapeng Chong > > > > > Cc: Bhanuprakash Modem > > > > > Cc: Sean Paul > > > > > Cc: amd-gfx@lists.freedesktop.org > > > > > Cc: dri-devel@lists.freedesktop.org > > > > > Signed-off-by: Greg Kroah-Hartman > > > > > --- > > > > > > > > Despite a zillion cc: items, I forgot to cc: stable on this. Can the > > > > maintainer add that here, or do you all want me to resend it with that > > > > item added? > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > Hi Greg, > > > > > > Reviewed-by: Rodrigo Siqueira > > > > > > Is 'Cc: stable@vger.kernel.org' enough here? I can make this change before I > > > merge it into amd-staging-drm-next. > > > > Yes, please add the cc: stable@ line to the body of the patch, sorry I > > forgot that. > > > > Change applied to amd-staging-drm-next, with the Cc to the stable branch. Wonderful, thanks!