Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Sep 2022 12:41:51 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Takashi Iwai <tiwai@suse.de>
Cc:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <jroedel@suse.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Eric Auger <eric.auger@redhat.com>,
        regressions@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION 5.19.x] AMD HD-audio devices missing on 5.19
Message-ID: <YxdqP9i0bEwUg4VJ@nvidia.com>
References: <874jy4cqok.wl-tiwai@suse.de>
 <20220823010021.GA5967@nvidia.com>
 <87h723sdde.wl-tiwai@suse.de>
 <87ilmjqj1f.wl-tiwai@suse.de>
 <20220823202824.GA4516@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220823202824.GA4516@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7zZbsDTKLV7QZpwrGxrkrqzpO1KrHDzjAh+gOykcuZCmxRPaqNREM4R8wAqY?=
 =?us-ascii?Q?TIh6C7BTvQvBGxAMHNGvO6MhXim3Ux1ohtANsQQzq1XpPnq/tM/7n9tfiFzj?=
 =?us-ascii?Q?e6ajwRslYO9EMag+46e42PR3qrCvw4l1iaSofNI+FMjSpe0LHBp1eL6ZG55X?=
 =?us-ascii?Q?mTQqweTXVDQCZ9YHi9qxTt5rR24X+0++GyUHpJKGELsh+V4e3hhzJ+qtHR3u?=
 =?us-ascii?Q?oBkSS2Vs5dcEkQhgdTp/Wj0qsvluXyJuvSpHFxUI7u+QS0ka8tuhS7p1udHe?=
 =?us-ascii?Q?xTNmbxuNiJnatKXdx7oLdlqYglATKB3o3YjAjvOto6NlJzsdossbvV51/u9d?=
 =?us-ascii?Q?c/B/U5GDLf3QQQkVLZ0OZipVBR2R8NPw7kCuEiQ2FK/JpkFeFXqo1eeQW+UU?=
 =?us-ascii?Q?WzfzCYhO7h0LuSp5XrHNu/b0BtK+SrNtgOoPKuREjnwv3PWJdxmAzFzJsmFB?=
 =?us-ascii?Q?iLezwVxw9Rk1U+9j0xIEXfzaTeVvt4SNEnX0RSaocuSLJKPhBHMURWMkXLLo?=
 =?us-ascii?Q?xJkA1ZxyaWkeSTihcjw+xOfIgbWGQj9m0b8ZDpbkJvxd5M5usngse6oC/CAX?=
 =?us-ascii?Q?E0gl8W/OcSbQXbGjQNFMPC9jL885l2j/B0ZGyCS6+Iw0PVfQLmQvMQJlQqPg?=
 =?us-ascii?Q?NNJbgOvHcYpGgicZkHposFaDzCx9aOnAaLA3276GKWvIcKDEPtw5hbyr3emM?=
 =?us-ascii?Q?ybb6DuGb5C+zCcOnM3gG1E2osvUcRl4h6g+okp+p4OscPsGreaAd8bWq7AAl?=
 =?us-ascii?Q?e5eVRP/5f7Ou43k4obGSEjuHmcKzlhP84hL21yb0gNwaBAc0tFvj2VxQlKmk?=
 =?us-ascii?Q?HcgLXRucWQRO/bUCNBD9vOfkBAUUPvGVC3Sdl/AXaRoqZg3WjDkhrLdd4Ro3?=
 =?us-ascii?Q?m4fc+AiyEreL545j1EvBTgOZKy6l0ZcnjQcG6/Fqv1Xq9UG47DIch9dEjRIp?=
 =?us-ascii?Q?uPmCp7lnbspVr93glDgyAUEUeZy39X7zwRsdHVear0WM9aQ0mmoRYkFhnJ3y?=
 =?us-ascii?Q?FKKgnasQgVa30FwxwOMDlugAcxjjo1A8O3V9sr7yIUEttyrk0vApXy26cQyR?=
 =?us-ascii?Q?zBktWfRESMsWFVH3DsnECs+BmCQ3y9e6b6+hle9wxxm/ywG/K9Mow+T6e+aN?=
 =?us-ascii?Q?rxuB+H1IG6F1ZiEkkOvZcR0uFBQDl/Fox3mTfaF6zXIl2tpHP0sl56mhttdB?=
 =?us-ascii?Q?n4epaBHk1qPkoTZFLKZxiodHsuB8kDZyiY3z52aeHO4uddPw6tOzFvwMeGlc?=
 =?us-ascii?Q?0BWjY9xOsYPooplsgoWpm192X9Q2GDT1hv6fLz24kKrqbTPV2woKo+10lsbb?=
 =?us-ascii?Q?BzqsFdxm+3MK1xBFf/dwU87gVH9RnN51f6ZBU3G97GB7jy/076qe3Eo/ow7u?=
 =?us-ascii?Q?o0kPoLEekg4Z3JW414U6fA6RKa3mPzIEi4N5FQPLXyGMV9ETO8O71511Ge2p?=
 =?us-ascii?Q?DvvwamdE1Pr1v6fHKG9U+jhq2ofOhZaSxZil1W+/rGf+DDj96ty3wRokdAoc?=
 =?us-ascii?Q?92NnwXD4+55yI+vtr7DXW+imfuVO52fLgVMYpTZPuwB1/H91v/+9IjD5hISK?=
 =?us-ascii?Q?1Qfy/pTTzeuqSLvmpL9e/qZrv7FEYwBCNFfjAFqJ?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a07af00-9194-4216-472c-08da901e51ba
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 15:41:52.2958
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TxfXlt7RqgX+vjpL+rqbq8A8Q8RV2GqOA/5nYFXVZYwr1Rmt1XvgRDpOxDHuu5QY
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6434
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 23, 2022 at 05:28:24PM -0300, Jason Gunthorpe wrote:
> On Tue, Aug 23, 2022 at 01:46:36PM +0200, Takashi Iwai wrote:
> > It was tested now and confirmed that the call path is via AMDGPU, as
> > expected:
> >   amdgpu_pci_probe ->
> >   amdgpu_driver_load_kms ->
> >   amdgpu_device_init ->
> >   amdgpu_amdkfd_device_init ->
> >   kgd2kfd_device_init ->
> >   kgd2kfd_resume_iommu ->
> >   kfd_iommu_resume ->
> >   amd_iommu_init_device ->
> >   iommu_attach_group ->
> >   __iommu_attach_group
> 
> Oh, when you said sound intel I thought this was an Intel CPU..
> 
> Yes, there is this hacky private path from the amdgpu to
> the amd iommu driver that makes a mess of it here. We discussed it in
> this thread:
> 
> https://lore.kernel.org/linux-iommu/YgtuJQhY8SNlv9%2F6@8bytes.org/
> 
> But nobody put it together that it would be a problem with this.
> 
> Something like this, perhaps, but I didn't check if overriding the
> type would cause other problems.

Takashi, do we want to do this patch?

Thanks,
Jason