Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Sep 2022 14:19:06 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Nipun Gupta <nipun.gupta@amd.com>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        gregkh@linuxfoundation.org, rafael@kernel.org,
        eric.auger@redhat.com, alex.williamson@redhat.com,
        cohuck@redhat.com, puneet.gupta@amd.com,
        song.bao.hua@hisilicon.com, mchehab+huawei@kernel.org,
        maz@kernel.org, f.fainelli@gmail.com, jeffrey.l.hugo@gmail.com,
        saravanak@google.com, Michael.Srba@seznam.cz, mani@kernel.org,
        yishaih@nvidia.com, robin.murphy@arm.com, will@kernel.org,
        joro@8bytes.org, masahiroy@kernel.org, ndesaulniers@google.com,
        linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        kvm@vger.kernel.org, okaya@kernel.org, harpreet.anand@amd.com,
        nikhil.agarwal@amd.com, michal.simek@amd.com,
        aleksandar.radovanovic@amd.com, git@amd.com
Subject: Re: [RFC PATCH v3 4/7] bus/cdx: add cdx-MSI domain with gic-its
 domain as parent
Message-ID: <YxeBCsA32jnwMjSj@nvidia.com>
References: <20220803122655.100254-1-nipun.gupta@amd.com>
 <20220906134801.4079497-1-nipun.gupta@amd.com>
 <20220906134801.4079497-5-nipun.gupta@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220906134801.4079497-5-nipun.gupta@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XwhUHLWLaub/SXHt0Oqzi7S82UD1Awx1BgOA+zoifLGaz1EYaDr/4CB/8QWY?=
 =?us-ascii?Q?6tNQgE4qw/K7FOhKf1K5kUYewRPHwedgCQHDXgHUGTOhm2hH55060S8fiKoc?=
 =?us-ascii?Q?UfS+p2HysPd2vPe8RNjo+Tj6qdJ5iYZ519GQ9jM/C7yawHIgJHTHrFSa5fK4?=
 =?us-ascii?Q?MTojbByfwyaCp+vyK6bfgJjXpxZvh1NBXNbM//7oyGHnAofpDXZ3ZwizXAWa?=
 =?us-ascii?Q?rN4WH0goAWgBZxw7TpX5psxBeWG8bYlwpEcibhebjvYRm/YxTQBJfwpGNkYV?=
 =?us-ascii?Q?wxOMIOYDN/tEGSvIg6LVOo9RPY4qozOeh+kjgtmgWmWpt3HI1UU08bCogKPU?=
 =?us-ascii?Q?5czPWqKxAdfR6h4MCS4AmR3cdfdevaamGACrdWQOx2h14qzdHCIIAhGJk2Qm?=
 =?us-ascii?Q?En4RltBb1JEMsOR/QwzRMgbBSABKt6IhQhlLbAngKq7+laoc8RVyMGZWfu22?=
 =?us-ascii?Q?yTtcqtyS5cvOsRg+K0uruc67AEI4lt1P0x8rxspcYAQI6IEv+crWOURyeAPd?=
 =?us-ascii?Q?Iy8iHgd1/yIiC869B1svioG8QMxhQE4LXeEXFJmkonUh6/EMETFNP818JKfz?=
 =?us-ascii?Q?pIjlPZQ6jantV82VHSdFsL9ijy1scBlvM35GCXjv/EOP/GwQGrf6oRqasl0z?=
 =?us-ascii?Q?Sv3fUl8xOrgLgHL1lDgL7nVN9R0TYfSuzDy2t3efNpMI/dCQIla4gwfqM2hq?=
 =?us-ascii?Q?RjvSAP+KKnROf/fke8zatMhtJqsixuOOqrsokvRO4ktY5jW5xZKGNlMs/fTk?=
 =?us-ascii?Q?b4KM3PpuXIKpCWn2JCdWbdcqK7cAMCtyDlehajCUAQiZfsoBUwk4YxOHvrjv?=
 =?us-ascii?Q?iGqplNkB3nbtGr6z3a7B/YBLVW0SPNd3zydhokM973S7C3+p5brNbZi459GJ?=
 =?us-ascii?Q?5WPjEjpSbjPr+EirUDwnM/ydSAGacgx7EkgJQyw/qbZ3Pq9QE4HpqQ/rwGYd?=
 =?us-ascii?Q?9S/zIEO4PLY5snussyQRzpYzm4W82B/nvuihAxK5RzD6+yxIgCduNiE6pD6Q?=
 =?us-ascii?Q?DlEhux51tLc1JZIzmUAvlqX3+7+Q/7N05Mz1Nxiv/DR1xH5ydykNrNn/pcv5?=
 =?us-ascii?Q?nQK5SaRc/Hg98ZyTey/voikJ20nJWYCaMp4rVUqLtqmlIQXCuKF7hTOt/zno?=
 =?us-ascii?Q?MRh6e8KiGXrfPDDMSbsvx4ecQGkQTRauQO4vJyUv6tCKGCpVhdyhexeXWdBy?=
 =?us-ascii?Q?huis2bgxY4a8Ik/FCeV/oxWHp0aQEvXrMfZQk81QaZVeTvrfXuajkbTADR5f?=
 =?us-ascii?Q?kQ0RzUnvsODAsGUuk0l9bwMYio8DkJQpw1S68d1ZDjLegnlZCk4jms1rPP1t?=
 =?us-ascii?Q?MS3vBiJhiSha2vVOMWdAW44SonILTe86aDY5QuuO1u4WZ2OAVqZMrngaiEKf?=
 =?us-ascii?Q?IBVbnYjfBoPbkaF/UAk7KaUlqjcyHPH6fv18d3r+1DXpZq78g4mn3Pw05XXj?=
 =?us-ascii?Q?lJwrq5ODDymbXgMAUXdBCFuv8DapcxWB/GC0IAm58W/Gj5PmSgQxoRk9wkE8?=
 =?us-ascii?Q?m/KB2Ua56wnaucP3vxwzLlfV4E9SGZZqEUT6JknBqt9QIwvI3lHXTxGRy2yG?=
 =?us-ascii?Q?cD5cfAHfGXtQ4WXOTCJcBwj25AuIl2EYEftD015L?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9a70c09-a316-461f-9a74-08da902be80d
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 17:19:07.9888
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J3QgLwFQaqZDzzpDtRClvgKRWQr5PbqhyQWHF3uK5Q6EmhhGLTzhcUxBPrPKHMev
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4037
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 06, 2022 at 07:17:58PM +0530, Nipun Gupta wrote:

> +static void cdx_msi_write_msg(struct irq_data *irq_data,
> +			      struct msi_msg *msg)
> +{
> +	/*
> +	 * Do nothing as CDX devices have these pre-populated
> +	 * in the hardware itself.
> +	 */
> +}

Huh?

There is no way it can be pre-populated, the addr/data pair,
especially on ARM, is completely under SW control. There is some
commonly used IOVA base in Linux for the ITS page, but no HW should
hardwire that.

Jason