Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5a1cb21c-61f4-8ae6-8689-126ed85891ee@kernel.org>
Date:   Tue, 6 Sep 2022 19:34:03 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH v2] rv/reactor: add __init/__exit annotations to module
 init/exit funcs
To:     Xiu Jianfeng <xiujianfeng@huawei.com>, rostedt@goodmis.org,
        mingo@redhat.com
Cc:     linux-kernel@vger.kernel.org
References: <20220906141210.132607-1-xiujianfeng@huawei.com>
Content-Language: en-US
From:   Daniel Bristot de Oliveira <bristot@kernel.org>
In-Reply-To: <20220906141210.132607-1-xiujianfeng@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/6/22 16:12, Xiu Jianfeng wrote:
> Add missing __init/__exit annotations to module init/exit funcs.
> 
> Fixes: 135b881ea885 ("rv/reactor: Add the printk reactor")
> Fixes: e88043c0ac16 ("rv/reactor: Add the panic reactor")
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>

Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org>

Thanks!
-- Daniel
> ---
>  kernel/trace/rv/reactor_panic.c  | 4 ++--
>  kernel/trace/rv/reactor_printk.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/trace/rv/reactor_panic.c b/kernel/trace/rv/reactor_panic.c
> index b698d05dd069..d65f6c25a87c 100644
> --- a/kernel/trace/rv/reactor_panic.c
> +++ b/kernel/trace/rv/reactor_panic.c
> @@ -24,13 +24,13 @@ static struct rv_reactor rv_panic = {
>  	.react = rv_panic_reaction
>  };
>  
> -static int register_react_panic(void)
> +static int __init register_react_panic(void)
>  {
>  	rv_register_reactor(&rv_panic);
>  	return 0;
>  }
>  
> -static void unregister_react_panic(void)
> +static void __exit unregister_react_panic(void)
>  {
>  	rv_unregister_reactor(&rv_panic);
>  }
> diff --git a/kernel/trace/rv/reactor_printk.c b/kernel/trace/rv/reactor_printk.c
> index 31899f953af4..4b6b7106a477 100644
> --- a/kernel/trace/rv/reactor_printk.c
> +++ b/kernel/trace/rv/reactor_printk.c
> @@ -23,13 +23,13 @@ static struct rv_reactor rv_printk = {
>  	.react = rv_printk_reaction
>  };
>  
> -static int register_react_printk(void)
> +static int __init register_react_printk(void)
>  {
>  	rv_register_reactor(&rv_printk);
>  	return 0;
>  }
>  
> -static void unregister_react_printk(void)
> +static void __exit unregister_react_printk(void)
>  {
>  	rv_unregister_reactor(&rv_printk);
>  }