Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Sep 2022 10:04:52 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Cheng Li <lic121@chinatelecom.cn>, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: use mem_map_offset instead of mem_map_next
Message-ID: <Yxd9tA8ThZtB77dq@monkey>
References: <1662300161-22049-1-git-send-email-lic121@chinatelecom.cn>
 <YxUVZpsmukNW5NyK@casper.infradead.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YxUVZpsmukNW5NyK@casper.infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sTN3tdS20k2ItiiVSyUwYB8pY4rOrt6IbqM9c4oUzt1999KWTcArflhqn2mg?=
 =?us-ascii?Q?EgbRqBA4HqzNGLY01LKSR4Q/PZEAIJQu4AmrjfjnG/YzLR3j3Vlu+uh5rh4A?=
 =?us-ascii?Q?Gk88/i6dv45YYE8gKqHkQNnC2BfRI52pkLj20zueTI0vHzqGZRzTrbBFx9Jo?=
 =?us-ascii?Q?vfikKWbmafv+Zhj2M7l3edhFAcwcOglXQFBjApBPVYlKnvZJ5hoOdBRm37ti?=
 =?us-ascii?Q?LURD2Y0VVZtjMM5xSDKG5smlBA3cycLyMog1Y5cv/oRBroqXSGkA8L+TZ9y1?=
 =?us-ascii?Q?uzrhMMNNTdBOcmrlzo+IDJ8r82IX4YAumvTLv4vBbxF2HqZpdzVQrCzXRcAt?=
 =?us-ascii?Q?DRV7dLHxP6Wj+ujtrPLnKTTNIio0QAAKPbFagkAL34ai557EPKbf7xX80Ksg?=
 =?us-ascii?Q?QwNpiCY2wiaO0dPGxlkjuNzge+KoIwfs/Duy4+c5v74FejusxumnzNqb1FKM?=
 =?us-ascii?Q?SSYiNoPpBuUZ3xaOgOhESH9wYf9LJsQkoPtNv6zXK6Ti4Rhzpg4ITycoltLS?=
 =?us-ascii?Q?87D3ijxmFbkWW3XhZ0YEKicPrIviqQxeBWorH831gQxysVqghMIPXI3ulRJW?=
 =?us-ascii?Q?yCUgZjXSyn9ZPfZdJaWV3ZEi0wMrRX+RClUPOVLKuMOV94aoUXS3oa3FnhS/?=
 =?us-ascii?Q?NBFQIZlRcANCvSAYP6DLNcsbbdUNF62tWgJm2At6/jhphW5q6hpgCh33I0T6?=
 =?us-ascii?Q?B0WJmu4fxTZDCg/HJqmh5/eUcjvaNllhD7QDzXtBSc253Rwycx1/cVEdBg9g?=
 =?us-ascii?Q?AUJIhnJNwxx9Sr8PyX8/6T1OqrXLT0uyGkOkDnWYcFFHO8TwhERQmXzXG4xv?=
 =?us-ascii?Q?ZXPNnlixxp0yhOCbwMTIh00avprLpxO7U9S0X0rS9oV+f5WeHkIAJBYEV2ee?=
 =?us-ascii?Q?bYNIHro6AkxUxvnCwYXg0O3TJMSkPYavMC4VGFDKeSfLN1g/RVhI0UBEv+xp?=
 =?us-ascii?Q?N9wY6bscgcwuYznclCELk8jZfk+LTKmurW5PM8/VLmuarGGpAwbwdU4nl2JT?=
 =?us-ascii?Q?qQOr1LXEIiNJc2owAvY7QolxdQOCF0RygqVKBnkY9SRMWMoVu2mDlyfnxf+S?=
 =?us-ascii?Q?ufnEkBgeNZ728ttUpiAqBri+x+sRS5n4ue7eJ1ZrcImJNtjYWROXNu7bqTpj?=
 =?us-ascii?Q?ykzSr69FMUBiHOquneRWaVolBwVpjUrvCHXc7dipXm2ckaY1SRe2jposlUXs?=
 =?us-ascii?Q?URZsPbzph6OrMXcf7Xd2ekgXs1HEeG/qZCk8y3FHbHZM9EnzVD4jYyva57VI?=
 =?us-ascii?Q?R6eF/dc8PuaawNeVHBDbOiFM48wxl9ym0yr4++pEtCBha755nFTCmkJrWz9j?=
 =?us-ascii?Q?PoGZoWTzEdKhwV0M1uZM3FiBSm6/NbSWP69Q8S9vreoreCk9yQp1SkCCli4f?=
 =?us-ascii?Q?qbKUviXTwmWc7d7lgK5LM8u6EI1Fcl8OLKXUR9nTQwsHyFGzm779abMZ6Aih?=
 =?us-ascii?Q?myuVcOnE75ZKoDYtGrls5x9gb51yQwS2Oxd89Dwrb5g6o1uQB3mVmJ/YbxaG?=
 =?us-ascii?Q?9bFNvsTkxENlwUkkISKbin5HIY8x5U4cK//UKR2KJD08i3Dm71W/dgB56DbU?=
 =?us-ascii?Q?KyNktlR+R6XS6AapPnShKnv5phm0GG88PAKR9U2jgMCEbbtdc9KN167XyZ51?=
 =?us-ascii?Q?+w=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aaf6a816-a645-41bd-4bce-08da9029ebe8
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 17:04:55.4475
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6xK7B/i23gEmvjCUZ29TY+B8l64peVneu0SO44ThuYAqxalj7P+W9OHFrY3yQn3WaYXrJUfOVNrsMpm5cwsTuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5011
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-06_09,2022-09-06_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=777
 phishscore=0 mlxscore=0 spamscore=0 malwarescore=0 suspectscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2209060079
X-Proofpoint-ORIG-GUID: vyrxxKghx3dy3MBVR-sO2NnQWeklN3NP
X-Proofpoint-GUID: vyrxxKghx3dy3MBVR-sO2NnQWeklN3NP
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/04/22 22:15, Matthew Wilcox wrote:
> On Sun, Sep 04, 2022 at 02:02:41PM +0000, Cheng Li wrote:
> > To handle discontiguity case, mem_map_next() has a parameter named
> > `offset`. As a function caller, one would be confused why "get
> > next entry" needs a parameter named "offset". The other drawback of
> > mem_map_next() is that the callers must take care of the map between
> > parameter "iter" and "offset", otherwise we may get an hole or
> > duplication during iteration. So we use mem_map_offset instead of
> > mem_map_next.
> 
> I think we should go further and get rid of mem_map_offset().
> nth_page() is now more efficient than mem_map_offset().

Agree.

However, IIUC nth_page() will 'almost' always be more efficient.  The
only exception is unlikely configuration where CONFIG_SPARSEMEM &&
!CONFIG_SPARSEMEM_VMEMMAP.  Correct?

Not arguing against replacement.  Just wanting to refresh my memory.
-- 
Mike Kravetz