Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Tue, 6 Sep 2022 10:08:51 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Eliav Farber <farbere@amazon.com>
Cc:     jdelvare@suse.com, robh+dt@kernel.org, p.zabel@pengutronix.de,
        rtanwar@maxlinear.com, linux-hwmon@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        hhhawa@amazon.com, jonnyc@amazon.com, andriy.shevchenko@intel.com
Subject: Re: [PATCH v4 12/21] dt-bindings: hwmon: (mr75203) add
 "moortec,vm-active-channels" property
Message-ID: <20220906170851.GA900242@roeck-us.net>
References: <20220906083356.21067-1-farbere@amazon.com>
 <20220906083356.21067-13-farbere@amazon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220906083356.21067-13-farbere@amazon.com>
Precedence: bulk

On Tue, Sep 06, 2022 at 08:33:47AM +0000, Eliav Farber wrote:
> Add optional "moortec,vm-active-channels" property to define the number
> of active channels per VM.
> 
> This shall be useful to avoid exposing sysfs for reading inputs that are
> not connected to any voltage source.
> 
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
> V4 -> V3:
> - Fix DT checker errors.
> 
> V3 -> V2:
> - Add "moortec" prefix to property name.
> - Add explanation why this change is needed.
> 
>  .../devicetree/bindings/hwmon/moortec,mr75203.yaml     | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> index 9454576ebb73..2aa4c3618596 100644
> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> @@ -70,6 +70,15 @@ properties:
>    "#thermal-sensor-cells":
>      const: 1
>  
> +  moortec,vm-active-channels:
> +    description:
> +      Defines the number of channels per VM that are actually used and are
> +      connected to some input source.
> +      Maximum number of items - number of VMs.
> +      Maximum value of each item - number of channels.
> +      Minimum value of each item - 0 (which means entire VM sensor is nou used).

s/nou/not/

> +    $ref: /schemas/types.yaml#/definitions/uint8-array
> +
>  required:
>    - compatible
>    - reg
> @@ -91,5 +100,6 @@ examples:
>          intel,vm-map = [03 01 04 ff ff];
>          clocks = <&osc0>;
>          resets = <&rcu0 0x40 7>;
> +        moortec,vm-active-channels = /bits/ 8 <0x10 0x05>;
>          #thermal-sensor-cells = <1>;
>      };