Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Sep 2022 11:27:10 -0700
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc:     rafael.j.wysocki@intel.com, Josef Bacik <josef@toxicpanda.com>,
        Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        Petr Mladek <pmladek@suse.com>,
        tangmeng <tangmeng@uniontech.com>,
        YueHaibing <yuehaibing@huawei.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PM: ACPI: reboot: Reinstate S5 for reboot
Message-ID: <YxeQ/i71s/wxiIe1@bombadil.infradead.org>
References: <20220906143108.1749183-1-kai.heng.feng@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220906143108.1749183-1-kai.heng.feng@canonical.com>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Tue, Sep 06, 2022 at 10:31:07PM +0800, Kai-Heng Feng wrote:
> Commit d60cd06331a3 ("PM: ACPI: reboot: Use S5 for reboot") caused Dell
> PowerEdge r440 hangs at boot.
> 
> The issue is fixed by commit 2ca1c94ce0b6 ("tg3: Disable tg3 device on
> system reboot to avoid triggering AER"), so reinstate the patch again.
> 
> Cc: Josef Bacik <josef@toxicpanda.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

The addition of do_kernel_power_off_prepare() is not clear from
your patch, it would be easier to review and therefore detect
regressions more easily if you first moved the the code without
modifications and then after make another change in another patch.

  Luis