Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220906165131.59f395a9@canb.auug.org.au> <dab10759-c059-2254-116b-8360bc240e57@suse.cz>
In-Reply-To: <dab10759-c059-2254-116b-8360bc240e57@suse.cz>
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date:   Tue, 6 Sep 2022 11:37:59 -0700
Message-ID: <CAADnVQJTDdA=vpQhrbAbX7oEQ=uaPXwAmjMzpW4Nk2Xi9f2JLA@mail.gmail.com>
Subject: Re: linux-next: build failure after merge of the slab tree
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Marco Elver <elver@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Sep 6, 2022 at 12:53 AM Vlastimil Babka <vbabka@suse.cz> wrote:
>
> On 9/6/22 08:51, Stephen Rothwell wrote:
> > Hi all,
>
> Hi,
>
> > After merging the slab tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> >
> > kernel/bpf/memalloc.c: In function 'bpf_mem_free':
> > kernel/bpf/memalloc.c:613:33: error: implicit declaration of function '__ksize'; did you mean 'ksize'? [-Werror=implicit-function-declaration]
> >    613 |         idx = bpf_mem_cache_idx(__ksize(ptr - LLIST_NODE_SZ));
> >        |                                 ^~~~~~~
> >        |                                 ksize
>
> Could you use ksize() here? I'm guessing you picked __ksize() because
> kasan_unpoison_element() in mm/mempool.c did, but that's to avoid
> kasan_unpoison_range() in ksize() as this caller does it differently.
> AFAICS your function doesn't handle kasan differently, so ksize() should
> be fine.

Ok. Will change to use ksize().