Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp4750697rwb; Tue, 6 Sep 2022 12:05:12 -0700 (PDT) X-Google-Smtp-Source: AA6agR6oZOBit60lR1a9fbIam5/qY6tckURLSEfMrZaZhX7ofiGxHKQkVZIadDGhImnreYus44Cn X-Received: by 2002:a17:902:d481:b0:175:168a:79bf with SMTP id c1-20020a170902d48100b00175168a79bfmr36696089plg.33.1662491111726; Tue, 06 Sep 2022 12:05:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662491111; cv=none; d=google.com; s=arc-20160816; b=b/1SR7gJlA7c8TzmDO+68fUklaNxtIwa9rBzelmoA6W7/KjTbeUBSkIxSfvXk8XZ8r pDXY0gLtRr93U1hOPv8CoFaRqpZ1Uj03ID7AjZjT7OUG7Oxs9NkOfBZWPOWEHvjmyQIi 4ccEFBpT8VliHfe+anjZuimbBy6tLXZb3rVZFNA7QrDcHSH2Q+lZTmUFEbDOexnmBrKi pHncswH44bQLReeZEV/c5fvhXh296PzbNa8WYumo6zg4guSRHFVusKp+JKrr6m1G6ud1 Xai/OaiEKK1pxm4Kcf5U0WVn+Fw31iwiSd7bItHlPzlJyTXHMi0nt2hD1xvNNFUhwLTi aTjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=YxnHTWcYZvzF+VRDJKigMnC8f9W9KZNVnVDsV1AMwoc=; b=qX0AUtNZZp5FZJrFdtCWLJXuZ5gjufaV2PA9hP9h+FDZV4hsgmjxyW3w4xn0scj7L8 RijD/CVvSuz+Uaij2Z2xTiKPq5j55dcww8wnmFGcPKlacWkHCvW8RBYUK56+TicLNfgX fBT5ift9kNscizPFI3lwDqj2mxdLYJQ253XcKddL/5x+G60xbGlWvYwf30gcdtso8HMq cwtP5Ab0G/I6eEhxxQ7a7KUbcF6d/o/k49fFDUvIXEh7PTtxvpq1PxDAxpZqxPoLzsaV HAxH/5r/NziS+SlLhwE6IofPw7aAvFYa9wb9cr220/ioHc8vzmVCXU1N6dJG7ZiiVvAq +W5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=i6UFTEKS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w14-20020a63d74e000000b00430841271dcsi10179105pgi.265.2022.09.06.12.04.54; Tue, 06 Sep 2022 12:05:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=i6UFTEKS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229883AbiIFSeO (ORCPT + 99 others); Tue, 6 Sep 2022 14:34:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229743AbiIFSeM (ORCPT ); Tue, 6 Sep 2022 14:34:12 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D866F81693 for ; Tue, 6 Sep 2022 11:34:10 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id b16so16324701edd.4 for ; Tue, 06 Sep 2022 11:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=YxnHTWcYZvzF+VRDJKigMnC8f9W9KZNVnVDsV1AMwoc=; b=i6UFTEKSIUMhWtO1MB9MaGSXXbI4dolkonGKMDDYoABfTxvn4aAvu7nmcyUyY1b3BZ bBTLJrnIQNFJggguSrDPV7Wd11brAm9lT19cfqsF5+BXnE6HqCzs991vyvYX29VZh/xg Zzd6OPaWiDw2GdXL8byNUqR5AQXvDJZJVu/qs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=YxnHTWcYZvzF+VRDJKigMnC8f9W9KZNVnVDsV1AMwoc=; b=6u5UyXse6Zl7kpIDEhfrI/GLwxljnYpeWoTESv8LihGFfHFewteiqsZZkjL9TWBR9z HnFFTuPvHTvHdM0SRRKfoA+bq1JWw/0rQNz8MCctI9AkjzJyRLIs8AySSGUcb6At0Wwp D7BndJepE9CKH1J5QNPLAcdwd5bMKERK8GV1HUS8wfBrMdbOAJNNr1WQUSxSRXk9piIf lrMpHTJLfbdUw1ABiV5JbSL8IUop+ONgV+X1cYqV4QXmVCAfo7cWIICR275pD7ZV7CTe 67W/bW2f2MN28ulHCTn/z3T8tuGbdgjuwnF6EqHlH4VtrTjJxHVPvvwK5AueANKOQU6h T3pQ== X-Gm-Message-State: ACgBeo2eKkOFaj+Rirqm8ErcZ6/OmK5tP6OSgQoWcKbdU907DXvmC/ej itz18TiavEetBGHhnuFYkZKoTOZJW8M4Og== X-Received: by 2002:a05:6402:496:b0:443:a5f5:d3b with SMTP id k22-20020a056402049600b00443a5f50d3bmr50389444edv.331.1662489249197; Tue, 06 Sep 2022 11:34:09 -0700 (PDT) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com. [209.85.128.51]) by smtp.gmail.com with ESMTPSA id b15-20020a17090630cf00b0073dd1ac2fc8sm6971492ejb.195.2022.09.06.11.34.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Sep 2022 11:34:08 -0700 (PDT) Received: by mail-wm1-f51.google.com with SMTP id k17so7339478wmr.2 for ; Tue, 06 Sep 2022 11:34:08 -0700 (PDT) X-Received: by 2002:a05:600c:4e8b:b0:3a5:f5bf:9c5a with SMTP id f11-20020a05600c4e8b00b003a5f5bf9c5amr14894307wmq.85.1662489247864; Tue, 06 Sep 2022 11:34:07 -0700 (PDT) MIME-Version: 1.0 References: <20220901102946.v2.1.I347ea409ee3134bd32a29e33fecd1a6ef32085a0@changeid> In-Reply-To: <20220901102946.v2.1.I347ea409ee3134bd32a29e33fecd1a6ef32085a0@changeid> From: Doug Anderson Date: Tue, 6 Sep 2022 11:33:56 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] arm64: dts: qcom: sc7180: Configure USB as wakeup source To: Matthias Kaehlcke Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm , Krishna Kurapati , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Sep 1, 2022 at 10:29 AM Matthias Kaehlcke wrote: > > The dwc3 USB controller of the sc7180 supports USB remote > wakeup, configure it as a wakeup source. > > Signed-off-by: Matthias Kaehlcke > --- > > Changes in v2: > - use qcom/arm64-for-6.1 as base, v1 was unintendedly based on a > downstream branch that was used for testing > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index e8debb0da411..af5bab27eaf3 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -2782,6 +2782,8 @@ usb_1: usb@a6f8800 { > <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3 0>; > interconnect-names = "usb-ddr", "apps-usb"; > > + wakeup-source; > + The patch documenting this property has landed in commit 416b61893860 ("dt-bindings: usb: qcom,dwc3: add wakeup-source property"). I guess the only question is whether this should be in the general sc7180 device tree file or just for trogdor. Any chance it could cause problems for devices that aren't designed like trogdor?