Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Sep 2022 13:46:22 -0600
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Bjorn Andersson <andersson@kernel.org>,
        linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remoteproc: report firmware name on load failures
Message-ID: <20220906194622.GB64477@p14s>
References: <20220831161736.749932-1-krzysztof.kozlowski@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220831161736.749932-1-krzysztof.kozlowski@linaro.org>
Precedence: bulk

On Wed, Aug 31, 2022 at 07:17:36PM +0300, Krzysztof Kozlowski wrote:
> remoteproc error messages like:
>   remoteproc remoteproc0: request_firmware failed: -2
>   remoteproc remoteproc1: request_firmware failed: -2
> are difficult to debug as one actually have no clue which device
> reported it and which firmware is missing.  Be verbose and print the
> name of the failed firmware.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/remoteproc/remoteproc_core.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index e5279ed9a8d7..71cd7ed7a970 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -1923,7 +1923,8 @@ int rproc_trigger_recovery(struct rproc *rproc)
>  	/* load firmware */
>  	ret = request_firmware(&firmware_p, rproc->firmware, dev);
>  	if (ret < 0) {
> -		dev_err(dev, "request_firmware failed: %d\n", ret);
> +		dev_err(dev, "request_firmware %s failed: %d\n",
> +			rproc->firmware, ret);
>  		goto unlock_mutex;
>  	}
>  
> @@ -2023,7 +2024,8 @@ int rproc_boot(struct rproc *rproc)
>  		/* load firmware */
>  		ret = request_firmware(&firmware_p, rproc->firmware, dev);
>  		if (ret < 0) {
> -			dev_err(dev, "request_firmware failed: %d\n", ret);
> +			dev_err(dev, "request_firmware %s failed: %d\n",
> +				rproc->firmware, ret);

That information is already available in sysfs but if you are really keen on it
please do the same for rproc_trigger_auto_boot().

Thanks,
Mathieu

>  			goto downref_rproc;
>  		}
>  
> -- 
> 2.34.1
>