Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0d2875d6-280f-c901-a7b4-92ea6a84e966@gmail.com>
Date:   Tue, 6 Sep 2022 22:58:55 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH v2] amba: Fix use-after-free in amba_read_periphid()
To:     Isaac Manjarres <isaacmanjarres@google.com>
Cc:     Russell King <linux@armlinux.org.uk>,
        Saravana Kannan <saravanak@google.com>,
        "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
        patches@armlinux.org.uk, Guenter Roeck <linux@roeck-us.net>,
        kernel-team@android.com, linux-kernel@vger.kernel.org
References: <20220818172852.3548-1-isaacmanjarres@google.com>
 <094b6125-6b3e-1b8e-024f-a924e4775305@gmail.com>
 <CABfwK12ChYDmhvR2EO1q2NUS4Zhd1WO8UWWoSVNY331wwbKS0w@mail.gmail.com>
Content-Language: en-US
From:   Gabriel Francisco <frc.gabriel@gmail.com>
In-Reply-To: <CABfwK12ChYDmhvR2EO1q2NUS4Zhd1WO8UWWoSVNY331wwbKS0w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 06/09/2022 19:54, Isaac Manjarres wrote:
> On Sun, Sep 4, 2022 at 4:15 AM Gabriel Francisco <frc.gabriel@gmail.com> wrote:
>> This patch alone on top of v6.0-rc2 still gives me the null pointer.
>>
>> But combining it with Zhen Lei's patch (from
>> https://lkml.org/lkml/2022/8/27/164) my device boots successfully.
> Hi Gabriel,
>
> Thanks for your e-mail. I think my AMBA bus patch and
> https://lore.kernel.org/all/20220817184026.3468620-1-isaacmanjarres@google.com/
> (merged in 6.0-rc4), instead of Zhen Lei's patch, should fix the
> problem entirely.
>
> Thanks,
> Isaac

I'm afraid the issue is still showing up (looks similar when I tested 
with 6.0-rc2 + your patch and it went away when combining with Zhen 
Lei's one).

I added the dmesg log at 
https://bugzilla.kernel.org/attachment.cgi?id=301756

Thank you,

Gabriel Francisco