Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cd65ca29-1e24-1064-ccd4-160dbd041036@gmail.com>
Date:   Tue, 6 Sep 2022 14:37:47 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH linux-next] PCI: iproc: Remove the unneeded result
 variable
Content-Language: en-US
To:     Scott Branden <scott.branden@broadcom.com>,
        Bjorn Helgaas <helgaas@kernel.org>, cgel.zte@gmail.com
Cc:     lpieralisi@kernel.org, robh@kernel.org, kw@linux.com,
        bhelgaas@google.com, rjui@broadcom.com, sbranden@broadcom.com,
        bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        ye xingchen <ye.xingchen@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
References: <20220906212520.GA45166@bhelgaas>
 <5cbe247d-f9a3-4770-1ca7-5ba5097451ba@broadcom.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <5cbe247d-f9a3-4770-1ca7-5ba5097451ba@broadcom.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/6/2022 2:27 PM, Scott Branden wrote:
> 
> 
> On 2022-09-06 14:25, Bjorn Helgaas wrote:
>> On Tue, Sep 06, 2022 at 07:16:36AM +0000, cgel.zte@gmail.com wrote:
>>> From: ye xingchen <ye.xingchen@zte.com.cn>
>>>
>>> Return the value iproc_pcie_setup_ib() directly instead of storing it in
>>> another redundant variable.
>>>
>>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>>> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
>>
>> This patch itself is fine,
> Does the patch serve any real use though?

Not really though if we don't accept it, then someone else will submit a 
similar patch later, since it is obviously correct, might as well accept it?
-- 
Florian