Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp4901766rwb; Tue, 6 Sep 2022 14:53:36 -0700 (PDT) X-Google-Smtp-Source: AA6agR6XJB482pq/Ij+tTo4WUqTinFdzfsG0Zeh7t0Hq7dljdZ44K1j/WT0rWLVWxpKqE5wDztZs X-Received: by 2002:a17:907:9812:b0:741:973d:fe78 with SMTP id ji18-20020a170907981200b00741973dfe78mr325928ejc.490.1662501216366; Tue, 06 Sep 2022 14:53:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662501216; cv=none; d=google.com; s=arc-20160816; b=IC0EoeIAc7fNzf6chT++EOwnoG+EjKukLzBvH9+A5/ZpHNCfWWIf5L6WN449EIaT99 wTfLz46Aw597OColn7ARj1yUY+/pFkNo8yq8tYNUtsDtOIEPll4qEOfP51pBUpgX4ZFv wdMthdi/7zJsfRzXab9wx+dNUKV9Hiv5ML/PuNFzf73DCpTsyfak3xdsy9O/WNKX64MK VRn9w5CCDe2ZfxMLh4zpDHK4i9A7kF/l/gt7NzpBJXqQ+V8Xz7f+URyaYLXWeBeKpcTb CLO5dPHNMOy4/M+elZFkzg3rR2FNNIZaEn1+MCZ9SYdLIW/FmfTGIgWs6Jli0L3JJ4N8 l5hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Z8Gxtn/5Mdie1i/tik+XaG0WZ+Bolm1Vdi7iewRca7U=; b=UI5tLIj9ZhEjY38nnV31Obn8UPDL0NpvJpI1GmyhKTCKVQ8cngGshGGRxa0XkD6H/+ CihdCTRwARbnXjX5Sd4kkZd4f8JkmHApzDHOlWr9jO7c++Ce6TMm6HNsKTYMmMxp6jK7 /2cFVviS2cUrus2DUs2iB3mXvlp4XtsX1tY1E0hQSQN1cHLlXhar8Zzdi58chm6OZWjp JoBqLaxzgkvkpgzY6x9iOz5I5tEe7F4ycIpkqgmo6WXBsd0yrdv9uvGq6oxi7jFjVw5Z NON5WvxnQLF1FJUZPv3KxCYEK+LPQ/+4+uxGmQNT9OnjX45A9hJjJVW6LPypxGlojWS3 sBrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=RqbwdFPV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c15-20020a0564021f8f00b0044eabb548b4si2482465edc.473.2022.09.06.14.53.09; Tue, 06 Sep 2022 14:53:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=RqbwdFPV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229849AbiIFV1i (ORCPT + 99 others); Tue, 6 Sep 2022 17:27:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbiIFV1d (ORCPT ); Tue, 6 Sep 2022 17:27:33 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1C72B5E68 for ; Tue, 6 Sep 2022 14:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Z8Gxtn/5Mdie1i/tik+XaG0WZ+Bolm1Vdi7iewRca7U=; b=RqbwdFPVrGOjJodWAEScKPbeze gf+Dzcbqo8vb5ATRc8FgAL0XJc/wZp2eta2DYPK6zl3PdLfxYV23zIoSDum1RrkWsGvNglBENgAt/ jiK3Wby4AU2AlDwgB5DRmwKQ8Ed7GburBavynL4vHfNq8Jf9ec2yXPvuNYEyI7+UMLSjVt1gWJdRM bgh5QiVUcOBWkO4M0UNdAHyV/F6Zvi8RCAFEzuu94vhrqxtxPZeouxxysCZsfO9TGQZycRSlJz0VB 0RLEao04Ie7XPbY0krtbQ8R5rjt4QjYPpaN/0AWs/yb7SxMjEHaPXFaX9HFyFHpcPF4L59AU5VnNT nrNiao/w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34154) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oVg6R-0004Uz-EO; Tue, 06 Sep 2022 22:27:27 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oVg6P-0000Aq-Hy; Tue, 06 Sep 2022 22:27:25 +0100 Date: Tue, 6 Sep 2022 22:27:25 +0100 From: "Russell King (Oracle)" To: Gabriel Francisco Cc: Isaac Manjarres , Saravana Kannan , patches@armlinux.org.uk, Guenter Roeck , kernel-team@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] amba: Fix use-after-free in amba_read_periphid() Message-ID: References: <20220818172852.3548-1-isaacmanjarres@google.com> <094b6125-6b3e-1b8e-024f-a924e4775305@gmail.com> <0d2875d6-280f-c901-a7b4-92ea6a84e966@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d2875d6-280f-c901-a7b4-92ea6a84e966@gmail.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 06, 2022 at 10:58:55PM +0200, Gabriel Francisco wrote: > I'm afraid the issue is still showing up (looks similar when I tested with > 6.0-rc2 + your patch and it went away when combining with Zhen Lei's one). > > I added the dmesg log at > https://bugzilla.kernel.org/attachment.cgi?id=301756 Bugzilla's all great and all, but not with firefox. Firefox wants me to open that attachment in Libreoffice Writer... so wget -O - ... |less to the rescue. So you have an oops in __clk_put(), which suggests you don't have "amba: Fix use-after-free in amba_read_periphid()" from Isaac Manjarres applied. I haven't sent it upstream yet, but even if I had, 6.0-rc2 would be too old. Please try with Isaac's patch applied, thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!