Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp4906422rwb; Tue, 6 Sep 2022 15:00:05 -0700 (PDT) X-Google-Smtp-Source: AA6agR4FaiXU1abWKdj7hOpEZg55nM4rGDBQQmoEtSRXtTB2BXR3liGoaC6N6MN8Q4UZj4KnJrVQ X-Received: by 2002:a05:6402:3507:b0:448:b672:55ee with SMTP id b7-20020a056402350700b00448b67255eemr538018edd.107.1662501605696; Tue, 06 Sep 2022 15:00:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662501605; cv=none; d=google.com; s=arc-20160816; b=x7NwDN/a3MqYDWD/ccJ5f9kCp0LSTuolPAl8n3CREKNvIeemZ46HZRXEL4dgH+Hs5/ ElfAyshRjvDilRTQXvozQdRt4sN2Ilx8qZKtLe4pAdfymXKBeZV06Kfx2o8GBovQCmni Z05p8njyuKXnw/M4VDuXtQHAooCaYySMufvMm8ji7NBS3P/CXq0ixnQVYyoOegnpK5Cz 4lr8iRCHPn/zpkcH+Eqi8KuLqAQOfN/FTUJ6Kobi+YigUbaYG4EHqR6aIpiIIcosovPh w9kXHQMYzFQZ9m7nGLX/FGIdHhUDaJzkesx35LAUKaXbEz1DAc03U7e/BSzqrn6ZG9v8 NoUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=KHxdXdnbyU/J/nnM81i11pclheKf2BrXEtGUvor2TOQ=; b=l0K/O6Nvy4VxjuNeFmAvzt3ypqwGz+bs2CzLskr4U/DMI3ypc6gVjz9JxZIaTuAkmi LZ3yB5xR9bpjV0Fba8REeGBm+tWnQdX8CMenJKTRNUlXp1PDCJ53GGnhm6BH19Wb5th5 OHQCQK6i6I5jJJxT13+Da/2NMxEva/ke6lwGDd4Jxzraa7DyHqdaIB7uU51ajcOJWaaB XDfpsaPXPbzRtHK1Iclri5Wln7jItR/YGHB74nLAkkWSqMfphnQqOVq7uM2pgYBzWjza djGixOiQ1oekW7KJ+MOk1aCNuUFtV45XkLsyp1F0gcj3H5y1QI/deLdfF3Mkt6/82/JC 7oPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d1-20020a170906544100b0072fa2e742f4si9759159ejp.906.2022.09.06.14.59.40; Tue, 06 Sep 2022 15:00:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229901AbiIFVlF (ORCPT + 99 others); Tue, 6 Sep 2022 17:41:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbiIFVlD (ORCPT ); Tue, 6 Sep 2022 17:41:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 454BA8671E; Tue, 6 Sep 2022 14:41:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D56F06132D; Tue, 6 Sep 2022 21:41:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EEFCC433C1; Tue, 6 Sep 2022 21:41:01 +0000 (UTC) Date: Tue, 6 Sep 2022 17:41:40 -0400 From: Steven Rostedt To: Arun Easi Cc: Sudip Mukherjee , Nilesh Javali , "Martin K. Petersen" , , "James E.J. Bottomley" , , linux-kernel , linux-next Subject: Re: [EXT] build failure of next-20220906 due to 8bfc149ba24c ("scsi: qla2xxx: Enhance driver tracing with separate tunable and more") Message-ID: <20220906174140.41b46a5f@gandalf.local.home> In-Reply-To: References: <44fe9ca0-e1d7-1e4f-9fd8-0f48a84dca72@marvell.com> <20220906170346.52c3f592@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 Sep 2022 14:26:31 -0700 Arun Easi wrote: > Steve, I was thinking both the fixes stay at least for a short > term the one in qla2xxx to avoid tree dependencies. > > Since, the qla_def.h change goes as: > > +#ifndef CONFIG_TRACING > +#ifndef trace_array_get_by_name > > ..it should co-exist when the "#define trace_array_get_by_name" gets > merged in include/linux/trace.h. BTW, I will send out the changes to > trace.h today. > > Other alternatives/suggestions welcome. I doubt I'll have anything that conflicts with an update to include/linux/trace.h, as it is seldom modified. Just sent a patch out that updates that file and I'll review it, and then you can push it through your tree. -- Steve