Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Sep 2022 14:41:20 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Pali =?iso-8859-1?Q?Roh=E1r?= <pali@kernel.org>
Cc:     Shawn Guo <shawn.guo@linaro.org>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Rob Herring <robh@kernel.org>,
        Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: histb: switch to using gpiod API
Message-ID: <Yxe+gPl5qeqJuC4Z@google.com>
References: <20220906204301.3736813-1-dmitry.torokhov@gmail.com>
 <20220906210811.5kzdq66eeeauk2d3@pali>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220906210811.5kzdq66eeeauk2d3@pali>
Precedence: bulk

On Tue, Sep 06, 2022 at 11:08:11PM +0200, Pali Roh?r wrote:
> On Tuesday 06 September 2022 13:43:00 Dmitry Torokhov wrote:
> > +	ret = gpiod_set_consumer_name(hipcie->reset_gpio,
> > +				      "PCIe device power control");
> 
> Just unrelated thing, I know it was there before, but I saw it just now
> and have to comment it: This is absolute nonsense name. "reset-gpios"
> device tree property specifies PERST# signal pin (PciE ReSeT) as defined
> in PCIe CEM (Card ElectroMagnetic) specification and it has absolute
> nothing with PCIe power control.
> 
> My suggestion for maintainers would be to remove this critic name at
> all as it would just mislead other people reading that code.

I can respin the patch is you suggest a more sensible label...

> 
> > +	if (ret) {
> > +		dev_err(dev, "unable to set reset gpio name: %d\n", ret);
> > +		return ret;
> >  	}

Thanks.

-- 
Dmitry