Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Sep 2022 21:59:18 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Li Zhong <floridsleeves@gmail.com>
Cc:     linux-kernel@vger.kernel.org, peterz@infradead.org,
        jpoimboe@kernel.org, jbaron@akamai.com, ardb@kernel.org,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com
Subject: Re: [PATCH v1] arch/x86/kernel: check the return value of
 insn_decode_kernel()
Message-ID: <20220906215918.3fe20cca@gandalf.local.home>
In-Reply-To: <20220902074706.2211252-1-floridsleeves@gmail.com>
References: <20220902074706.2211252-1-floridsleeves@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri,  2 Sep 2022 00:47:06 -0700
Li Zhong <floridsleeves@gmail.com> wrote:

> @@ -20,9 +20,10 @@
>  int arch_jump_entry_size(struct jump_entry *entry)
>  {
>  	struct insn insn = {};
> +	int ret;
>  
> -	insn_decode_kernel(&insn, (void *)jump_entry_code(entry));
> -	BUG_ON(insn.length != 2 && insn.length != 5);
> +	ret = insn_decode_kernel(&insn, (void *)jump_entry_code(entry));

It's highly unlikely that length will be 2 or 5 if ret is not zero (as it
is initialized to zero going into this function).

> +	BUG_ON(ret < 0 || insn.length != 2 && insn.length != 5);

In any case, you need parenthesis around the && condition.

-- Steve


>  
>  	return insn.length;