Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220906101555.106033-1-mie@igel.co.jp> <Yxcn4CPN3BkC9xg7@kroah.com>
In-Reply-To: <Yxcn4CPN3BkC9xg7@kroah.com>
From:   Shunsuke Mie <mie@igel.co.jp>
Date:   Wed, 7 Sep 2022 10:59:13 +0900
Message-ID: <CANXvt5ouQ72R3q=G3W-N77ecmu8k86c4FwpEq4eMaCG-pt=G_Q@mail.gmail.com>
Subject: Re: [RFC PATCH v2 1/2] misc: pci_endpoint_test: Aggregate params
 checking for xfer
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Kishon Vijay Abraham I <kishon@ti.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2022=E5=B9=B49=E6=9C=886=E6=97=A5(=E7=81=AB) 19:58 Greg Kroah-Hartman <greg=
kh@linuxfoundation.org>:
>
> On Tue, Sep 06, 2022 at 07:15:54PM +0900, Shunsuke Mie wrote:
> > Each transfer test functions have same parameter checking code. This pa=
tch
> > unites those to an introduced function.
> >
> > Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
> > ---
> > Changes in v2:
> > * New patch
> > ---
> > ---
> >  drivers/misc/pci_endpoint_test.c | 35 ++++++++++++++++++++++++++------
> >  1 file changed, 29 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoi=
nt_test.c
> > index 8f786a225dcf..3bd9f135cdac 100644
> > --- a/drivers/misc/pci_endpoint_test.c
> > +++ b/drivers/misc/pci_endpoint_test.c
> > @@ -332,6 +332,17 @@ static bool pci_endpoint_test_msi_irq(struct pci_e=
ndpoint_test *test,
> >       return false;
> >  }
> >
> > +static int pci_endpoint_test_validate_xfer_params(struct device *dev,
> > +             struct pci_endpoint_test_xfer_param *param, size_t alignm=
ent)
> > +{
> > +     if (param->size > SIZE_MAX - alignment) {
> > +             dev_err(dev, "Maximum transfer data size exceeded\n");
> > +             return -EINVAL;
> > +     }
> > +
> > +     return 0;
> > +}
> > +
> >  static bool pci_endpoint_test_copy(struct pci_endpoint_test *test,
> >                                  unsigned long arg)
> >  {
> > @@ -363,9 +374,13 @@ static bool pci_endpoint_test_copy(struct pci_endp=
oint_test *test,
> >               return false;
> >       }
> >
> > +     err =3D pci_endpoint_test_validate_xfer_params(dev, &param, align=
ment);
> > +     if (err) {
> > +             dev_err(dev, "Invalid parameter\n");
>
> Also, you just printed 2 errors for the same error.  Not needed.
I see. I'll also change to using the dev_dbg() in the next version.

Thanks,
Shunsuke