Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Kees Cook <keescook@chromium.org>
Cc:     Bradley Grove <linuxdrivers@attotech.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
Subject: Re: [PATCH] esas2r: Use flex array destination for memcpy()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1pmg7gbux.fsf@ca-mkp.ca.oracle.com>
References: <20220901205729.2260982-1-keescook@chromium.org>
Date:   Tue, 06 Sep 2022 22:25:06 -0400
In-Reply-To: <20220901205729.2260982-1-keescook@chromium.org> (Kees Cook's
        message of "Thu, 1 Sep 2022 13:57:29 -0700")
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Kees,

> In preparation for FORTIFY_SOURCE performing run-time destination
> buffer bounds checking for memcpy(), specify the destination output
> buffer explicitly, instead of asking memcpy() to write past the end of
> what looked like a fixed-size object. Silences future run-time
> warning:
>
>   memcpy: detected field-spanning write (size 80) of single field "trc + 1" (size 64)
>
> There is no binary code output differences from this change.

Applied to 6.1/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering