Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Sep 2022 05:45:53 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Jiri Slaby <jslaby@suse.cz>
Cc:     bp@suse.de, tglx@linutronix.de, x86@kernel.org,
        linux-kernel@vger.kernel.org,
        Mark Mossberg <mark.mossberg@gmail.com>
Subject: Re: [PATCH] x86/dumpstack: Don't mention RIP in "Code:"
Message-ID: <YxgT5WombFuUofEX@nazgul.tnic>
References: <b772c39f-c5ae-8f17-fe6e-6a2bc4d1f83b@kernel.org>
 <20220906071123.558-1-jslaby@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220906071123.558-1-jslaby@suse.cz>
Precedence: bulk

On Tue, Sep 06, 2022 at 09:11:23AM +0200, Jiri Slaby wrote:
> Commit 238c91115cd0 ("x86/dumpstack: Fix misleading instruction pointer
> error message") changed the "Code:" line in bug reports when RIP is an
> invalid pointer. In particular, the report currently says (for example):
> 
>   BUG: kernel NULL pointer dereference, address: 0000000000000000
>   ...
>   RIP: 0010:0x0
>   Code: Unable to access opcode bytes at RIP 0xffffffffffffffd6.
> 
> That "Unable to access opcode bytes at RIP 0xffffffffffffffd6." is
> quite confusing as RIP value is 0, not -42. That -42 comes from
> "regs->ip - PROLOGUE_SIZE", because Code is dumped with some prologue
> (and epilogue).
> 
> So do not mention "RIP" on this line in this context.
> 
> Cc: Mark Mossberg <mark.mossberg@gmail.com>
> Cc: Borislav Petkov <bp@suse.de>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> ---
>  arch/x86/kernel/dumpstack.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
> index afae4dd77495..b3dba35f466e 100644
> --- a/arch/x86/kernel/dumpstack.c
> +++ b/arch/x86/kernel/dumpstack.c
> @@ -128,7 +128,7 @@ void show_opcodes(struct pt_regs *regs, const char *loglvl)
>  		/* No access to the user space stack of other tasks. Ignore. */
>  		break;
>  	default:
> -		printk("%sCode: Unable to access opcode bytes at RIP 0x%lx.\n",
> +		printk("%sCode: Unable to access opcode bytes at 0x%lx.\n",
>  		       loglvl, prologue);
>  		break;
>  	}

I guess... and it says "opcode bytes" to denote that it is trying to
access instructions so yeah, that RIP might be superfluous.

Acked-by: Borislav Petkov <bp@suse.de>

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette