Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ae1e3abd-cafb-7059-b8ae-5bcb13d53b40@gmail.com>
Date:   Wed, 7 Sep 2022 10:50:36 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH] Documentation/process/magic-number.rst: kill
Content-Language: en-US
To:     =?UTF-8?B?0L3QsNCx?= <nabijaczleweli@nabijaczleweli.xyz>
Cc:     Jonathan Corbet <corbet@lwn.net>,
        Federico Vaga <federico.vaga@vaga.pv.it>,
        Alex Shi <alexs@kernel.org>,
        Yanteng Si <siyanteng@loongson.cn>,
        Hu Haowen <src.res@email.cn>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc-tw-discuss@lists.sourceforge.net
References: <20220906003828.aqrcmjzuri5do4uq@tarta.nabijaczleweli.xyz>
From:   Bagas Sanjaya <bagasdotme@gmail.com>
In-Reply-To: <20220906003828.aqrcmjzuri5do4uq@tarta.nabijaczleweli.xyz>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9/6/22 07:38, наб wrote:
> The entire file blames back to the start of git
> (minus whitespace from the RST translation and a typo fix)
> 
> There are changelog comments for March 1994 through to Linux 2.5.74,
> struct tty_ldisc is two pointers nowadays, so naturally no magic,
> GDA_MAGIC is defined but unused, and it's been this way
> since start-of-git,
> M3_CARD_MAGIC isn't defined, because
> commit d56b9b9c464a10ab1ee51a4c6190a2b57b8ef7a6 ("[PATCH] The scheduled
> removal of some OSS drivers") removed the entire driver in 2006,
> CS_CARD_MAGIC likewise since
> commit b5d425c97f7d4e92151167b01ca038e7853c6b37 ("more scheduled OSS
> driver removal") in 2007,
> KMALLOC_MAGIC and VMALLOC_MAGIC got killed in
> commit e38e0cfa48ac38f4fe24453d2523852467c95b21 ("[ALSA] Remove kmalloc
> wrappers"), six months after start of git,
> SLAB_C_MAGIC has never appeared in git (killed in 2.4.0-test3pre6).
>

Seems like incomprehensible to me. Did you mean comparing pre-git era
changelog to current doc?

Also, the subject line should be "Documentation: remove magic number doc".

Thanks.

-- 
An old man doll... just what I always wanted! - Clara