Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp5262277rwb; Tue, 6 Sep 2022 23:08:04 -0700 (PDT) X-Google-Smtp-Source: AA6agR7M/pEMr7SRKt6oQZohz2/Vljhm2Iv+8sWU1kcCyjrrt+K74tTqbOp6S612eDCQqhnrfO3L X-Received: by 2002:a17:902:e8c2:b0:176:d40e:4b76 with SMTP id v2-20020a170902e8c200b00176d40e4b76mr2191794plg.140.1662530884738; Tue, 06 Sep 2022 23:08:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662530884; cv=none; d=google.com; s=arc-20160816; b=Ktp1RhPk6krHvqdiYpaUf2e1djpeSbfuHziLVfrGA8ZDglnj7+33NB6WxcY66NvPbg K/Rtj0ld2HLQVb2+xzBznbq3pzkO++M22qaNmEkRl9xgtkVJRgE0/qY3+FkxudLT2nXz HoSZDFW664yFGBuIBJ1SGpVPjMv7AjnSCiag+QmzjSQh6wdCqgeu5f/RIYYbhWBVKVdk gvjOo5Rr4hCfILVKo14HITFPHgyt/Gb16lgJ75xGv9SY1bFcVJK+QbYjYIr6/xh89xsR KpvoH5BYWBQICUdGEL66LY2CVXiatfJFShmU2C5IodIG9ACtf6Vg5TwToT/JLoOjBYYa rMhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=kRxjuhdRb3ZZr6r+0WoIyyWubCEdCFfRAW0bWnxZ3uQ=; b=O1V61vMx5Y4YvvWuipsTJsPdLbKFOFrWslFGB7Fu41UPhTYuOQ0x8siRXNXTrnKdJM v7E3CaOt+bO4p8wgX3IZeqDc6WlyWNBxh9l+UfnwqBUG70FNv71ZXVdyeWtGCrMUwf5y yZ10oaxZiS05f3S2QKC3sDbXb3tN6y1BHGjkuMY1nUQ/z+1dl+PTY0gXz/05+rM2lKSM b8GO7dxE87sMHbuRxQNCFPg/X1bY0y8ymFktHP0BKkGCTt68wbjWC+W5E64R3ctmjWKx YvBZJGIbBoVCOeBDrEQpm+mVuh35hgzvmwv+6blRMBaR4+rCwOW1Q6X4spsU1/7cSaX1 XrWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eMVUfS57; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd10-20020a17090b4cca00b00200b96d234csi1256960pjb.49.2022.09.06.23.07.52; Tue, 06 Sep 2022 23:08:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eMVUfS57; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229494AbiIGFZZ (ORCPT + 99 others); Wed, 7 Sep 2022 01:25:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbiIGFZY (ORCPT ); Wed, 7 Sep 2022 01:25:24 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65D1E52DDC; Tue, 6 Sep 2022 22:25:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662528321; x=1694064321; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3fwuebPci+layBCJrWgeXhUy9wzDEyG0L73TDATLe+k=; b=eMVUfS57hlc7rstnmlny67094iAjM9OfUgwXyxCIzUCsb25tUYTr5ZTv Cats8VQQFldPc8/FKLHMBzV99KUzyBIJiULMC6IvUsyULBtQNQKbm5Ghh vuXzmZl2Pc6c3epQAwOTiH/Phz+NU/irEiZJvE0pbT4FU5c4hjwsK6yMO t2dVHuKCxiY/3u/3rHvv/q2FiFUVdvKeQXvO9tagOsIPlBoA2k/6Z0iSC If44RtneCHjqIdtWBUc83SFtQopS61F+GQzY0XrtcmxICSXDzdoEYT6HW MaOJNAda3Ff7bks41JWao6aFm9hnl2hYnDJOJOAuUkdqq1HPkvSODUkt9 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10462"; a="358499552" X-IronPort-AV: E=Sophos;i="5.93,295,1654585200"; d="scan'208";a="358499552" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2022 22:25:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,295,1654585200"; d="scan'208";a="859514583" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga006.fm.intel.com with ESMTP; 06 Sep 2022 22:25:17 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 7F294F7; Wed, 7 Sep 2022 08:25:30 +0300 (EEST) Date: Wed, 7 Sep 2022 08:25:30 +0300 From: Mika Westerberg To: Bjorn Helgaas Cc: Kai-Heng Feng , Rajvi Jingar , "Rafael J . Wysocki" , Koba Ko , "David E . Box" , Sathyanarayanan Kuppuswamy , linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH v3 04/10] PCI/PTM: Separate configuration and enable Message-ID: References: <20220906222351.64760-1-helgaas@kernel.org> <20220906222351.64760-5-helgaas@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220906222351.64760-5-helgaas@kernel.org> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 06, 2022 at 05:23:45PM -0500, Bjorn Helgaas wrote: > + } else if (pci_pcie_type(dev) == PCI_EXP_TYPE_RC_END) { > + Unnecessary empty line. > + /* > + * Per sec 7.9.15.3, this should be the Local Clock > + * Granularity of the associated Time Source. But it > + * doesn't say how to find that Time Source. > + */ > + dev->ptm_granularity = 0;