Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp5278316rwb; Tue, 6 Sep 2022 23:30:36 -0700 (PDT) X-Google-Smtp-Source: AA6agR4y826N/biCZE5/rSWIwd60Cah9RzpWxTDONJv6V+iGOHmbt8XdmwgTeZnnhET+PY2epSne X-Received: by 2002:a17:906:cc16:b0:73d:d16c:609f with SMTP id ml22-20020a170906cc1600b0073dd16c609fmr1286720ejb.691.1662532236127; Tue, 06 Sep 2022 23:30:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662532236; cv=none; d=google.com; s=arc-20160816; b=Y7dR6wXcl816mz2JgLkWnQ2JvDG5ywk2TFh+LWQGqDMsoG0BUOqPlAEKHPKGSDlOYy 7ZSpLZ6ruzX9q+lkFoPFdbemRZTUfih6/vDBIQQdvAxqSvULbq47SVpfIKGoOFlD3U2Q Jrxllx6dneN6cB8g42CljZRIJZXWyyF9jNV9nyjDn7K8sDtNji+8V5EvMLWly53KMkZ4 BOli8d3+jbJ7OSA77Nl5Ly3XnZ2S7XC9wJlVUns+m4OyycZwowhT3G8zVHkdZaozMtKK 99JHG+8KgvEGHK+MKJOgXHTlZMcmzr9x955wINwsu1NlbZ6B9kaAm8svu8JWg4XAqRKj UHpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=N+i3cLN5NUSkf27lAr2jih9CAlEr8ZyBTAw2IjFUI2s=; b=G5xbFjQtnt+khN3Z6h/G/XMLYvaWoxejwXeTvwr0I6HL54EDwwxAZwiIso77prNmuE F0iuIrA2yA1bLmUYhuwZEd6TdVJUSHRPx8Kl+NiTURa8rlybj9Bd0rsrgM4bC4uBCAgM I9dUAbN2W/M51lXmWfTRGTfgV9I+ewrBDodk1N5CU1bLRYN2ztLg8JWyon+0gG11JjBY 48nHjsasl36/3RcEhLkmlPlN4j1rOV588nUG55lUkRY0R9EaZfok+bIDnQa4sunJ9FBd LfD6mh0E6FvbO84LkdUD8MSl5fhFR6HrkyMYpRFKMLSxYNY3i+IbVeiWAk+6JNXrlirk Y9UQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Qu4AL0Xi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w17-20020a05640234d100b00446c5e10fbesi2454420edc.32.2022.09.06.23.30.11; Tue, 06 Sep 2022 23:30:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Qu4AL0Xi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229827AbiIGF6v (ORCPT + 99 others); Wed, 7 Sep 2022 01:58:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbiIGF6t (ORCPT ); Wed, 7 Sep 2022 01:58:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FAE2895DF for ; Tue, 6 Sep 2022 22:58:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A292D6178E for ; Wed, 7 Sep 2022 05:58:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4B24C433D7; Wed, 7 Sep 2022 05:58:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1662530328; bh=naZK0v57e74Q3v48EfjiO6fCp+pAZWwJm7kyEpVCtDw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Qu4AL0XiHCS4ZnKtz7us7wvHtTde8+59XSouRmqEARt+4HHqvpfCNM07r/RG8N+jp CpYCDzlFmRNhzM+EfkeIGNP+l1h7RDmbNDbxdLUY1K/wi/qFRW8FVMCMdZay+UMU4b FeDzz/Sz89YDWxaAUFpxrU8qay6hFs6nG3YtJqzY= Date: Tue, 6 Sep 2022 22:58:47 -0700 From: Andrew Morton To: Xiu Jianfeng Cc: , Subject: Re: [PATCH -next] secretmem: use ATOMIC_INIT() to initialize secretmem_users Message-Id: <20220906225847.255b4f244105b9b66b713857@linux-foundation.org> In-Reply-To: <20220906093620.243465-1-xiujianfeng@huawei.com> References: <20220906093620.243465-1-xiujianfeng@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 Sep 2022 17:36:20 +0800 Xiu Jianfeng wrote: > The variable secretmem_users is of atomic_t type, so initialize it > properly with ATOMIC_INIT(). > True, but there are many many cases where we initialize an atomic_t to the all-zeroes pattern. So many that this should be considered acceptable practice.