Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Oleksandr Natalenko <oleksandr@redhat.com>
To:     "Eric W. Biederman" <ebiederm@xmission.com>
Cc:     linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        Huang Ying <ying.huang@intel.com>,
        "Jason A . Donenfeld" <Jason@zx2c4.com>,
        Will Deacon <will@kernel.org>,
        "Guilherme G . Piccoli" <gpiccoli@igalia.com>,
        Laurent Dufour <ldufour@linux.ibm.com>,
        Stephen Kitt <steve@sk2.org>, Rob Herring <robh@kernel.org>,
        Joel Savitz <jsavitz@redhat.com>,
        Kees Cook <keescook@chromium.org>,
        Xiaoming Ni <nixiaoming@huawei.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Renaud =?ISO-8859-1?Q?M=E9trich?= <rmetrich@redhat.com>,
        Oleg Nesterov <oleg@redhat.com>,
        Grzegorz Halat <ghalat@redhat.com>, Qi Guo <qguo@redhat.com>
Subject: Re: [PATCH] core_pattern: add CPU specifier
Date:   Wed, 07 Sep 2022 08:15:06 +0200
Message-ID: <5599808.DvuYhMxLoT@redhat.com>
Organization: Red Hat
In-Reply-To: <87r10ob0st.fsf@email.froward.int.ebiederm.org>
References: <20220903064330.20772-1-oleksandr@redhat.com> <87r10ob0st.fsf@email.froward.int.ebiederm.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hello.

On st=C5=99eda 7. z=C3=A1=C5=99=C3=AD 2022 0:22:42 CEST Eric W. Biederman w=
rote:
> Oleksandr Natalenko <oleksandr@redhat.com> writes:
>=20
> > Statistically, in a large deployment regular segfaults may indicate a C=
PU issue.
> >
> > Currently, it is not possible to find out what CPU the segfault happene=
d on.
> > There are at least two attempts to improve segfault logging with this r=
egard,
> > but they do not help in case the logs rotate.
> >
> > Hence, lets make sure it is possible to permanently record a CPU
> > the task ran on using a new core_pattern specifier.
>=20
> I am puzzled why make it part of the file name, and not part of the
> core file?  Say an elf note?

This might be a good idea too, and one approach doesn't exclude the other o=
ne.

> The big advantage is that you could always capture the cpu and
> will not need to take special care configuring your system to
> capture that information.

The advantage of having CPU recorded in the file name is that in case of mu=
ltiple cores one can summarise them with a simple ls+grep without invoking =
a fully-featured debugger to find out whether the segfaults happened on the=
 same CPU.

Thanks.

> Eric
>=20
> > Suggested-by: Renaud M=C3=A9trich <rmetrich@redhat.com>
> > Signed-off-by: Oleksandr Natalenko <oleksandr@redhat.com>
> > ---
> >  Documentation/admin-guide/sysctl/kernel.rst | 1 +
> >  fs/coredump.c                               | 5 +++++
> >  include/linux/coredump.h                    | 1 +
> >  3 files changed, 7 insertions(+)
> >
> > diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentatio=
n/admin-guide/sysctl/kernel.rst
> > index 835c8844bba48..b566fff04946b 100644
> > --- a/Documentation/admin-guide/sysctl/kernel.rst
> > +++ b/Documentation/admin-guide/sysctl/kernel.rst
> > @@ -169,6 +169,7 @@ core_pattern
> >  	%f      	executable filename
> >  	%E		executable path
> >  	%c		maximum size of core file by resource limit RLIMIT_CORE
> > +	%C		CPU the task ran on
> >  	%<OTHER>	both are dropped
> >  	=3D=3D=3D=3D=3D=3D=3D=3D	=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> > =20
> > diff --git a/fs/coredump.c b/fs/coredump.c
> > index a8661874ac5b6..166d1f84a9b17 100644
> > --- a/fs/coredump.c
> > +++ b/fs/coredump.c
> > @@ -325,6 +325,10 @@ static int format_corename(struct core_name *cn, s=
truct coredump_params *cprm,
> >  				err =3D cn_printf(cn, "%lu",
> >  					      rlimit(RLIMIT_CORE));
> >  				break;
> > +			/* CPU the task ran on */
> > +			case 'C':
> > +				err =3D cn_printf(cn, "%d", cprm->cpu);
> > +				break;
> >  			default:
> >  				break;
> >  			}
> > @@ -535,6 +539,7 @@ void do_coredump(const kernel_siginfo_t *siginfo)
> >  		 */
> >  		.mm_flags =3D mm->flags,
> >  		.vma_meta =3D NULL,
> > +		.cpu =3D raw_smp_processor_id(),
> >  	};
> > =20
> >  	audit_core_dumps(siginfo->si_signo);
> > diff --git a/include/linux/coredump.h b/include/linux/coredump.h
> > index 08a1d3e7e46d0..191dcf5af6cb9 100644
> > --- a/include/linux/coredump.h
> > +++ b/include/linux/coredump.h
> > @@ -22,6 +22,7 @@ struct coredump_params {
> >  	struct file *file;
> >  	unsigned long limit;
> >  	unsigned long mm_flags;
> > +	int cpu;
> >  	loff_t written;
> >  	loff_t pos;
> >  	loff_t to_skip;

=2D-=20
Oleksandr Natalenko (post-factum)
Principal Software Maintenance Engineer