Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Sep 2022 09:13:39 +0300
From:   Mika Westerberg <mika.westerberg@linux.intel.com>
To:     Szuying Chen <chensiying21@gmail.com>
Cc:     YehezkelShB@gmail.com, gregkh@linuxfoundation.org,
        mario.limonciello@amd.com, andreas.noever@gmail.com,
        michael.jamet@intel.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, Yd_Tseng@asmedia.com.tw,
        Chloe_Chen@asmedia.com.tw, Richard_Hsu@asmedia.com.tw
Subject: Re: [PATCH v9 0/6] thunderbolt: Add support for ASMedia NVM firmware
 image format
Message-ID: <Yxg2k/iydKbwzcx/@black.fi.intel.com>
References: <20220906101245.6559-1-chensiying21@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220906101245.6559-1-chensiying21@gmail.com>
Precedence: bulk

Hi,

On Tue, Sep 06, 2022 at 06:12:45PM +0800, Szuying Chen wrote:
> From: Szuying Chen <Chloe_Chen@asmedia.com.tw>
> 
> Hi,
> 
> > Hi all,
> > 
> > This series adds support for ASMedia NVM images. It is based on the
> > work of Szuying Chen with a couple of changes from me. The first
> > patches move Intel specific NVM validation into nvm.c and >adds a
> > vendor table for both routers and retimers that can be extended to
> > support different >vendor NVM image formats. Once that is done the
> > ASMedia NVM image format support is added.
> > 
> > The previous version of the patch series can be found here:
> > 
> >   https://lore.kernel.org/linux-usb/20220902094010.2170-1-chensiying21@gmail.com/
> > 
> > Changes from the previous version:
> > 
> >   * Shuffled the ordering of the patches a bit
> >   * Add tb_retimer_nvm_read() and tb_switch_nvm_read()
> >   * Add ->write_headers() callback that is used with Thunderbolt 2
> >     routers
> >   * Cover retimers too
> >   * Minor cleanups and tweaks
> > 
> > I have tested this on Intel Thunderbolt 3 and Thunderbolt 4 routers.
> > ASMedia folks, can you try this also on your side and let me know if it works or not?
> 
> I send a comments in separate email please help to modify it.
> I have tested this on ASMedia USB4 router. It work well.

I fixed the copy paste issue and applied all to thunderbolt.git/next,
thanks!