Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Sep 2022 15:12:58 +0900
From:   Masami Hiramatsu (Google) <mhiramat@kernel.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Tom Zanussi <zanussi@kernel.org>, Ingo Molnar <mingo@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/6] tracing: Allow multiple hitcount values in
 histograms
Message-Id: <20220907151258.f7864399c05424d0a7a27747@kernel.org>
In-Reply-To: <20220906220346.53a9a623@gandalf.local.home>
References: <166226473132.223837.9011128463174539022.stgit@devnote2>
        <166226474055.223837.13947085068863989044.stgit@devnote2>
        <20220906220346.53a9a623@gandalf.local.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 6 Sep 2022 22:03:46 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Sun,  4 Sep 2022 13:12:20 +0900
> "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> 
> > From: Tom Zanussi <zanussi@kernel.org>
> > 
> > The hitcount is treated specially in the histograms - since it's
> > always expected to be there regardless of whether the user specified
> > anything or not, it's always added as the first histogram value.
> > 
> > Currently the code doesn't allow it to be added more than once as a
> > value, which is inconsistent with all the other possible values.  It
> > would seem to be a pointless thing to want to do, but other features
> > being added such as percent and graph modifiers don't work properly
> > with the current hitcount restrictions.
> > 
> > Fix this by allowing multiple hitcounts to be added.
> > 
> > Signed-off-by: Tom Zanussi <zanussi@kernel.org>
> 
> Hi Masami,
> 
> When posting patches from other people, you still need to add your
> Signed-off-by, as that denotes the people who processed the patch before it
> made it into git.

Oops, I got it.

Please add my signed-off-by;

Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Thank you,

> 
> -- Steve


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>