Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v4 01/21] hwmon: (mr75203) fix coding style space errors
Message-ID: <9323b609-cb9d-8b3d-2894-65296487cdb1@amazon.com>
Date:   Wed, 7 Sep 2022 09:50:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
To:     Guenter Roeck <linux@roeck-us.net>
CC:     <jdelvare@suse.com>, <robh+dt@kernel.org>,
        <p.zabel@pengutronix.de>, <rtanwar@maxlinear.com>,
        <linux-hwmon@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <hhhawa@amazon.com>,
        <jonnyc@amazon.com>, <andriy.shevchenko@intel.com>,
        "Farber, Eliav" <farbere@amazon.com>
References: <20220906083356.21067-1-farbere@amazon.com>
 <20220906083356.21067-2-farbere@amazon.com>
 <20220906165229.GA594012@roeck-us.net>
Content-Language: en-US
From:   "Farber, Eliav" <farbere@amazon.com>
In-Reply-To: <20220906165229.GA594012@roeck-us.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9/6/2022 7:52 PM, Guenter Roeck wrote:
> On Tue, Sep 06, 2022 at 08:33:36AM +0000, Eliav Farber wrote:
>> Fix: "ERROR: space required before the open parenthesis '('"
>>
>> Fixes: 9d823351a337 ("hwmon: Add hardware monitoring driver for 
>> Moortec MR75203 PVT controller")
>
> Coding style "fixes" do not fix the code. I consider using the Fixes: tag
> for those to close to an abuse of that tag (and it would be great if that
> was spelled out somewhere). As it is, I can not with good conscience 
> apply
> this patch to the mainline kernel (especially not for -rc5), meaning the
> entire series will have to wait for the next release window unless there
> are no conflicts. 
Because as you mentioned  it is not a functional fix in the code I’ll
remove the Fixes tag in v5.
I checked older kernel versions and patch applies without conflicts.
That’s also why I moved it to be first in the series, so it will be
before any of my other changes that night cause merge problems for
other branches.

--
Thanks, Eliav