Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jianglei Nie <niejianglei2021@163.com>
To:     chuck.lever@oracle.com, jlayton@kernel.org,
        trond.myklebust@hammerspace.com, anna@kernel.org,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com
Cc:     linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Jianglei Nie <niejianglei2021@163.com>
Subject: [PATCH] SUNRPC: Fix potential memory leak in xs_udp_send_request()
Date:   Wed,  7 Sep 2022 15:13:38 +0800
Message-Id: <20220907071338.56969-1-niejianglei2021@163.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

xs_udp_send_request() allocates a memory chunk for xdr->bvec with
xdr_alloc_bvec(). When xprt_sock_sendmsg() finishs, xdr->bvec is not
released, which will lead to a memory leak.

we should release the xdr->bvec with xdr_free_bvec() after
xprt_sock_sendmsg() like bc_sendto() does.

Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
---
 net/sunrpc/xprtsock.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index e976007f4fd0..298182a3c168 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -958,6 +958,7 @@ static int xs_udp_send_request(struct rpc_rqst *req)
 		return status;
 	req->rq_xtime = ktime_get();
 	status = xprt_sock_sendmsg(transport->sock, &msg, xdr, 0, 0, &sent);
+	xdr_free_bvec(xdr);
 
 	dprintk("RPC:       xs_udp_send_request(%u) = %d\n",
 			xdr->len, status);
-- 
2.25.1