Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp5337473rwb; Wed, 7 Sep 2022 00:52:44 -0700 (PDT) X-Google-Smtp-Source: AA6agR7Wr5urO3hi1lgsGHuPL9fK6lqGEV2kXGZyyO8McrrY2Td5LoVKt/NxWu3oZYHXZ3sGjPT1 X-Received: by 2002:a17:907:6090:b0:734:be0c:e2e7 with SMTP id ht16-20020a170907609000b00734be0ce2e7mr1525746ejc.408.1662537164607; Wed, 07 Sep 2022 00:52:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662537164; cv=none; d=google.com; s=arc-20160816; b=nleoprqCOBXjdVLxJ/F0H1twkls9IkF70/xEy1qXuH9QCvQLIa64oOi6Rk5G0t1Ge8 t68HYKesE7zXv6Axhqc79DLABOke4RfAreDeBMRid5n8fjVyON+oNZk7qetGBDe67MUk 0ZS4c2SA0pSQ/+I3P+dmLOoRGiGUhxUBwgWcrxLnhn1c8PB4HeqrkuQ9FKOuhWx0qSpL UuPm/cWAlx0AzTAz/EmJWevflo1obgrPshjUvQ6IatENU4ar2obsx7zafuc3TF6kIhUS 7bus8jjEwJ4UlvCQtOI+tpm/YpZHJ9VpDp3UOrHsgRsXMH4LxnEfcxE/Kqt47hwM6Y8K sVpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=/UmFOXrSsblqjdp2uLOwDvJz1E4f81egkX5sUfAx9RY=; b=LXDPHKcfpeoV/ZVTQV9yVtD1SGXmHr0exAfh+f55qkJRsn+zMz+PvlGtickUW9zOm8 TGWnFvfHHgjutoS6FvqZov7ObP5FAcVh8NDXcIpU3Cxxbr7TLzQzqdncvCzQU1JTzqYd Vz0WKI4DOuPBKMkk8iMTw2IHqffDZYGJHFZEjkC6jrMaI5F2990dKbOEKLxYUAHzsenz iW9xYzA55bhYBPPDdfioJQC8Y7I1LDaotbSDFKBiLzHS1kp6EeJVrdXFHNzkLP4GcSU+ 7D3CqPDSpqbLNvTG7diu4AvQLoWTIiARhmR86J/kKmxRje5qus/ayGx5pZE8TyBu1vNS BrHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y6-20020aa7ccc6000000b0044e8dc744a4si5195033edt.142.2022.09.07.00.52.18; Wed, 07 Sep 2022 00:52:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbiIGHd5 (ORCPT + 99 others); Wed, 7 Sep 2022 03:33:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229609AbiIGHdq (ORCPT ); Wed, 7 Sep 2022 03:33:46 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 426B4A4051; Wed, 7 Sep 2022 00:33:29 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id EE9656732D; Wed, 7 Sep 2022 09:33:24 +0200 (CEST) Date: Wed, 7 Sep 2022 09:33:24 +0200 From: Christoph Hellwig To: Ming Lei Cc: Dusty Mabe , Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de, linux-raid@vger.kernel.org Subject: Re: regression caused by block: freeze the queue earlier in del_gendisk Message-ID: <20220907073324.GB23826@lst.de> References: <017845ae-fbae-70f6-5f9e-29aff2742b8c@dustymabe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 01, 2022 at 03:06:08PM +0800, Ming Lei wrote: > It is a bit hard to associate the above commit with reported issue. So the messages clearly are about something trying to open a device that went away at the block layer, but somehow does not get removed in time by udev (which seems to be a userspace bug in CoreOS). But even with that we really should not hang. Now that fact that it did hang before and this now becomes reproducible also makes me assume the change is not the root cause. It might still be a good vehicle to fix the issue for real, but it really broadens the scope.