Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220906183600.1926315-1-teratipally@google.com>
In-Reply-To: <20220906183600.1926315-1-teratipally@google.com>
From:   Amir Goldstein <amir73il@gmail.com>
Date:   Wed, 7 Sep 2022 10:46:19 +0300
Message-ID: <CAOQ4uxiNqxx1jK9k2-3yuvVTRwc09__5XMu7MdX75K1FGp5Dhg@mail.gmail.com>
Subject: Re: Request to cherry-pick 01ea173e103edd5ec41acec65b9261b87e123fc2
 to v5.10
To:     Varsha Teratipally <teratipally@google.com>
Cc:     "Darrick J. Wong" <djwong@kernel.org>,
        linux-xfs <linux-xfs@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        stable <stable@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Sep 6, 2022 at 9:36 PM Varsha Teratipally
<teratipally@google.com> wrote:
>
> Hi all,
>
> Commit 01ea173e103edd5ec41acec65b9261b87e123fc2 (upstream: xfs: fix up
> non-directory creation in SGID directories) fixes an issue where in xfs
> sometimes, a local user could create files with an unitended group
> permissions as an owner and execution where a directory is SGID and belon=
gs to a certain group and is writable by a user who is not a member of this=
 group and seems like a good candidate for the v5.10 stable tree given that=
 5.10 is used in versions of debian, ubuntu.
>
> This patch applies cleanly. Let me know what you think
>

Since you already posted the patch, I wrote what I think on the post:

https://lore.kernel.org/linux-xfs/CAOQ4uxi_Q8aXUg+FM0Q9__t=3DKqJSVqOgkS8j8k=
NC3MQfniZLWA@mail.gmail.com/

Bottom line - I think that the patch should be applied to 5.10.y
without further delay.

Thanks,
Amir.