Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 5.15 101/107] kbuild: Unify options for BTF generation for
 vmlinux and modules
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Florian Fainelli <f.fainelli@gmail.com>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Jiri Olsa <jolsa@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>
References: <20220906132821.713989422@linuxfoundation.org>
 <20220906132826.130642856@linuxfoundation.org>
 <291d739c-752f-ead3-1974-a136b986afb7@gmail.com> <YxguwCpBEKAJJDU6@kroah.com>
In-Reply-To: <YxguwCpBEKAJJDU6@kroah.com>
From:   Ron Economos <re@w6rz.net>
Message-ID: <06ea51d3-6f7f-c5c7-0b77-0d4b31ef9a52@w6rz.net>
Date:   Wed, 7 Sep 2022 01:13:06 -0700
User-Agent: Mozilla/5.0 (X11; Linux armv7l; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

On 9/6/22 10:40 PM, Greg Kroah-Hartman wrote:
> On Tue, Sep 06, 2022 at 11:45:00AM -0700, Florian Fainelli wrote:
>>
>> On 9/6/2022 6:31 AM, Greg Kroah-Hartman wrote:
>>> From: Jiri Olsa <jolsa@redhat.com>
>>>
>>> commit e27f05147bff21408c1b8410ad8e90cd286e7952 upstream.
>>>
>>> Using new PAHOLE_FLAGS variable to pass extra arguments to
>>> pahole for both vmlinux and modules BTF data generation.
>>>
>>> Adding new scripts/pahole-flags.sh script that detect and
>>> prints pahole options.
>>>
>>> [ fixed issues found by kernel test robot ]
>>>
>>> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
>>> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
>>> Acked-by: Andrii Nakryiko <andrii@kernel.org>
>>> Link: https://lore.kernel.org/bpf/20211029125729.70002-1-jolsa@kernel.org
>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>> ---
>>>    Makefile                  |    3 +++
>>>    scripts/Makefile.modfinal |    2 +-
>>>    scripts/link-vmlinux.sh   |   11 +----------
>>>    scripts/pahole-flags.sh   |   20 ++++++++++++++++++++
>>>    4 files changed, 25 insertions(+), 11 deletions(-)
>>>    create mode 100755 scripts/pahole-flags.sh
>> My linux-stable-rc/linux-5.15.y checkout shows that scripts/pahole-flags.sh
>> does not have an executable permission and commit
>> 128e3cc0beffc92154d9af6bd8c107f46e830000 ("kbuild: Unify options for BTF
>> generation for vmlinux and modules") does have:
>>
>> diff --git a/scripts/pahole-flags.sh b/scripts/pahole-flags.sh
>> new file mode 100644
>> index 000000000000..e6093adf4c06
>>
>> whereas your email does have the proper 100755 permission set on the file,
>> any idea what happened here?
> Yeah, quilt does not like dealing with file permissions at all :(
>
> We have over time, not required executable permissions on kernel files
> because of this issue.  Is it required here?  If so, I'll try to
> remember to fix it up "by hand".
>
> thanks,
>
> greg k-h

I'm seeing this on my RISC-V build also. The error message (repeated 
many times) is:

/bin/sh: 1: ./scripts/pahole-flags.sh: Permission denied

So the script isn't running.