Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a0298563-bc74-65db-275e-94bd461e5bcd@bytedance.com>
Date:   Wed, 7 Sep 2022 17:08:52 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.2.1
Subject: Re: [peterz-queue:sched/psi 11/11]
 include/linux/cgroup-defs.h:432:38: error: 'NR_PSI_RESOURCES' undeclared here
 (not in a function)
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     kernel test robot <lkp@intel.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Tejun Heo <tj@kernel.org>, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org
References: <202209070242.7EuRnstk-lkp@intel.com>
 <e95c6e55-a023-b6f7-1dce-4195dc22114a@bytedance.com>
 <YxhQ7U0HggaWTmEm@hirez.programming.kicks-ass.net>
From:   Chengming Zhou <zhouchengming@bytedance.com>
In-Reply-To: <YxhQ7U0HggaWTmEm@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/9/7 16:06, Peter Zijlstra wrote:
> On Wed, Sep 07, 2022 at 10:45:55AM +0800, Chengming Zhou wrote:
>> On 2022/9/7 02:33, kernel test robot wrote:
>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/psi
>>> head:   51beb408c569e516780c84a2020920432ad4c5ed
>>> commit: 51beb408c569e516780c84a2020920432ad4c5ed [11/11] sched/psi: Per-cgroup PSI accounting disable/re-enable interface
>>> config: i386-randconfig-a001
>>> compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
>>> reproduce (this is a W=1 build):
>>>         # https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?id=51beb408c569e516780c84a2020920432ad4c5ed
>>>         git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
>>>         git fetch --no-tags peterz-queue sched/psi
>>>         git checkout 51beb408c569e516780c84a2020920432ad4c5ed
>>>         # save the config file
>>>         mkdir build_dir && cp config build_dir/.config
>>>         make W=1 O=build_dir ARCH=i386 prepare
>>>
>>> If you fix the issue, kindly add following tag where applicable
>>> Reported-by: kernel test robot <lkp@intel.com>
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>>    In file included from include/linux/cgroup.h:28,
>>>                     from include/linux/memcontrol.h:13,
>>>                     from include/linux/swap.h:9,
>>>                     from include/linux/suspend.h:5,
>>>                     from arch/x86/kernel/asm-offsets.c:13:
>>>>> include/linux/cgroup-defs.h:432:38: error: 'NR_PSI_RESOURCES' undeclared here (not in a function)
>>>      432 |         struct cgroup_file psi_files[NR_PSI_RESOURCES];
>>
>> Sorry, looks like there are two problems here:
>>
>> 1. NR_PSI_RESOURCES is undeclared when !CONFIG_PSI
>>
>>    Should I send the below diff as a separate patch?
> 
> Please reply to the original patch with an updated version and I'll
> replace it.

Ok, I just sent. Thanks!