Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Divya.Koppera@microchip.com>
To:     <michael@walle.cc>
CC:     <andrew@lunn.ch>, <UNGLinuxDriver@microchip.com>,
        <davem@davemloft.net>, <edumazet@google.com>,
        <hkallweit1@gmail.com>, <kuba@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux@armlinux.org.uk>,
        <netdev@vger.kernel.org>, <pabeni@redhat.com>,
        <o.rempel@pengutronix.de>
Subject: RE: [PATCH v2 net-next] net: phy: micrel: Adding SQI support for
 lan8814 phy
Thread-Topic: [PATCH v2 net-next] net: phy: micrel: Adding SQI support for
 lan8814 phy
Thread-Index: AQHYwRDJNV3vhZ/TwE6+oYymZqWFva3Qz3OAgALhBwCAAANToA==
Date:   Wed, 7 Sep 2022 09:24:06 +0000
Message-ID: <CO1PR11MB4771F4A261174353450FE4E4E2419@CO1PR11MB4771.namprd11.prod.outlook.com>
References: <YxX1I6wBFjzID2Ls@lunn.ch>
 <20220907090750.2937889-1-michael@walle.cc>
In-Reply-To: <20220907090750.2937889-1-michael@walle.cc>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Lk7Ft1WwMAJ7EjMyuuYLFeu3LSuvEUjPX9s9XAO/Syk9GVgxgmjsw5SyuIML?=
 =?us-ascii?Q?pIdWaTFmhRp2PcSa7lj7eRtX4t8eLC+tUqB9py/cUOli8nAfJyXRY/Er40R4?=
 =?us-ascii?Q?TsoVSVV8I/lunFjOtemq3NKE3GmZm8pucSZMoN4phFM6XT5Aemk6LFCXyXov?=
 =?us-ascii?Q?5xaldGcplsJpHYyrUyKYjVtpgU4D+ppilsVemiLOu9O4JfBLLJfKSmz2lmKe?=
 =?us-ascii?Q?ZszIBIaKN4qv9q9JBNT/sKhz1U13de1jpA8u95fXs/j8HyuWPubre9g6uLz6?=
 =?us-ascii?Q?OkUt+qcawBvxGZnynZzQpnF98J/9DbILtt6HL9Qd8SEKV2tXxflmY4ZVX5QP?=
 =?us-ascii?Q?RVP1e1w4wzuPMzshTZOAmEUDv4/Z8C9QXb+Ix5Dm0inNH3Nhuu8INcRbTEwg?=
 =?us-ascii?Q?cdt404KVPqjoPRbsNs9kzHtRQJj3028MfJ/7ZeySglXD/m0k/tlleBK0sECL?=
 =?us-ascii?Q?swnU2jvL4wIv2MHKTWAAKyXJ1cUzTBhji0mL+8cs/j0/lXAv9F7Jzzw7108L?=
 =?us-ascii?Q?Nx4Gk1PtRT/Oq1fk2/a7r8cmEvYY60NdxKBRgNvrO3dO/4RFdeoJ9PDmInpN?=
 =?us-ascii?Q?rK4K9bxkds0eUM68/zrMvsH1I1ACfVOmxTOUPOqejfxkjjRE+Q89RWf+N+ss?=
 =?us-ascii?Q?PFh54Tel1NhFpFn4z3oPpsViiDN4HihmeacrRiwUS8p463zg/msZApE+TaoV?=
 =?us-ascii?Q?ChpevmSF00ANdEoYQpLhdtpvSIRTiodzPzKU7y2e+WNQre9uq+I/r0J3BOrA?=
 =?us-ascii?Q?s7rc8t6Ya6iFOEXz9mc6f+U8OhYsEosxV2i9T7DgL4WIZAh4EdWvDNB3sOCA?=
 =?us-ascii?Q?W/P9q2RSg2MzWcySJxhOy2i4/Cm4ylMeAweuOQ6zhNU2wUDuK8Zr5+/ZfaMw?=
 =?us-ascii?Q?cnr4mSwm/ojNrvLmmj6pM1pII7Izyavp4vRKXXNYM3nsAJDptJAd4z8ZjJf1?=
 =?us-ascii?Q?epqjolsRwCuTRGgoVNqhGILfhoS6zanROiiOm0YzuPiFmAZ+m2EGWt4+hmeK?=
 =?us-ascii?Q?YvOziYijL18LMBHV5KiIos1ov35bV+sGPKhBJ2smfUSnbPj4uZdnh+leqx0f?=
 =?us-ascii?Q?6w9mpsewWC7HxfDi/qs6q9Kt+zC4NRVDv4mrhsEfJKBe9A5zQ4MbhY/O20/Y?=
 =?us-ascii?Q?fnSZP4/7dbPQKwEG2DVNfjqv0fpUPPzka8l1AvAArcnNzFIV7ldXfUrcC7r2?=
 =?us-ascii?Q?T5UHm96rzt1CvRhbI9/fFXHO6elUaS7PCyo4E46iHvvnSa2mdByUt3yPe7Vb?=
 =?us-ascii?Q?Td2Fs5ugzwxOoAaaTAPXR/7D2Nf+MrIxtA2bKhnISk3HgMECjqs+TxJ7s4D8?=
 =?us-ascii?Q?g8/ROd48njHDY4Pqf43mS7QHx+VwKGxCZbXAsFd7eP5uOF0H2BeMrclJmuZC?=
 =?us-ascii?Q?b9Qhz1S3p8FPD7KZ8EnJHXxcnTPuBSUP3lsitWgcJwY7rFyJocuqUxkrG0tU?=
 =?us-ascii?Q?2GQeCwClFJNtXA9wDhiBP5tJ+CPmHIgwJpIlEn68umIxLg+1CWlEFiG76p8l?=
 =?us-ascii?Q?L1lb90Id1Py4z7N04z4XYR7aWZIvVDh5MbYg+EzYAQ7H5CG7pqdOnSFU5pjV?=
 =?us-ascii?Q?Uvm9L3KeYQXBJBORzyewJoAb5DLaSZp8WWSuGm1hS67yZBZPtYnN0e2oh6tM?=
 =?us-ascii?Q?hA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4771.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3abfa3c6-fc01-4fbe-7327-08da90b2b621
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 09:24:06.0257
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PsINU6HpBrwp5U1SkAoWseR/wDB9m+GmWMMwv1Oml0oUini8rdPOU+16MjEOKR9aDvuuaZvD6YZniQ6NjP6g0wy7jVmIT6hPt1GgLA97nbQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5651
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Michael,

> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Wednesday, September 7, 2022 2:38 PM
> To: Divya Koppera - I30481 <Divya.Koppera@microchip.com>
> Cc: andrew@lunn.ch; UNGLinuxDriver <UNGLinuxDriver@microchip.com>;
> davem@davemloft.net; edumazet@google.com; hkallweit1@gmail.com;
> kuba@kernel.org; linux-kernel@vger.kernel.org; linux@armlinux.org.uk;
> netdev@vger.kernel.org; pabeni@redhat.com; Oleksij Rempel
> <o.rempel@pengutronix.de>; Michael Walle <michael@walle.cc>
> Subject: Re: [PATCH v2 net-next] net: phy: micrel: Adding SQI support for
> lan8814 phy
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> > On Mon, Sep 05, 2022 at 03:47:30PM +0530, Divya Koppera wrote:
> >> Supports SQI(Signal Quality Index) for lan8814 phy, where it has SQI
> >> index of 0-7 values and this indicator can be used for cable
> >> integrity diagnostic and investigating other noise sources. It is not
> >> supported for 10Mbps speed
> >>
> >> Signed-off-by: Divya Koppera <Divya.Koppera@microchip.com>
> >> ---
> >> v1 -> v2
> >> - Given SQI support for all pairs of wires in 1000/100 base-T phy's
> >>   uAPI may run through all instances in future. At present returning
> >>   only first instance as uAPI supports for only 1 pair.
> >> - SQI is not supported for 10Mbps speed, handled accordingly.
> >
> > I would prefer you solve the problem of returning all pairs.
> >
> > I'm not sure how useful the current implementation is, especially at
> > 100Mbps, where pair 0 could actually be the transmit pair. Does it
> > give a sensible value in that case?
>=20
> It is good practice to CC the patches to the ones who gave feedback on th=
e
> previous versions. Not everyone is subscribed to all the high traffic
> mailinglist.
>=20

Sorry I missed adding you.=20

> Thanks,
> -michael