Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp5429398rwb; Wed, 7 Sep 2022 02:42:41 -0700 (PDT) X-Google-Smtp-Source: AA6agR4omvvN+YJCbi9Fgjn1lzAFAHOV+GXqEl14nokj4Bhh3al0AYAC/PmZZJ3XykyUYbS5CCI0 X-Received: by 2002:a17:902:e751:b0:174:89f8:cef2 with SMTP id p17-20020a170902e75100b0017489f8cef2mr3021425plf.156.1662543761734; Wed, 07 Sep 2022 02:42:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662543761; cv=none; d=google.com; s=arc-20160816; b=y1seSPQtpNzKQ9fbjgwX5LBaKKi9gsWcVnvOBl0BH9c2/BSghuYwxugMHiJwMqX8Wc GasRM+wm2naiJkcDUeCx5w9uvR96RRiYTkM+3UJy4nRG3Woa6zFVEKcILo6WPxG4t1+J MBlTS1OCsnjhRL8k4MCTAFLSYKAACwXMUFz7J2RX0xApM+bC2kn0dOCfxSuAp/EdWtNZ CK8WNuhvklCY/OjvU72tYFio3Thux8SHOw0uGLK54A49FqJwqFuBgl0LeoXUX0k/Qo2B Hzlra+bvguT+Onpj+PKiyBuxhuIEh+bASL/JXU1Z2Usl6uGHB/Y4Cm3q4PqWYSLFXyWT cyzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=xHdJB+sVlY2abyb+q9sMQIIQ73T9PIWKnbZXtjYkswE=; b=hlXu9RS8b4i+83VlOO2vveHmY948+ej6fSswx9v3BL2mAdQC8I/6YFhjQwl29sW7Pr 7h5ip5MiLS1Gj1HX2NrhmI9avQf+Q8L5RnEZynLy08wchKruyYvnEM6X+ZSlICmHwNtP 4TOdNCCjvDmLCAphRA5T82adIP/4gqVO4p4SuQjZFdiXcuk/rF+jEfuZ2vE3l7Q1XxI6 7pHrA8lpr/heEk4FNE4NtHCs0UXhBl9+WhuQQcSfTk+XMBaPIKb1F2dSO709hdPvbaoF u2XkCAqTeW6oFpWV9/O+hTwZTQ8HArhF1Gi/XEbeYKp8Rhiq0hxDX18rvF0pteWHhD7K 6ThA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n25-20020a6563d9000000b0041c86b0e7a0si13414781pgv.741.2022.09.07.02.42.30; Wed, 07 Sep 2022 02:42:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229648AbiIGIn7 (ORCPT + 99 others); Wed, 7 Sep 2022 04:43:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229847AbiIGInz (ORCPT ); Wed, 7 Sep 2022 04:43:55 -0400 Received: from out199-14.us.a.mail.aliyun.com (out199-14.us.a.mail.aliyun.com [47.90.199.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20464AFAD4 for ; Wed, 7 Sep 2022 01:43:40 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R901e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=xhao@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VOxRMkY_1662540081; Received: from localhost.localdomain(mailfrom:xhao@linux.alibaba.com fp:SMTPD_---0VOxRMkY_1662540081) by smtp.aliyun-inc.com; Wed, 07 Sep 2022 16:41:23 +0800 From: Xin Hao To: sj@kernel.org Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xhao@linux.alibaba.com Subject: [PATCH] mm/damon: Simply damon_ctx check in damon_sysfs_before_terminate Date: Wed, 7 Sep 2022 16:41:16 +0800 Message-Id: <20220907084116.62053-1-xhao@linux.alibaba.com> X-Mailer: git-send-email 2.31.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In damon_sysfs_before_terminate() func, it need to check whether ctx->ops.id supports 'DAMON_OPS_VADDR' or 'DAMON_OPS_FVADDR', there we can use damon_target_has_pid() instead. Signed-off-by: Xin Hao --- mm/damon/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index 7488e27c87c3..88f208ff235d 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -2309,7 +2309,7 @@ static void damon_sysfs_before_terminate(struct damon_ctx *ctx) { struct damon_target *t, *next; - if (ctx->ops.id != DAMON_OPS_VADDR && ctx->ops.id != DAMON_OPS_FVADDR) + if (!damon_target_has_pid(ctx)) return; mutex_lock(&ctx->kdamond_lock); -- 2.31.0