Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp5474599rwb; Wed, 7 Sep 2022 03:31:48 -0700 (PDT) X-Google-Smtp-Source: AA6agR5N56E9ngkWYv6up8obAMdZaRbYwb0bemGnLI1a9o6460sMG88ZLaaFlzF1Z4w0uHYA0iwT X-Received: by 2002:a63:f357:0:b0:423:31a8:8d71 with SMTP id t23-20020a63f357000000b0042331a88d71mr2876000pgj.358.1662546707787; Wed, 07 Sep 2022 03:31:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662546707; cv=none; d=google.com; s=arc-20160816; b=asJR6uhISxpwNnC5ZSiEAf9JAfhyVznUt/z3BSxxN6zyASvGkd4GcX68dIalAkSBm5 dY0dX5vYzrvHXpXGzV0frSc4i8bnMubKIDCZoq7JkCJNVR+2NUdcCXHkyNEZLVgC/o4p X+XbS7FIfTzwDsUKYAo1TMm/XS7n/YTtFBvYaKhg2zS7SHq8wdbgHonjNuh5MTvPBNrF vINuYkA9hQqVWIQjOKohG8ceCI6n8ib9DZR9NrA5BTNOxHhxmtRqzfL0uX1MkvADWkwa KNJPZXBMa71mgO28dAiU3Yy51GztQoe29qve1xjLIsTF58gvzzHHNDAKCefEPmGgsvjU 0OFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=KhRMWJIA/HsolfTT5C4r6dXLGEqazZolLe+juK2zzyE=; b=y+bqV8vFza1K+wVq9Wb8NhuL3QyOQmfblvIiSbE07x73iA8MkFU6fJCqdR0BoCsvNu FOuw/Qv6KNOrEKpxQrN5YFixVguhpmau68JEo7Jsl9JvgqSQgnYfTkWd4IeUIwKrWdLa K/ccVjOeCv7vyQUHU90OnkBMxvNj/cbtRWlHS4tsJ8wNWpHSYkzmtVDyNCImLS/wHwCC +H5A/SYl23VBVqP+JQhblhkN3zs8A66F+RFoPtAgD0bg9+9FLNaob2VDs+dyiMW4cHH0 6LV83jS1/sKPLYOYMNAqrZSGsKrtbV/j9OgknBqmqVOXqd6sajv3749lwTGnaxZn7gYz m4Qw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mu16-20020a17090b389000b001fe26541581si24382252pjb.91.2022.09.07.03.31.32; Wed, 07 Sep 2022 03:31:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230305AbiIGJa0 (ORCPT + 99 others); Wed, 7 Sep 2022 05:30:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230109AbiIGJaY (ORCPT ); Wed, 7 Sep 2022 05:30:24 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 281751ADA2 for ; Wed, 7 Sep 2022 02:30:23 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVrNr-0007yU-Ts; Wed, 07 Sep 2022 11:30:11 +0200 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1oVrNq-0004Gc-3d; Wed, 07 Sep 2022 11:30:10 +0200 Date: Wed, 7 Sep 2022 11:30:10 +0200 From: Oleksij Rempel To: Andrew Lunn Cc: Divya.Koppera@microchip.com, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: Re: [PATCH v2 net-next] net: phy: micrel: Adding SQI support for lan8814 phy Message-ID: <20220907093010.GA16112@pengutronix.de> References: <20220905101730.29951-1-Divya.Koppera@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 06, 2022 at 04:02:19PM +0200, Andrew Lunn wrote: > > We do have SQI support for 100Mbps to pair 0 only. For other pairs > > SQI values are invalid values. > > And you have tested this with auto-cross over, so that the pairs get > swapped? auto-cross is probably the default option. You'll need to force MDI or MDI-X mode. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |