Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e1d933d1-4772-1357-9cf1-6e5b842508c8@amd.com>
Date:   Wed, 7 Sep 2022 16:58:49 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] perf: Rewrite core context handling
Content-Language: en-US
To:     peterz@infradead.org
Cc:     acme@kernel.org, alexander.shishkin@linux.intel.com,
        jolsa@redhat.com, namhyung@kernel.org, songliubraving@fb.com,
        eranian@google.com, ak@linux.intel.com, mark.rutland@arm.com,
        frederic@kernel.org, maddy@linux.ibm.com, irogers@google.com,
        will@kernel.org, robh@kernel.org, mingo@redhat.com,
        catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        sandipan.das@amd.com, ananth.narayan@amd.com, kim.phillips@amd.com,
        santosh.shukla@amd.com, ravi.bangoria@amd.com
References: <20220829113347.295-1-ravi.bangoria@amd.com>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <20220829113347.295-1-ravi.bangoria@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWhocEFsM2NpV2lTSExPd0VtS29YWXVnYnUrdmY4VDAwUjJOdGF6TWJpVkNj?=
 =?utf-8?B?dE9NUC9yRG5GMk9xekhoVU9kejU1cEk5STlFTm1SVlZZYlpoanhBbUJydXlq?=
 =?utf-8?B?U1o0aUo3NXlMY1FBMURRTlRkekp5Ty8yQTFPNGpGcDhKdGFOSTI1UVRMZUNr?=
 =?utf-8?B?MHdodmpYd2RtaURGZlA1cmI1dkJ3WEJEbjBjWHd5VkUyZUV5STZjZDhNWXIr?=
 =?utf-8?B?V2lYZnhhVFVoUUZ4eEV2bW9JL1Bvai9uVUllUlF4RFd3MmpCeHhnMkRYQUVW?=
 =?utf-8?B?M3BYZDNsQUdTdUc2bzFubG9ScWkvR3lHMXVjaFJRZ01QQ0hYZTRwZktqK1Bw?=
 =?utf-8?B?NjEvSUFVUk83TER4c1U2bHNFMHkrS3hGN2grQjNVN2ZxM3hiTGluNzQxRHI4?=
 =?utf-8?B?YWpFRXlQcjdWWi9vZWNKbmlCMEF4NUVZYTVqamRPVWpadkQ4WHRGcy9FWUll?=
 =?utf-8?B?QzJLWVZQV0FBS0tXd3VoQko4VGc4bzJuWVpTbUEwSUhqWWhFeGFtVHM5Y0Jm?=
 =?utf-8?B?cjQxT3FiMWtydC9WVGIvVFpkeUM0VTkwNFhydmdZSUpSUlhwNjg5emxPcDhi?=
 =?utf-8?B?YWtKNkZKTUZxYWZPeWZha1BQTWQ0d1dyZnlQRnMza0RtSkZBdlVBMlA5U05S?=
 =?utf-8?B?MUJwUmVsaWt6SWFMdFdPMGV3b0FvQXFXVy8vY3VIWTFFbCtZVjc3Wnlzb0Zy?=
 =?utf-8?B?Q1E0N1p1VlhHNFRqOFgvU0xtR2ZUYkVreWc0anZhOVFwNEJBQVZMZmJJUmtX?=
 =?utf-8?B?WVppSldPUm5DYk16cXZLNmVwSjFtcCt1YmE3ZEx3cCt0bS9NZktJS1Fmcy9K?=
 =?utf-8?B?QkJVM2lINkxMZDBnanhmM1E0U3k2UDYwWjZFTTRJZDh2Mkw3Nk5uZGFJcnZY?=
 =?utf-8?B?WXk5Q2YrUDVlbFErcUhsQUord2xVRWpKMXBTa1V3dTlqL2xLdHczMDFScTNr?=
 =?utf-8?B?ZjdPR00rVHVmOHphenZuSWxudHBJYmVkSjV6ZWJRUjVlRXJCZFRZOXdFcWVQ?=
 =?utf-8?B?S2JkUnkyZnNBaWZLbkROaThkenBka3dLUWQyQ1FVWDFFUytOMWJ6VkFXMXJh?=
 =?utf-8?B?eUh4Z2kveTY3Z1hDV2J1YSsxaklUZ1l4Ukg2TVhhTzBLTFdmYmwyUlhwWXBp?=
 =?utf-8?B?KzlUcVFDNlZGUFlOUHVNbElobk1FbFNvWUR2cjA0ODlFbUVVbFllWHc4SmdP?=
 =?utf-8?B?L0UvKy9NYjRzUmIyRXVnYkJsVVV0WEJGWVl0WFgxemNoZGN6MnhPVjVYbGpm?=
 =?utf-8?B?QVhvZWF4VHRya2J5eWRaclBXaE9PU28zVWx1WlhZSklidDBEZC9qKy9tY1dX?=
 =?utf-8?B?UmphQ1dzME9POXNrdEEyKy8weGNIZmsvV0RlcHMvZUxmTmh6UElRN1hlaE5a?=
 =?utf-8?B?T2ZNY25uZEhXN0h3MEIrSFp5V1ZvNmN0M1NwVWhYSm1zbjdRYjViQUZiajFE?=
 =?utf-8?B?MW44TVVGY2FzbHh1VGNGem9PRnovRCtUTDlMc1FxeHZwVDN4dUlkb0lTZlEy?=
 =?utf-8?B?eWR1cVpIVXRvQmdEa3BHMVBqWFlMTW9LdUcvbFRLWmhOQmN0Z1hBRUdOd1Br?=
 =?utf-8?B?VUtueXdBblRGM1hhUS81K3Z0bC9wcmNIVXM5MmJNQUpndHpCemtRaW9KOVJz?=
 =?utf-8?B?YW5pMWUxbGY3ZnNrTmE1V3VnMXlJaFpzV1lWSDVTZkpVMDJjWkpnUnozejNk?=
 =?utf-8?B?MUxzUVhMT2p1ajdoY2N1SFJOaWtTUUxRWDRweERzVENTU2FDMVJpVTM2dURJ?=
 =?utf-8?B?TE14RDVPaFA0cSs0NTFBbGg0UnZvK3c3VmdxLzIwQ2dreC93VjNRUThmSGFI?=
 =?utf-8?B?NkgxV09OK2svMm9SSUozTHdZUnRMUVFvc3VsQ3pFOU1pVk5hUlZ0ZVVqd0NJ?=
 =?utf-8?B?cFVMWmljekFnakE5aGVVakNhQ1huNm5UekoxQ0hOTnJDVnZPSld2NDg5aE1V?=
 =?utf-8?B?UExQMlY1bHVaY0hqbnhhcXB6K2haL2hURlozUUFsK2kxNm13aHk4Mk1zUXc3?=
 =?utf-8?B?a2k4R2Q2alkzNVBzY1ZUcElYekxxSU8zRDdxVVdnTXQ2ckhkd1U2VWZQT3Z4?=
 =?utf-8?B?bG5qV1BGazRscGtvQ3MrUU92bHlwcFhLakNTSzhvVGIzWjY2R2xDbEJmQnFH?=
 =?utf-8?Q?NMSQguppoS2ffePfYR0xLcGE+?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89476fed-59c9-453a-8951-08da90c42cf5
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 11:29:07.3613
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iMQRt+CTeI5T2LXlAvNuNSvHTL4GPmcy3jTOcPyBR7HwZUoocRNQGos6vglV51U9EAz61XjXqY4vNOl4wx2poQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5124
X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -static void
> -ctx_flexible_sched_in(struct perf_event_context *ctx,
> -		      struct perf_cpu_context *cpuctx)
> +/* XXX .busy thingy from Peter's patch */
> +static void ctx_flexible_sched_in(struct perf_event_context *ctx, struct pmu *pmu)

This one turned out to be very easy. Given that, we iterate over each
pmu, we can just return error if we fail to schedule any flexible event.
(It wouldn't be straight forward like this if we needed to implement
pmu=NULL optimization.)

---
diff --git a/kernel/events/core.c b/kernel/events/core.c
index e0232e0bb74e..923656af73fe 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -3751,6 +3751,7 @@ static int merge_sched_in(struct perf_event *event, void *data)
 			cpc = this_cpu_ptr(event->pmu_ctx->pmu->cpu_pmu_context);
 			perf_mux_hrtimer_restart(cpc);
 			group_update_userpage(event);
+			return -EBUSY;
 		}
 	}
 
@@ -3776,7 +3777,6 @@ static void ctx_pinned_sched_in(struct perf_event_context *ctx, struct pmu *pmu)
 	}
 }
 
-/* XXX .busy thingy from Peter's patch */
 static void ctx_flexible_sched_in(struct perf_event_context *ctx, struct pmu *pmu)
 {
 	struct perf_event_pmu_context *pmu_ctx;
---

Thanks,
Ravi