Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Sep 2022 10:48:33 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Takashi Iwai <tiwai@suse.de>
Cc:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <jroedel@suse.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Eric Auger <eric.auger@redhat.com>,
        regressions@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION 5.19.x] AMD HD-audio devices missing on 5.19
Message-ID: <YxihMchpLRPAqNWx@nvidia.com>
References: <874jy4cqok.wl-tiwai@suse.de>
 <20220823010021.GA5967@nvidia.com>
 <87h723sdde.wl-tiwai@suse.de>
 <87ilmjqj1f.wl-tiwai@suse.de>
 <20220823202824.GA4516@nvidia.com>
 <87bkrrl3eo.wl-tiwai@suse.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87bkrrl3eo.wl-tiwai@suse.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tm0Yuj6srJ+A6YD0WT1VBtQ9+Ibi0S5GG54ZxUd/k++cEmdsrtvIVMI72UYf?=
 =?us-ascii?Q?UbB5JXh5AwvC6vN1W3PcBE8UGKQtMbZZFdmBd7aS42IccypC0+kDLM6IBxAo?=
 =?us-ascii?Q?ZWWFj9sbOpXTKqBp6VCd21R7wdMFB63gCWKpNJh0UczeYI2vRExIcohKUkAF?=
 =?us-ascii?Q?kHiM72d88UApZXtAwfc9XrbndIzH60rUtOh2CrXd9JgJWg6+G7FhtJ6Od9Qw?=
 =?us-ascii?Q?vkC/d1L+PGbvsi81UGX0Di25hQbMiutNADw8/G1q6khUU0cTHX1/VgCcjgsu?=
 =?us-ascii?Q?3OcpvRVfEH6n3FYXLsKCPMgRWJlQDv8TjxbjozF8+mCLfgsNoo9iWj0TO4TI?=
 =?us-ascii?Q?D/jZAzIvLtrWFunakpjqX115ZwEPVDLx/fCUBJR+/xiPZMQopDYKjrqsnJQn?=
 =?us-ascii?Q?JUHWn121cU0ZOScQPu/3SWq78V18jXaCiBoBMQOJv8i+iwr9RrIbGmMl/b92?=
 =?us-ascii?Q?3rx4vIOiLbmzigSmF3bAnY/cZKJWk3f6G6xV8+XGnnWFa84zBxvjc6Iar/lx?=
 =?us-ascii?Q?NBZNt1MmeSWFg5aIoZsegnOxCRF+cIUOXcY3n35pJ1Gjj+xY4pUZkOnzCZ47?=
 =?us-ascii?Q?TUoR2dpkwSfZQ7FLvR2qjjXvGxuTAG12mg81mhbn+Hb8dkazY/BjqA/k0tAx?=
 =?us-ascii?Q?oXVG20rZXnfipOmX7Mf07bGnZHWEp29yNfGrvAk1kF3M6O/h+pZoeKSRwbnN?=
 =?us-ascii?Q?HAlZONiMPtb5XlITusil7JjciWC3YrISriladF5QeIYn8lkuajl66u/ueEbU?=
 =?us-ascii?Q?0sOvMsM0Ehut3lNwG9WfkSnDq3MWrxJHTVwbcDsX3dw+rgpSfFmYgE5zV1sI?=
 =?us-ascii?Q?/2wEGk+B+guQAFk/iX1LUuYKm0J9+fihc3Uaa1tq920IlzQKcElclZ70SHoy?=
 =?us-ascii?Q?nlxf2YjUAHbZ7t8dQTbUO6at3W30ZUyfeRU/1GS2PRWOU5GJv3CfibAq2drg?=
 =?us-ascii?Q?LN4vooHe+LbNKCu+vg15YjIPLd2cd4j2H+x+j/xFxc0M24n6zcgPqMzU8wnZ?=
 =?us-ascii?Q?fA8i4qL9WfhLfv0Ajn1to7piDdTMppqzVqIRClWJGXTJI8Xdo9NVglxCQaD8?=
 =?us-ascii?Q?AX1+vahE5KEIic9wL3Fq1fQaOikUMZNj6zIGm4nAT8Ot0FaQxie4GkFM++hc?=
 =?us-ascii?Q?qqeB/UhesnvS8O9ea28EPIe2F9Co/ouVYTjHrn51e0pDaltGaZrq3BOAc2Bc?=
 =?us-ascii?Q?Azg4NKaC8HCYvtZrpDYFpW5wPOlZmyZV5JI/8WyL84eFboAkdjoMRziN02UW?=
 =?us-ascii?Q?HQ0s1YknAH0OcUmA2fXr9LyQtIHPgnvISqYcQF7Xs12A38p+5gLSn4wWiU+h?=
 =?us-ascii?Q?Oa+iQBVURvfO7PciYhlBipRaGFPFL9PQCQreVmIyoL0HcelqqE/ZtI3mc9mR?=
 =?us-ascii?Q?B1C7iAmSIHSNSA6GjfecGUzYpptKuLIqP02neNGcjl+SArfj+Yc0ZF/DHK5e?=
 =?us-ascii?Q?460MRDJ3UgiSqX9cECHPLp6B+58PBUUESHNcLVLQWmq4pVXEzlYjgl1/Dwjl?=
 =?us-ascii?Q?6VbfqHjacfDYs1ajtKkdObQwkzizEetO4mZB6XJQosPY2nNToxY6VQ3TcFBI?=
 =?us-ascii?Q?e6kZkTHNYKx+wJjSXe8CFDzmUlPHEKxe9wbnSNBW?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5099cdc7-fd7e-471d-6f5b-08da90d7a86a
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 13:48:34.5043
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UariDeMcgGG9F7v4pP18dGdoFmB2A6BjZqiIZh+sdO+dMgSCUhUJNoYvFTsFyQyN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6103
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 07, 2022 at 03:28:31PM +0200, Takashi Iwai wrote:
> >  /**
> >   * iommu_device_use_default_domain() - Device driver wants to handle device
> >   *                                     DMA through the kernel DMA API.
> > @@ -3094,8 +3112,7 @@ int iommu_device_use_default_domain(struct device *dev)
> >  
> >  	mutex_lock(&group->mutex);
> >  	if (group->owner_cnt) {
> > -		if (group->domain != group->default_domain ||
> > -		    group->owner) {
> > +		if (group->owner || iommu_is_default_domain(group)) {
> 
> Isn't this rather 
> 		if (group->owner || !iommu_is_default_domain(group)) {
> ?
> 
> I'll rebuild the kernel with this change and ask reporters again.

Oh yes, good eyes, that probably crashes on boot too

Jason