Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3097d4b8-a9d0-878c-3b95-5499ed943576@gmail.com>
Date:   Wed, 7 Sep 2022 10:11:56 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH v10 0/2] Introduce block device LED trigger
Content-Language: en-US
To:     torvic9@mailbox.org
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
References: <2047607620.67144.1662552964865@office.mailbox.org>
From:   Ian Pilcher <arequipeno@gmail.com>
In-Reply-To: <2047607620.67144.1662552964865@office.mailbox.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/7/22 07:16, torvic9@mailbox.org wrote:
> Hi Ian,
> 
> with a heavily patched Linux 6.0-rc4 with kfence, kmemleak and slub_debug I get the
> following splat at boot:

Sorry about that!  I'm not sure how that slipped throgh, as I was sure
that I tested the new version before I sent it off.

Basically, I messed up while cleaning up the function parameter names,
so you need to apply this:

--- drivers/leds/trigger/ledtrig-blkdev.c.old   2022-09-07 
10:00:26.194484681 -0500
+++ drivers/leds/trigger/ledtrig-blkdev.c       2022-09-04 
11:36:16.107690614 -0500
@@ -540,7 +540,7 @@
                 return ERR_PTR(-ENOMEM);

         bdev = blkdev_get_by_path(strim(buf), BLKDEV_TRIG_FMODE, 
THIS_MODULE);
-       kfree(path);
+       kfree(buf);
         return bdev;
  }

> I'm not 100% sure if this is an issue with ledtrig_blkdev or something else,
> but I thought I'll let you know about it.
> I have not been able to test this on a vanilla kernel yet.

Defnintely my fault.

> Other than that, I hope this patchset gets included in upstream.
> I have been using it for a long time now and found it very useful.

It's really hard to know if anyone is interested in/using this, so
that's great to hear.

-- 
========================================================================
Google                                      Where SkyNet meets Idiocracy
========================================================================