Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Wed, 7 Sep 2022 05:32:16 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     lizefan.x@bytedance.com, hannes@cmpxchg.org,
        cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>,
        Waiman Long <longman@redhat.com>
Subject: Re: [PATCH] cgroup/cpuset: remove unreachable code
Message-ID: <Yxi5gI1f2MxdC0c9@slm.duckdns.org>
References: <20220907040112.82030-1-jiapeng.chong@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220907040112.82030-1-jiapeng.chong@linux.alibaba.com>
Precedence: bulk

(cc'ing Waiman and quoting the whole message)

On Wed, Sep 07, 2022 at 12:01:12PM +0800, Jiapeng Chong wrote:
> The function sched_partition_show cannot execute seq_puts, delete the
> invalid code.
> 
> kernel/cgroup/cpuset.c:2849 sched_partition_show() warn: ignoring unreachable code.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2087
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---

Applied to cgroup/for-6.1.

Thanks.

>  kernel/cgroup/cpuset.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index 6baa977a71ba..b474289c15b8 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -2846,8 +2846,6 @@ static int sched_partition_show(struct seq_file *seq, void *v)
>  		else
>  			seq_printf(seq, "%s invalid\n", type);
>  		break;
> -		seq_puts(seq, "isolated invalid\n");
> -		break;
>  	}
>  	return 0;
>  }
> -- 
> 2.20.1.7.g153144c
> 

-- 
tejun