Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <5b2f5918-b26b-f7d3-7764-7832be139a92@roeck-us.net>
Date:   Wed, 7 Sep 2022 09:00:05 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v4 02/21] dt-bindings: hwmon: (mr75203) fix "intel,
 vm-map" property to be optional
Content-Language: en-US
To:     "Farber, Eliav" <farbere@amazon.com>
Cc:     jdelvare@suse.com, robh+dt@kernel.org, p.zabel@pengutronix.de,
        rtanwar@maxlinear.com, linux-hwmon@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        hhhawa@amazon.com, jonnyc@amazon.com, andriy.shevchenko@intel.com
References: <20220906083356.21067-1-farbere@amazon.com>
 <20220906083356.21067-3-farbere@amazon.com>
 <20220906165359.GA817639@roeck-us.net>
 <f638f9bc-b757-c352-7be0-4f9ab6607378@amazon.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <f638f9bc-b757-c352-7be0-4f9ab6607378@amazon.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9/6/22 23:28, Farber, Eliav wrote:
> On 9/6/2022 7:53 PM, Guenter Roeck wrote:
>> On Tue, Sep 06, 2022 at 08:33:37AM +0000, Eliav Farber wrote:
>>> Change "intel,vm-map" property to be optional instead of required.
>>>
>>> The driver implementation indicates it is not mandatory to have
>>> "intel,vm-map" in the device tree:
>>>  - probe doesn't fail in case it is absent.
>>>  - explicit comment in code - "Incase intel,vm-map property is not
>>>    defined, we assume incremental channel numbers".
>>>
>>> Fixes: 748022ef093f ("hwmon: Add DT bindings schema for PVT controller")
>>> Signed-off-by: Eliav Farber <farbere@amazon.com>
>>> ---
>>> V3 -> V2:
>>> - Change this patch to be first in the series.
>>> - Add explanation why "intel,vm-map" is not required.
>>>
>>
>> I don't see how this change warrants dropping Rob's Acked-by tag.
>> Am I missing something ? 
> 
> My apology. I wasn’t aware I had to keep the Acked-by tag.
> I'll add it in v5.
> 

"have" is such a strong word. Just keep in mind that unnecessarily
dropping tags tends to result in irritated reviewers.

Thanks,
Guenter