Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Sep 2022 09:52:17 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Davidlohr Bueso <dave@stgolabs.net>, Borislav Petkov <bp@alien8.de>
CC:     <dan.j.williams@intel.com>, <x86@kernel.org>,
        <nvdimm@lists.linux.dev>, <linux-cxl@vger.kernel.org>,
        <peterz@infradead.org>, <akpm@linux-foundation.org>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <a.manzanares@samsung.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] memregion: Add arch_flush_memregion() interface
Message-ID: <6318cc415161f_166f2941e@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220829212918.4039240-1-dave@stgolabs.net>
 <YxjBSxtoav7PQVei@nazgul.tnic>
 <20220907162245.5ddexpmibjbanrho@offworld>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220907162245.5ddexpmibjbanrho@offworld>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uwctkrgmf9mFUaUC5bsarsXazGM0/y0yrCURjne6314mlhP7FfrQjO2I3HsN?=
 =?us-ascii?Q?mreaIcZ9ceMHgh0tUNiyKEoMxmnPTCSiH+WzHKT1CNF67SfdNrkTCS+6I7kU?=
 =?us-ascii?Q?omNh3QSY8qLRXODANjV2CU6UWxLPBqdfWGSmqYBDIi67+QIvcYJDqUaQo3fB?=
 =?us-ascii?Q?1tTVYCQRZjxsbPy3UoJVtH5U2rOI44mjgUM+9mKC4SvuWJMHrTqj7REB4Mr3?=
 =?us-ascii?Q?RolaKrgYcQOZEeQNFekmcG2Ae/eOVhK7J0zWOR+++vzZdmEsmC2+gW0rla+d?=
 =?us-ascii?Q?HUs/Nt+K185mMUUA1Qg6c15R+QHjtLpb1lG+nvehebuFiezXxvzFbcLtpRbO?=
 =?us-ascii?Q?Gjce2lDtJsdgnGB6aGoxRblq4AWoxikkzQxhsM7gXJZwYLc/g7QQSw086xT5?=
 =?us-ascii?Q?OjW7kDf1SUJ3hTXQVhzjOXQnAzW1sniSvEgU8NTXQh1rOzj4xMBT0ABVUFWs?=
 =?us-ascii?Q?Tv6JKXxYhhSJ1eUQdOUFOed7NXtl3mFYTD6Rd5qYQxpMPfLaZEY2z1T8pQct?=
 =?us-ascii?Q?oVcCqQePDmBat1OafPBVdhjQIKyK57XKBRJDYAhP6+bA5c74spmby1EaAbug?=
 =?us-ascii?Q?3Jt+5IYYexepHMg0fzHrj/Dge/69ulx3x13LAufPjkrKm+Z0YjXKhKaoIs4z?=
 =?us-ascii?Q?kvfVjY54PppeJLXcyPyKyqzKUkUSmWGsk9IWueq5AygIvHqbiK1wyx5ofyBo?=
 =?us-ascii?Q?elYVduWhiOfbrllWY981IflfVjMtkO3y6Dk8E0Z8poVPojsqqapZIBSC5pC2?=
 =?us-ascii?Q?2CTNjwHIpE36hU/RzVECRIwW2xdIkUmPNq1mWazrhKtpCElOZxy8chCh+Uy+?=
 =?us-ascii?Q?Kvq1TynB7zhdTdCVd0daEJWwDSab9SLkyZ8yFjn+6ckf2dnqjuwI48X8ROdb?=
 =?us-ascii?Q?7gUMBW7JRT7kFahwqlHTMfuRLCFcH7MbQX524iqyFJR7vuu6WO8ybJdmwLyA?=
 =?us-ascii?Q?pGJjDKfQM8LspM/7p4yrfD9tjhzOvD/JtqfoLXEk4NiMBuMtonz7GRLar82Q?=
 =?us-ascii?Q?kRVLBVXhPGQnEupP0j5vI201hR1WrrCegyXbQXH6CbGw41+dfmclXPM9lFZX?=
 =?us-ascii?Q?tIAWMJLF9HEftbI6lSd5hXQ3ATyckTHN5HVTyMEHEh4rcIkEb/yveH3cvyWZ?=
 =?us-ascii?Q?Wjo0Ez8+DPWjnL1hIeg+ILfndPAjnh3DBjefo0lSa730UD3t4SgLKzj6+bUb?=
 =?us-ascii?Q?DSFPH2i3QnO9+Nd6jMmL5U6ogey414JkZoA1gzz406QaWqdsQZQguDIl+HDe?=
 =?us-ascii?Q?XBiSFGDhAvp2M8KsILPy1keFgrmasRTNpdCIGmD0mkBN6bbFd1KvbBinZ4Lc?=
 =?us-ascii?Q?t2K1mHG6wimdCAufnW/hYXw4wJsdhT3FSkzGlf0PrVc3evH0pRgjY13zTiNH?=
 =?us-ascii?Q?74bTGV92ybYxwC9lMZWiYmS4MD/GXoR7BBPd94ZkdngELBrPLy1KE5IlHRVh?=
 =?us-ascii?Q?/Olu5O1RNC1WluEGeO2xV41osoSdi97YNJJIEXmo++oLnpHkKWQhSRmPIRoz?=
 =?us-ascii?Q?l0g4oeLUaZS3wHlLtqZwszkIoFGmu2BNuO5M3wGO4SEz/DaY80tBPvUtFqSV?=
 =?us-ascii?Q?O/pIKIxBZBChC57DcWCuaU4pShmzIZ6GqsMbLnvgw6jQsW2zeKa24LQ0HazE?=
 =?us-ascii?Q?QA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8982f638-06ff-4df1-334b-08da90f153f8
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 16:52:19.8826
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1+Zl5xVIr9qvP6QsAD/nCdcm6J4RDMlwIfoQVQlptw13qd0GrRC3wpwdX9F/WpirKTNPjyx7Hn+795EbQVsgEuKawCvsgW/cPmM7nhCaJnM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7136
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Davidlohr Bueso wrote:
> On Wed, 07 Sep 2022, Borislav Petkov wrote:
> 
> >On Mon, Aug 29, 2022 at 02:29:18PM -0700, Davidlohr Bueso wrote:
> >> diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c
> >> index 1abd5438f126..18463cb704fb 100644
> >> --- a/arch/x86/mm/pat/set_memory.c
> >> +++ b/arch/x86/mm/pat/set_memory.c
> >> @@ -330,6 +330,20 @@ void arch_invalidate_pmem(void *addr, size_t size)
> >>  EXPORT_SYMBOL_GPL(arch_invalidate_pmem);
> >>  #endif
> >>
> >> +#ifdef CONFIG_ARCH_HAS_MEMREGION_INVALIDATE
> >> +bool arch_has_flush_memregion(void)
> >> +{
> >> +	return !cpu_feature_enabled(X86_FEATURE_HYPERVISOR);
> >
> >This looks really weird. Why does this need to care about HV at all?
> 
> So the context here is:
> 
> e2efb6359e62 ("ACPICA: Avoid cache flush inside virtual machines")
> 
> >
> >Does that nfit stuff even run in guests?
> 
> No, nor does cxl. This was mostly in general a precautionary check such
> that the api is unavailable in VMs.

To be clear nfit stuff and CXL does run in guests, but they do not
support secure-erase in a guest.

However, the QEMU CXL enabling is building the ability to do *guest
physical* address space management, but in that case the driver can be
paravirtualized to realize that it is not managing host-physical address
space and does not need to flush caches. That will need some indicator
to differentiate virtual CXL memory expanders from assigned devices. Is
there such a thing as a PCIe-virtio extended capability to differentiate
physical vs emulated devices?