Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH net-next v5 3/8] net: phylink: Generate caps and convert
 to linkmodes separately
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Alexandru Marginean <alexandru.marginean@nxp.com>,
        linux-kernel@vger.kernel.org,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>
References: <20220906161852.1538270-1-sean.anderson@seco.com>
 <20220906161852.1538270-4-sean.anderson@seco.com>
 <YxhnaqCfKMKm5zFy@shell.armlinux.org.uk>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <2e258a31-4ca1-c757-cbe1-cb352015ba96@seco.com>
Date:   Wed, 7 Sep 2022 12:55:24 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
In-Reply-To: <YxhnaqCfKMKm5zFy@shell.armlinux.org.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NE5adnN6WVNYTWJ1aTQwSENmZWp2Q2JJWUtEZHJZS3ZtRlFOZzVlYThESHVC?=
 =?utf-8?B?UWw3VlJFTURHcTlEckhTMTRLRVh4bU8zRkx6YU5HTWMxZU00NXlRaTlyemtB?=
 =?utf-8?B?b21TQU0xZ2ZPaWpUb09XaWN5UTZuOERyRkg1K3ZiV3IvUms0ZFc4aU9UVExF?=
 =?utf-8?B?R3ZoZkZtYU5FTHoxdHZid1BoR1MxMlFhSysxVk1uM1pvRm1aVUxxelVwUGVN?=
 =?utf-8?B?L0d3eGJXR2xUUXduNy94M1ZCaGdSZE9LZGtzTFU5UWloYVNrV2h5NEtSZUth?=
 =?utf-8?B?YVVZQ2V3ZGdaSktKdzhXTjN6WjI3a2dLUmx4YUlJVGtKTUxBM0xYUHZHRm9N?=
 =?utf-8?B?U3RlcEtwZ0FkN29LTmxoU25zK25EMmJJSUx6dXB6cHhpZUN2RHY3d1R3TVZt?=
 =?utf-8?B?VjNobUwwdmpKMjdOSDVFSG81VkhZaVhxWWpJUFhTNmNHN0ZDNTh4Q1k1MDhw?=
 =?utf-8?B?WktyMFZlYlhUbnVsVU9xSEFDQ2pXUWF0NHdEMXpLaUhUaUZXRWZRa1h5ZmVi?=
 =?utf-8?B?aDlPTFVubGFoY0l5QnR4UlQ0c1pHN2ZUbklTampKSWxMUloxbzRtU01hR0Ir?=
 =?utf-8?B?R0FvMS9wTjUrcktjdm5CcGFnUFdVNHVabjRlUWNwdEVDNVFYR2xRZHVTWjdV?=
 =?utf-8?B?RERVbmYzbEhKbUEzcFdaRk05aEIvdnkvUkV2MjhQOGc0MndLVUo5ZkV4emFH?=
 =?utf-8?B?WTRreE52amVXcFNVQnpDQnYyWDF1M2pvQVh0OTFBYzZ2T2xra1ZwWk1KSklC?=
 =?utf-8?B?WDRNdjdYRkNWSDNHVDZKRGFIWlBTRW10a05NcjYrbGJOWGd0N1IwMVdBMU90?=
 =?utf-8?B?Ymg4N2Q4dkVweGhkbE1ZLzBLTmc3amNGc1ZYcVV3TXJGUUxmajFsQi9CT0x1?=
 =?utf-8?B?WXd5Vk9MMSt5bkJSZ3NTeG1Xb0tJU2p4Q1JYZFV1QVZQN1VrLzBOT3BRV0Fw?=
 =?utf-8?B?UzBEc1lLWGo2SEFneFhCc2FNQzVid2hLU2RrU3NrMmxMMkl0SGFlRERVbVNU?=
 =?utf-8?B?WFd1ZkhmUXk5T0w2ZmVNN0dkcytkVXR1bUlhL2NuWWRYSG5uR250bVJvQXJ1?=
 =?utf-8?B?eVF3V1BLRHIvV25yZW1qbVZpakptR0NQY0R3eWM3K0xRK3g4NzNydFNRSnZL?=
 =?utf-8?B?TU1IbkNCVzdRYU0yOHlUNTU5WVIzekRUQmxxekpJRnRzNUEzVW9PVUUzOWJq?=
 =?utf-8?B?Um5Hc2RuMVVwZUpXazgvbUZiQ29WMFU2blRpcHgyR0ZpWFlhK1dNK1RmVE94?=
 =?utf-8?B?eVpFcEtRelhkbGhNZUVUYm44ZW9WUDE0N1dBZnRGRWNsWTl1cEVvcXZuVXIy?=
 =?utf-8?B?WmJiZGhaUS9VRml1YkdLeStWUDZxNnQyWFZhSkhwRDRNS3kvVEJEWGJqNFpK?=
 =?utf-8?B?RDRvcW40WjZReDZVWmV5bEQ2TWF5SXZyNVdvN0NFc256RXhLanNUb3ZpcWRl?=
 =?utf-8?B?c1pzWjdWSHhVWVJ0dklnd0xhT0hETVM4MWV2c2FsK2taRHdTYnBnWUxMSzh3?=
 =?utf-8?B?NCtibUdpYTBrejloSmxNeWhsbjdiYUNKRUdmSll5dzJYc2k5OTI5TzI5T0Vy?=
 =?utf-8?B?U1kzOWhmajJoSzlIRHdVUndEY3VjbGlOL0wzRXZkb25IcVNkWlRZR3NMV3dw?=
 =?utf-8?B?VGtrNmdybFdsRVdDeS9qTEFqbXBObnFsRkJScmk1QVN5WEIrU1pNb3Raa0Jm?=
 =?utf-8?B?L2E5NVN6QmI0dnJpRmIwdURxYU84eUxRYmtJSUxXUVNUcmpTZGR1blNweVFi?=
 =?utf-8?B?MHlNYlZuOEdlTm13NEUyY2RFbE02Nmdvbk9vb1pycHVKaU0rWmFvaEozajFl?=
 =?utf-8?B?MTA0UEl3VEd1aWdwMjJ2aE1hKytwdGFUVXdPc05PVnIzRW84enJvQzgySDJL?=
 =?utf-8?B?MmMzdGFXNmFWYzNXU2pHeWJLYlFhTjQvbkFIVWg0YVNFT2dVNWlCY3ViWTRr?=
 =?utf-8?B?NHd4RDhqTzJCU0JWVHY1bS9XdUliTGhsRHBMeHBkWmJRZXFDTW5sY2ZZamNx?=
 =?utf-8?B?LzlrVlZkNWIrS0Rxdjh0aWQxYjRrbkZ4cUczWGI2WFJUQW5YaFIxMDdybWNr?=
 =?utf-8?B?UnB3dHA2QlBMM25YVkVEQ1V5Q2k1cko4SDNMY0NSaFVkcC9NS1dZSFN2THp4?=
 =?utf-8?Q?qrLNg18GLKVMBguI8vYKOurFG?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ba7720a9-d724-4d82-282e-08da90f1c48f
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 16:55:28.7455
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7DA6d1h3RkLG7eflbOcCCPUVaMX5TKhjwAw9OCUxfq0M29d0L6M/DTUNNQ6ZOb2/0FqhSUuHc5hQT5Lynf6r2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB3841
X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/7/22 5:42 AM, Russell King (Oracle) wrote:
> On Tue, Sep 06, 2022 at 12:18:47PM -0400, Sean Anderson wrote:
>> @@ -409,11 +407,14 @@ void phylink_generic_validate(struct phylink_config *config,
>>   			      unsigned long *supported,
>>   			      struct phylink_link_state *state)
>>   {
>> +	unsigned long caps;
>>   	__ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, };
> 
> net code requires reverse christmas tree for variable declarations.
> 

OK