Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d1950d7d-fc23-6195-4e07-fa2ae2893d45@quicinc.com>
Date:   Wed, 7 Sep 2022 10:07:17 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [mani-mhi:mhi-next 2/3]
 drivers/bus/mhi/host/pci_generic.c:734:60: error: assignment of member 'irq'
 in read-only object
Content-Language: en-US
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
To:     Manivannan Sadhasivam <mani@kernel.org>,
        kernel test robot <lkp@intel.com>
CC:     <kbuild-all@lists.01.org>, <linux-kernel@vger.kernel.org>
References: <202209072144.lWoBySRH-lkp@intel.com>
 <20220907164506.GA499781@thinkpad>
 <f5d17990-ec36-e930-be33-e2566b9c0593@quicinc.com>
In-Reply-To: <f5d17990-ec36-e930-be33-e2566b9c0593@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9/7/2022 9:56 AM, Jeff Johnson wrote:
> On 9/7/2022 9:45 AM, Manivannan Sadhasivam wrote:
>> On Wed, Sep 07, 2022 at 09:47:42PM +0800, kernel test robot wrote:
>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git 
>>> mhi-next
>>> head:   0a3b31f6259f4849e4e93731d4c8d7910be072a7
>>> commit: 4a98958ca237a4b7974ea1ec2092b3666bdd26ab [2/3] bus: mhi: 
>>> host: make mhi_controller_config::event_cfg const
>>> config: i386-randconfig-a001 
>>> (https://download.01.org/0day-ci/archive/20220907/202209072144.lWoBySRH-lkp@intel.com/config)
>>> compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
>>> reproduce (this is a W=1 build):
>>>          # 
>>> https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/commit/?id=4a98958ca237a4b7974ea1ec2092b3666bdd26ab
>>>          git remote add mani-mhi 
>>> https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git
>>>          git fetch --no-tags mani-mhi mhi-next
>>>          git checkout 4a98958ca237a4b7974ea1ec2092b3666bdd26ab
>>>          # save the config file
>>>          mkdir build_dir && cp config build_dir/.config
>>>          make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
>>>
>>> If you fix the issue, kindly add following tag where applicable
>>> Reported-by: kernel test robot <lkp@intel.com>
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>>     drivers/bus/mhi/host/pci_generic.c: In function 'mhi_pci_get_irqs':
>>>>> drivers/bus/mhi/host/pci_generic.c:734:60: error: assignment of 
>>>>> member 'irq' in read-only object
>>>       734 |                         
>>> mhi_cntrl_config->event_cfg[i].irq = 0;
>>
>> Ah, so this is why I didn't make it constant in the first place...
>> Dropped the patch now.
>>
>> Thanks,
>> Mani
> 
> I believe it should be const in the MHI config, but in this case the 
> declaration in drivers/bus/mhi/host/pci_generic.c can't be const.
> 
> Let me respin the patch with this in mind.
> 

NM, just drop it. Too much pain for the little gain I was hoping for in 
the ath drivers :)