Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Sep 2022 10:11:44 -0700
From:   Cong Wang <xiyou.wangcong@gmail.com>
To:     Zhengchao Shao <shaozhengchao@huawei.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        bpf@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, jhs@mojatatu.com,
        jiri@resnulli.us, martin.lau@linux.dev, daniel@iogearbox.net,
        john.fastabend@gmail.com, ast@kernel.org, andrii@kernel.org,
        song@kernel.org, yhs@fb.com, kpsingh@kernel.org, sdf@google.com,
        haoluo@google.com, jolsa@kernel.org, weiyongjun1@huawei.com,
        yuehaibing@huawei.com
Subject: Re: [PATCH net-next,v2 01/22] net: sched: act: move global static
 variable net_id to tc_action_ops
Message-ID: <YxjQ0Pyz74xVLFBC@pop-os.localdomain>
References: <20220906121346.71578-1-shaozhengchao@huawei.com>
 <20220906121346.71578-2-shaozhengchao@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220906121346.71578-2-shaozhengchao@huawei.com>
Precedence: bulk

On Tue, Sep 06, 2022 at 08:13:25PM +0800, Zhengchao Shao wrote:
> diff --git a/include/net/act_api.h b/include/net/act_api.h
> index 9cf6870b526e..86253f8b69a3 100644
> --- a/include/net/act_api.h
> +++ b/include/net/act_api.h
> @@ -113,6 +113,7 @@ struct tc_action_ops {
>  	enum tca_id  id; /* identifier should match kind */
>  	size_t	size;
>  	struct module		*owner;
> +	unsigned int		net_id;
>  	int     (*act)(struct sk_buff *, const struct tc_action *,
>  		       struct tcf_result *); /* called under RCU BH lock*/
>  	int     (*dump)(struct sk_buff *, struct tc_action *, int, int);

This _might_ introduce some unnecessary hole in this struct, could you
check pahole output?

Thanks.