Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Sep 2022 19:06:32 +0100
From:   "Russell King (Oracle)" <linux@armlinux.org.uk>
To:     Sean Anderson <sean.anderson@seco.com>
Cc:     netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Alexandru Marginean <alexandru.marginean@nxp.com>,
        linux-kernel@vger.kernel.org,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next v5 5/8] net: phylink: Adjust link settings based
 on rate adaptation
Message-ID: <YxjdqMjtw8Rr9eKe@shell.armlinux.org.uk>
References: <20220906161852.1538270-1-sean.anderson@seco.com>
 <20220906161852.1538270-6-sean.anderson@seco.com>
 <YxhuMjZsBb7wCBFy@shell.armlinux.org.uk>
 <f2c15d18-23c0-463e-775e-f99e42cd4a69@seco.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f2c15d18-23c0-463e-775e-f99e42cd4a69@seco.com>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>
Precedence: bulk

On Wed, Sep 07, 2022 at 01:01:49PM -0400, Sean Anderson wrote:
> > >   	if (pl->pcs && pl->pcs->ops->pcs_link_up)
> > >   		pl->pcs->ops->pcs_link_up(pl->pcs, pl->cur_link_an_mode,
> > > -					 pl->cur_interface,
> > > -					 link_state.speed, link_state.duplex);
> > > +					  pl->cur_interface, speed, duplex);
> > 
> > It seems you have one extra unnecessary space here - not sure how
> > that occurred as it isn't in my original patch.
> > 
> 
> This corrects a spacing issue in the existing code.

Okay, I agree.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!