Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Subject: [PATCH v4 09/13] x86/resctrl: Add sysfs interface files to read/write
 event configuration
From:   Babu Moger <babu.moger@amd.com>
To:     <corbet@lwn.net>, <reinette.chatre@intel.com>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>, <babu.moger@amd.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>
Date:   Wed, 7 Sep 2022 13:01:02 -0500
Message-ID: <166257366204.1043018.4834615270384002210.stgit@bmoger-ubuntu>
In-Reply-To: <166257348081.1043018.11227924488792315932.stgit@bmoger-ubuntu>
References: <166257348081.1043018.11227924488792315932.stgit@bmoger-ubuntu>
User-Agent: StGit/1.1.dev103+g5369f4c
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 18:01:10.2723
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 954dced1-085e-4b9c-8de2-08da90faf20a
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT116.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4881
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Add two new sysfs files to read/write the event configuration if=0A=
the feature Bandwidth Monitoring Event Configuration (BMEC) is=0A=
supported. The file mbm_local_config is for the configuration=0A=
of the event mbm_local_bytes and the file mbm_total_config is=0A=
for the configuration of mbm_total_bytes.=0A=
=0A=
$ls /sys/fs/resctrl/mon_data/mon_L3_00/mbm_local*=0A=
/sys/fs/resctrl/mon_data/mon_L3_00/mbm_local_bytes=0A=
/sys/fs/resctrl/mon_data/mon_L3_00/mbm_local_config=0A=
=0A=
$ls /sys/fs/resctrl/mon_data/mon_L3_00/mbm_total*=0A=
/sys/fs/resctrl/mon_data/mon_L3_00/mbm_total_bytes=0A=
/sys/fs/resctrl/mon_data/mon_L3_00/mbm_total_config=0A=
=0A=
Signed-off-by: Babu Moger <babu.moger@amd.com>=0A=
---=0A=
 arch/x86/kernel/cpu/resctrl/rdtgroup.c |   40 ++++++++++++++++++++++++----=
----=0A=
 1 file changed, 30 insertions(+), 10 deletions(-)=0A=
=0A=
diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/r=
esctrl/rdtgroup.c=0A=
index f55a693fa958..da11fdad204d 100644=0A=
--- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c=0A=
+++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c=0A=
@@ -254,6 +254,10 @@ static const struct kernfs_ops kf_mondata_ops =3D {=0A=
 	.seq_show		=3D rdtgroup_mondata_show,=0A=
 };=0A=
 =0A=
+static const struct kernfs_ops kf_mondata_config_ops =3D {=0A=
+	.atomic_write_len       =3D PAGE_SIZE,=0A=
+};=0A=
+=0A=
 static bool is_cpu_list(struct kernfs_open_file *of)=0A=
 {=0A=
 	struct rftype *rft =3D of->kn->priv;=0A=
@@ -2478,24 +2482,40 @@ static struct file_system_type rdt_fs_type =3D {=0A=
 	.kill_sb		=3D rdt_kill_sb,=0A=
 };=0A=
 =0A=
-static int mon_addfile(struct kernfs_node *parent_kn, const char *name,=0A=
+static int mon_addfile(struct kernfs_node *parent_kn, struct mon_evt *mevt=
,=0A=
 		       void *priv)=0A=
 {=0A=
-	struct kernfs_node *kn;=0A=
+	struct kernfs_node *kn_evt, *kn_evt_config;=0A=
 	int ret =3D 0;=0A=
 =0A=
-	kn =3D __kernfs_create_file(parent_kn, name, 0444,=0A=
-				  GLOBAL_ROOT_UID, GLOBAL_ROOT_GID, 0,=0A=
-				  &kf_mondata_ops, priv, NULL, NULL);=0A=
-	if (IS_ERR(kn))=0A=
-		return PTR_ERR(kn);=0A=
+	kn_evt =3D __kernfs_create_file(parent_kn, mevt->name, 0444,=0A=
+			GLOBAL_ROOT_UID, GLOBAL_ROOT_GID, 0,=0A=
+			&kf_mondata_ops, priv, NULL, NULL);=0A=
+	if (IS_ERR(kn_evt))=0A=
+		return PTR_ERR(kn_evt);=0A=
 =0A=
-	ret =3D rdtgroup_kn_set_ugid(kn);=0A=
+	ret =3D rdtgroup_kn_set_ugid(kn_evt);=0A=
 	if (ret) {=0A=
-		kernfs_remove(kn);=0A=
+		kernfs_remove(kn_evt);=0A=
 		return ret;=0A=
 	}=0A=
 =0A=
+	if (mevt->configurable) {=0A=
+		kn_evt_config =3D __kernfs_create_file(parent_kn,=0A=
+				mevt->config_name, 0644,=0A=
+				GLOBAL_ROOT_UID, GLOBAL_ROOT_GID, 0,=0A=
+				&kf_mondata_config_ops, priv, NULL, NULL);=0A=
+		if (IS_ERR(kn_evt_config))=0A=
+			return PTR_ERR(kn_evt_config);=0A=
+=0A=
+		ret =3D rdtgroup_kn_set_ugid(kn_evt_config);=0A=
+		if (ret) {=0A=
+			kernfs_remove(kn_evt_config);=0A=
+			kernfs_remove(kn_evt);=0A=
+			return ret;=0A=
+		}=0A=
+	}=0A=
+=0A=
 	return ret;=0A=
 }=0A=
 =0A=
@@ -2550,7 +2570,7 @@ static int mkdir_mondata_subdir(struct kernfs_node *p=
arent_kn,=0A=
 	priv.u.domid =3D d->id;=0A=
 	list_for_each_entry(mevt, &r->evt_list, list) {=0A=
 		priv.u.evtid =3D mevt->evtid;=0A=
-		ret =3D mon_addfile(kn, mevt->name, priv.priv);=0A=
+		ret =3D mon_addfile(kn, mevt, priv.priv);=0A=
 		if (ret)=0A=
 			goto out_destroy;=0A=
 =0A=
=0A=