Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5e127663-c7e9-a491-3d3b-b057c50eb25a@intel.com>
Date:   Wed, 7 Sep 2022 11:58:07 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [Intel-gfx] [PATCH v8 02/16] mei: add kdoc for struct
 mei_aux_device
Content-Language: en-US
To:     Tomas Winkler <tomas.winkler@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     <intel-gfx@lists.freedesktop.org>,
        Alexander Usyskin <alexander.usyskin@intel.com>,
        <linux-kernel@vger.kernel.org>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>
References: <20220907155813.1427526-1-tomas.winkler@intel.com>
 <20220907155813.1427526-3-tomas.winkler@intel.com>
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
In-Reply-To: <20220907155813.1427526-3-tomas.winkler@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V016a2pibzJJSUJGay9rdUVJbFBMMjUzVFVmaVlzejJXTUc3blpKeGJZRjBV?=
 =?utf-8?B?cGgzQUdmUW1BOE5iaGpseGpkODlicklWT1cwQ2JMSEFvSEpxOElkN2F4VEFj?=
 =?utf-8?B?eEkxWTAwSFJVRXZTek01aSsra3VEWUtKdVpPUGZSK0lnTTFBVFJkdXA0OE0x?=
 =?utf-8?B?MHFMTVliZytTb3hBUm1FbitBa3BzRmNQY2pRWnBSTEdpWWZZeGUvd0lBMnhB?=
 =?utf-8?B?c2RBdlA5VFRXVUQxTit5cWNhMWJTUERieEY2SHR2OHcyc1dneGEyUUlKam9n?=
 =?utf-8?B?dWJaQ3VENWZ0MDVMRHZCdmpRTHVpOXdiQ3pXQi81Q2gwQkRDUDB2QllkdFVy?=
 =?utf-8?B?Z1ZWclM1Z3ZyOW5WNWJacCtCOS9PMEt5cEhxaVVrOWprMHJ2TnF5dmgrNlY1?=
 =?utf-8?B?Mm5ZbXJRQUhRdGo2eHd0Yjg2Z0tKYW93RlNJK1RRam1hTjk5d0QyMzNVTlVN?=
 =?utf-8?B?ckozZ01FOWFtcVlHaENrUUNTM3REMU1kVnpKR0xaK0c2TE43bHV0OVdJSmdP?=
 =?utf-8?B?QmdXU2VCOGZhT3FKRWYwYXdwZ0NkK3dHcWc4eCszQ29zNnlMQlU2VDJ4M0px?=
 =?utf-8?B?Rm9XS3hpc2h1VVplWTRZQVlBWnpTYndXWXpwRnlkdG82S1JiQ0pSczJsWFhM?=
 =?utf-8?B?dUpucWdJZlFhbTBTd3Z5NnN2djhkckNqMmNBVlM0M05oQ2Z6L2ozL28yVUVx?=
 =?utf-8?B?K3BUWHRmRURpQVU1ZFRzTWhJeUhZWWRtNDVkeEhISC9hTFlKWEg2OU53UUNr?=
 =?utf-8?B?RTNja05qRlVwU0NyV2tZTFBCOXJkekVsWVlQL2JWM2tFeExJOUxXYWVWK3p5?=
 =?utf-8?B?SVpDSWtpQUpBdFJ2S0RBMkNtajZJQ0tCSmtsUFAya2Zhd3lXK3B2Zi9BWFY5?=
 =?utf-8?B?RG5VSHBnUW1mdlJzV2hEOHB5eWhCSEhJcm5iSWVXWWM1OGFldjBPVDFTYkZW?=
 =?utf-8?B?Q0FNajBFWHd1Tm1ybzNWZUdhb3ZFQkhVV2hZaGZIN0hvbVBtemNrTS9KMlhs?=
 =?utf-8?B?TmxlL1NLVHo5STdjOWFQRFFuUDRFbmxSQ09NR29malBYYnQrZWMvblFHaUJE?=
 =?utf-8?B?VlhlcDFPNmNTT1pqQytSZVh4MmpGQjlCSGFZbTc5b1kxUWlLek95RER2UEN0?=
 =?utf-8?B?eDZlKzRGeEgwQXc3dmJTTmJ3WE4wSTZpTnZIRStTNFNpZktVaXdDT3ZUelRl?=
 =?utf-8?B?THpKT204bERHZE5iMXAzeW5RTTJCWC9Sa1NCTWJyWU0xUWRJeU1pRHhmU3B0?=
 =?utf-8?B?RzNFdEE0S3EyMFloWG5TcnlOMGFqb1FFUkVIMm9IL0VPSU52elF4MHpHV3RF?=
 =?utf-8?B?d3F5b1F5Wkg1VVcyRzVmcE95QnJKMnZjVlF1NXZucGxOL0orMzZWZStiWFdE?=
 =?utf-8?B?Vlp5NWJqd2YydFZRZEVlTXFvc0V5Tzdja0V2Y2U5SXJTVis3bGpJMVRja2hS?=
 =?utf-8?B?UnNOSDQ1RlY5MW1FQ2I4cFliTThjOCsyMFN4aXhRYmtDOHVMYk9jTVFMQ0lx?=
 =?utf-8?B?bkM1Uit4WUJOQjI2N0ZaclVLUVpFQlRERmdsc2piSUZCOVh2TFBhbWQ0Mktx?=
 =?utf-8?B?ZmoremZDR1dWTWtJQWo5cHZ0YVdLRXEvdVVVK0doU2J1bWlabEtoVmJrQlRN?=
 =?utf-8?B?V3p1MmdVeXJTSmRvcXZFOXY1bmFWdVJBd0ZvOUwvQzl3am9VTUtVR29TaFBG?=
 =?utf-8?B?QmR5cWhqV2l1eWZYVWRjTkYxVjJTN0ljOGxGRHYraUlieU5zSXBIWlBiTXZZ?=
 =?utf-8?B?Nm9sK00zT3lqSzJpTVEvOXQwQmhiZG80L2l3MjluZWVjeW8zaFRjNDlKL3lm?=
 =?utf-8?B?UFpZc0djMjBPNFlaWXlQN0ZzMkFZTTMvTmZ2SlJaTVcrVkdMR25pZVRQY1Vp?=
 =?utf-8?B?NVJZVXhhMGp4TGxqcXBtR3Y5bVBmVDlDcUN3bytBVTlGTWlOZm10YVRieUhY?=
 =?utf-8?B?L0dUUzhSTDlnYWlwU2t3RVBDQjlzak1rTXEwZ2VlTGVkNXk4WmtVOUFXMEdt?=
 =?utf-8?B?eDZoWWs0cFFtdkVRaERjY1N4Z1lwdjNOSHJMOG50dHFESzNKN0c0a3ZzY1I5?=
 =?utf-8?B?cXZtRmN1MW1OYmVta2tVUUluVThJbkJ4YjdvRGd2NG9Pci9kUk5NUk5IUkJB?=
 =?utf-8?B?SlNidkkvR0hUVGpCZ2VpdjdMclY3THNscERlbGMxMGV5TS9XTGpWd1AzUmls?=
 =?utf-8?Q?aFGEhNHxaPqZ/SVVIrGq77I=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f0eb6dbf-52e7-4d80-a1fc-08da9102e824
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5488.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 18:58:09.8117
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jt0pZcBMhChMkpypciY5Ck+SD5HsLoAfGudEtLhus+yaGKYmuiO1qej/OOosjsAslaqR4R7uuT4opshiuf7id0t53XZKJ/ty5FWvtjRj2s8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB2023
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/7/2022 8:57 AM, Tomas Winkler wrote:
> struct mei_aux_device is an interface structure
> requires proper documenation.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

This is unchanged from the previously reviewed rev, so this still applies:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   include/linux/mei_aux.h | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/mei_aux.h b/include/linux/mei_aux.h
> index 587f25128848..a0cb587006d5 100644
> --- a/include/linux/mei_aux.h
> +++ b/include/linux/mei_aux.h
> @@ -7,6 +7,12 @@
>   
>   #include <linux/auxiliary_bus.h>
>   
> +/**
> + * struct mei_aux_device - mei auxiliary device
> + * @aux_dev: - auxiliary device object
> + * @irq: interrupt driving the mei auxiliary device
> + * @bar: mmio resource bar reserved to mei auxiliary device
> + */
>   struct mei_aux_device {
>   	struct auxiliary_device aux_dev;
>   	int irq;