Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cf73d4ca-4e19-aaff-8b45-ccd32f95a496@intel.com>
Date:   Wed, 7 Sep 2022 12:06:30 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [Intel-gfx] [PATCH v8 07/16] mei: gsc: wait for reset thread on
 stop
Content-Language: en-US
To:     Tomas Winkler <tomas.winkler@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     <intel-gfx@lists.freedesktop.org>,
        Alexander Usyskin <alexander.usyskin@intel.com>,
        <linux-kernel@vger.kernel.org>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>
References: <20220907155813.1427526-1-tomas.winkler@intel.com>
 <20220907155813.1427526-8-tomas.winkler@intel.com>
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
In-Reply-To: <20220907155813.1427526-8-tomas.winkler@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TkhNU0liZ0dsdXUxekhCYzRnMG5nUGxsMVhmS05RK1puTkhTMEI0TUJaMjBK?=
 =?utf-8?B?WGgzRFd2dFJhMmJDeXdmTElsVzZ5RitOSDRYaWUzcWIwNk5nalFIa1lFR1lz?=
 =?utf-8?B?aHIwUGZXaFplMStHdXZUSEhqd2F3c0dWMEM3ZjZxMWZNUEV1YlRBSnY1M3Fn?=
 =?utf-8?B?eW95cEJFWXhuOHJpWFE5alMzNGdibmVxTVNtMi9GU1VBRmFlUi9JcGhVRFZ6?=
 =?utf-8?B?dFNxN2orUGNHY3JHOXlMUXA4OFRVVTVkbkRHQkZZaTR4OEdwejJLRzlSbVk2?=
 =?utf-8?B?TGI3ZVowVjRxcUxkNlVxNi9tVzZkRFU5N3JIVEZCYmZ6N3prVnNyMFYzZGw3?=
 =?utf-8?B?V3RMYmdidEp1R0hNaHRUcEpoSmVEL05CR2pLcHlyUmJDN1haM2MrcDNHQXo5?=
 =?utf-8?B?czhsWGNrTW5FcWwwdk5HSklFdkludlVKaUxpMmRPZTA2RWVpVXhNVDI1UG1p?=
 =?utf-8?B?cHp2Q1N5NnBwVnloc0VCMFhSRmljd3RkRlp5MVdIMlFpWThzN1d3RGxKRGZo?=
 =?utf-8?B?c3B1KzlnTjlDSmcvWGk5NDB5UFVQRlVIUnJwQ1Q3Y2UxNTlVK0xHc0tKSjB2?=
 =?utf-8?B?dXZDWmM3QXhiTE84WTRSNHFHQTNTODlTclFnM3MzOVFRZ3NYSU9aTzZqUHF5?=
 =?utf-8?B?QnE2UXJJMU85akxRTDJlWnpOV1h6M1dtc3lIWSt0NDlFSExzaFY4ODFUUHpa?=
 =?utf-8?B?SnFaWTRnR1ZybzRjR3REaGRWK2VESzNpU0xtckxaK2dWL0wvSDcrb2JqYUR4?=
 =?utf-8?B?YVhickxmTWloUThrU0RRUGo2T2J4VHRDTXpzWXliclI2QS9KWFZDK0ZmdmlE?=
 =?utf-8?B?bkFNWTBacWxNQVZVdm1FM252VDZkVDJkY09GUUQrazR6ZjZndmVsdXV1MGd6?=
 =?utf-8?B?ZUNHTjEwaXdlZWI0VTlzWUZDbTh5ZzdJdllTSEMreFBOSllPOGNWOEVKNXRO?=
 =?utf-8?B?bklBNWNZNnRjT3hHU1JnWjF0WHlpVTZlZjdVQ1drT0ZxeURoYjl5KzVWT2hn?=
 =?utf-8?B?TnhuOGRnNHdRZENoSGhMNXJOeFY5OGtoQ0dEcnZFVVhZbmhac0c1eno5YTQ3?=
 =?utf-8?B?RmhRNDZFMmVncHFJSXAzRi9xbGNzdmtFVkNzb2Iwb3ZVR0xyOHNURDQwV0c5?=
 =?utf-8?B?WWxHemhZQjRXOUVDQnNDK0ljZWs0MEx0aThwRXZCZ3ZGdXhOTGdiS3JQSmIx?=
 =?utf-8?B?U0YzSS90ZTBSSng0UkZOS3EyeW9sR09qTm5JVExpUjIzOEhaRkdmRjZFaGpm?=
 =?utf-8?B?aWQ4c2NVYUg0eE4vc2pyZ3JuUGhxNkFRUUU1Mm4yVGRRamJoRzFsU0hlQ2NQ?=
 =?utf-8?B?WmlwL09URzl3UnQ1VjVhSDU1czU2M2dwOXJsMTFFbUhOV3VjcmNYNC8xQUl0?=
 =?utf-8?B?SkdsYytvaERzZkNUWGVvYmlFOFNsZlByMlp0YmxRR0QwQ2svZW80WEYzc1lI?=
 =?utf-8?B?RWw4cnIwOUxiOGhBamVuck9VMzc0VG50T3U0dko3Ukg0bEhGdDdBcm45S2ls?=
 =?utf-8?B?cmZNSVZnenZLTU5IWHhab1p6TFRCMzdBdm4xeW9xTWxhbjZPSXlqUnFlaFpM?=
 =?utf-8?B?OGVKZzc1QmxhcnIrVjE0TlllTnJ5VTJmcjRqRmJrWE04RUF1TDRYMVV3VHdK?=
 =?utf-8?B?dGx2OVRkY2dhSzlQZFRFdFdYYVAwTTh3OEtNbGQvUDFqeTFzZFhKbU5zSkYv?=
 =?utf-8?B?VFVGQlloYWkyamlYUHNPSnFWTXY5VzEyL2dvaUFQandQUjFxOFFiRHpVN01h?=
 =?utf-8?B?N2ZzRERtMGdmdWNFTFA1dnlyd2VIRWV3eUl5UUFvZzQ3dnlrcUU5dXoxUHF0?=
 =?utf-8?B?MDlCSG9JWEI0U25GS2ExR3dCU05EcDVaZVlmY25tdmtndkNtVTRBcTlTNzBz?=
 =?utf-8?B?VjVqOWd0QUNjQ0sycXE5TVJ4SnIyOG9sVW8zb0JTM2diWjZYZzF2cUREMzND?=
 =?utf-8?B?bG1Od3FOWGJXNUFuam9PaTRkUW1NNkRzR0REL3haZWpUSWtldTI3SnA2cDFw?=
 =?utf-8?B?SEtEV3dEdnJ5RHBQdnRPNXFtNWRvRHZXTG9PcXNXQmlzSnFETnNtTVVjTVBp?=
 =?utf-8?B?TnhxL01FN1JYVEhZRFkrbE9LUE5lSGZkbkM2N2I2OGJIbUdKYUVwNEpNZzhj?=
 =?utf-8?B?R29IV1FvN0dyU1ozeGxGcDFzS2kxYmFDdnE0amwxcFQ5dmhlSDlWZGxqNnNh?=
 =?utf-8?Q?3QJhFzkmP7LnGko0rqMXcBg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0aeef8fc-c152-47e3-b7d2-08da91041469
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5488.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 19:06:33.5965
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BePYizhbEmqV0NzA4Yx+62XpgDnLgEWvNuPEEjgabfsfm2dDb5Rodwg5VLIMBfFMIVUpHmU47LM4MuzOgylmwGFme6vBe1ZGA9l5Lua2CDg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1832
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/7/2022 8:58 AM, Tomas Winkler wrote:
> From: Alexander Usyskin <alexander.usyskin@intel.com>
>
> Wait for reset work to complete before initiating
> stop reset flow sequence.
>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

This is unchanged from the previously reviewed rev (apart from the fixed 
date in the header), so this still applies:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/misc/mei/init.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/mei/init.c b/drivers/misc/mei/init.c
> index eb052005ca86..bc054baf496c 100644
> --- a/drivers/misc/mei/init.c
> +++ b/drivers/misc/mei/init.c
> @@ -1,6 +1,6 @@
>   // SPDX-License-Identifier: GPL-2.0
>   /*
> - * Copyright (c) 2012-2019, Intel Corporation. All rights reserved.
> + * Copyright (c) 2012-2022, Intel Corporation. All rights reserved.
>    * Intel Management Engine Interface (Intel MEI) Linux driver
>    */
>   
> @@ -320,6 +320,8 @@ void mei_stop(struct mei_device *dev)
>   
>   	mei_clear_interrupts(dev);
>   	mei_synchronize_irq(dev);
> +	/* to catch HW-initiated reset */
> +	mei_cancel_work(dev);
>   
>   	mutex_lock(&dev->device_lock);
>