Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8fdb493f-6227-b75c-5251-e9afaada42a6@intel.com>
Date:   Wed, 7 Sep 2022 12:02:19 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [Intel-gfx] [PATCH v8 05/16] drm/i915/gsc: add GSC XeHP SDV
 platform definition
Content-Language: en-US
To:     Tomas Winkler <tomas.winkler@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     <intel-gfx@lists.freedesktop.org>,
        Alexander Usyskin <alexander.usyskin@intel.com>,
        <linux-kernel@vger.kernel.org>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>
References: <20220907155813.1427526-1-tomas.winkler@intel.com>
 <20220907155813.1427526-6-tomas.winkler@intel.com>
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
In-Reply-To: <20220907155813.1427526-6-tomas.winkler@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1VQc2dEU3RRZHZpc3EwekZYZjdOeGVscTNaMU5EbnU3TUp6UVNQb3V0RlpP?=
 =?utf-8?B?SVRBNDJROUJyRnFINWFaZktaeEN2d0phVVd3ekh2SnNtRVhYaTB4NVMwQWxX?=
 =?utf-8?B?TWhLMkp4cjIzWVg5Q1ZzVFJpR01PaisxSjdSMGExb1JwczdCNU14Z21kczd5?=
 =?utf-8?B?KzJhRkJEOERCU1RGaTk3WmpCTDNMc2J0cVpMbnpHSVRpa1ZVZ25YYWNRZUph?=
 =?utf-8?B?ZTQ5RC9QWGdjZXgwNWNxQ3MweEN3Q1F4MFhVcXd1THBkM1RuUEhESTdNS3BB?=
 =?utf-8?B?N0x0YUtZUmRVOHZaL1FTeDZiTEwwMmhRa0cwQ0ZweVMxUHhGU2Ewc0hHcWdz?=
 =?utf-8?B?a1FkWjNlcXduazArMmtHcHJHNVRvRUhqa1ZTekZ1QWFtWW94VlI2SUxLaFNv?=
 =?utf-8?B?emZ5M2syaTVEaktRS1p4SjF2NEtzN0ZidmlyUnRnQytPM0ExTWg3QkpEM1Ez?=
 =?utf-8?B?bEg1SndUNjM3TE0yMmU0aStKZUxuN2NqTzVQamV3Tm1iY1dLUnJlV0RVL21M?=
 =?utf-8?B?czhNcTd5cDBsUnZRcWhnVlpJNzd3UkhQZXhqZktsN1AxaWZrV3RrampEbnVv?=
 =?utf-8?B?YllVaHE0ZVYrQWRIMzNxZUxwRWpQdnJUV0ttbVNxVDNRcFpkQU13NEVlcFVU?=
 =?utf-8?B?bmZKeHIvdCtXVWx6N2JZOEI0enNKbGxnYW9Ha29nV1dETmJPZzUyUER2aHN4?=
 =?utf-8?B?VC81cWVWR09VOFd5M0h5QmxTc3JRelMxTmNQTXh5VFk1bGF1a0VzZXVmUWgz?=
 =?utf-8?B?aDBaS2RvOXpzUkxNeXpabEhpR2hQeHE2VFRPS0xHWW1pNVcvT3pOaVI0Q1hj?=
 =?utf-8?B?UHJQNkxRbW5iN1d6NTJqOUdaNTBQa0tFdDhDZGxVd1Rva1pZUWFvbi9ZV3By?=
 =?utf-8?B?OHUxZ09zUmRGdGh3REhYQmcyZCtST2xyTWpMRjI0Qng2b1NndXpqbEZ2Lzc0?=
 =?utf-8?B?a3VZQW5pSnR0L2YycjZJSk85Z05EYWdnMHQvR1p0eXBDa2VPT0NZcmdMcy9U?=
 =?utf-8?B?N3lxRC9wcXNsbDV5a3ZKWkVkQmxZYnFQUXVjdGFGUDRoUjBDbzdBb1pWQUt6?=
 =?utf-8?B?STFvbEFxcHBRZGJUZVd0WFp5KzhzYzBPMGZSSjVsMWRrV3JNdFRZK1d4RG9Z?=
 =?utf-8?B?QkVIQ2pOMWljaWdaQmtZYURZNWp5dWhvNHU5ZFp0VHJVZ0U0S2hVcnkrbUNi?=
 =?utf-8?B?c2NqcXd6NExHR25wa2ErSy92aUxMTU1MTWtlN1hpTThWSjN0SCtTcEREV3Iv?=
 =?utf-8?B?WmlRdlU2aURISks1YjJpT2piN012YjNDK3NJKzJTKzNHUEJVOWpZOE5LR1U0?=
 =?utf-8?B?cXY4TjR1U2J3T1o5QVova1R1OEl5ek5TS0V1WjRHaUZjMnNnbXE3WVZtcjA0?=
 =?utf-8?B?ak9sTWZIVmppcjNwVk96djBzZi8xUTZ1WnZGL0NaVmN2RWRSOW1WZEIyRUxS?=
 =?utf-8?B?OGErQmk1RmVVWHgwN1RPRVNXRjhhQlpVTWZURDlEbHQxYXpGbnFGc0p6YU90?=
 =?utf-8?B?NWZuQ0xLeTVDQWxUb3pteVZ2Zmt2OEQvMTdjcnNZYjRUc0cyekNZU3pOTXpD?=
 =?utf-8?B?UXp6cDF1WHlkT2FEWmRDYnZzRWx3dVplazFmd2xvb0NGQy9jQmd4ZjlSMFFT?=
 =?utf-8?B?YTczSXEwcEFYakxKR2NZdFFKM1lMU0VoeWFkNTN5Y1FVREp1UFlTOWloeS9C?=
 =?utf-8?B?VURDOWpoU05aQkxBYlVPZFcreDRXNHpDNHYzVDJUamNyZHlnUUczRm02Q3VV?=
 =?utf-8?B?TForWGFPaGNTcU9UQnVWejBKamZmQW1YT1F0YzZzMmJZaDNtL2hXQThtRUdQ?=
 =?utf-8?B?QkJKdkRKR2V0OWFCeVVuaEplaUNNK29rMnVSUXN6QUZKdXcvY2tLRnFHMXEv?=
 =?utf-8?B?R2VmMERBSGYza0FGd0xDdERNbVBsU2ppK0tBQjd1UVB1NkxoNUFJMjRHNk5L?=
 =?utf-8?B?Q2c4bzVpTlE4MVc0WFVTem5EdGRKNnlmVThhVXJGeVF0SDgwbTAweEs5TktG?=
 =?utf-8?B?WWNzT3c2SDBydmMxTkh1VU9uUEZhdy9Bbm5TeS9xYXVBcFdDK21kUzBLeG9H?=
 =?utf-8?B?M25CRGxKdHlFOUJUODR1WitaQTk4NlMyOUlGb1c0NTVWczIzUmxuVFAvWFph?=
 =?utf-8?B?MGNvSk1BWHVHemsvRTBIYlplMmhMSkFsWDFMR0tuUThoR0gwWFNrMjloVXll?=
 =?utf-8?Q?s5oVNRdJXPFjuC6TQWh5UrA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b3c0ecd5-08ca-4594-a607-08da91037f01
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5488.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 19:02:23.7776
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jOVdByBRUr5l8wKJsaAEnfEm9MSTTm4wxtiH+QHrRk/0SeOkMBMxa+twlX8pPhPVfYxnwyJZQoOlJOU5k3R+S7PQaVXWPGcMIQjXk/mn2h4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5105
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/7/2022 8:58 AM, Tomas Winkler wrote:
> From: Alexander Usyskin <alexander.usyskin@intel.com>
>
> Define GSC on XeHP SDV (Intel(R) dGPU without display)
>
> XeHP SDV uses the same hardware settings as DG1, but uses polling
> instead of interrupts and runs the firmware in slow pace due to
> hardware limitations.
>
> Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>

This is unchanged from the previously reviewed rev, so this still applies:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/gpu/drm/i915/gt/intel_gsc.c | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gsc.c b/drivers/gpu/drm/i915/gt/intel_gsc.c
> index 73498c2574c8..e1040c8f2fd3 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gsc.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gsc.c
> @@ -56,6 +56,19 @@ static const struct gsc_def gsc_def_dg1[] = {
>   	}
>   };
>   
> +static const struct gsc_def gsc_def_xehpsdv[] = {
> +	{
> +		/* HECI1 not enabled on the device. */
> +	},
> +	{
> +		.name = "mei-gscfi",
> +		.bar = DG1_GSC_HECI2_BASE,
> +		.bar_size = GSC_BAR_LENGTH,
> +		.use_polling = true,
> +		.slow_firmware = true,
> +	}
> +};
> +
>   static const struct gsc_def gsc_def_dg2[] = {
>   	{
>   		.name = "mei-gsc",
> @@ -107,6 +120,8 @@ static void gsc_init_one(struct drm_i915_private *i915,
>   
>   	if (IS_DG1(i915)) {
>   		def = &gsc_def_dg1[intf_id];
> +	} else if (IS_XEHPSDV(i915)) {
> +		def = &gsc_def_xehpsdv[intf_id];
>   	} else if (IS_DG2(i915)) {
>   		def = &gsc_def_dg2[intf_id];
>   	} else {