Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <67cf39d3-a36c-d495-c788-42734a2b1d14@intel.com>
Date:   Wed, 7 Sep 2022 12:23:42 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v8 12/16] mei: gsc: add transition to PXP mode in resume
 flow
Content-Language: en-US
To:     Tomas Winkler <tomas.winkler@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        "Alexander Usyskin" <alexander.usyskin@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>
References: <20220907155813.1427526-1-tomas.winkler@intel.com>
 <20220907155813.1427526-13-tomas.winkler@intel.com>
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
In-Reply-To: <20220907155813.1427526-13-tomas.winkler@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUFTdGU4dFV5NlRwUjRpVXFJZ1hkb25LVkJWdlRsT1R3QTVOK3FIWGhld2lF?=
 =?utf-8?B?enJnWmNPeU53V2FVM3RJdU81K2RkMCs3d0ptdVJkTlM3ejZuWVdWL2NqQmRJ?=
 =?utf-8?B?K0RoeFhuNTNXMWpKN005SzlpcDBRS1RYK0lnK2xnaWlFNVNHdHdDSFRsMDVO?=
 =?utf-8?B?Q3FCMnozaEFraGRITUpUNjlMQTNhTTRyMzQrN1RYbUxta01NekZ2bzljUm92?=
 =?utf-8?B?ZncyTFIvY1p6TmxHemFwaDZMV3pZd1ZrVmh2QzN5cFpQbUJEZCtqM2h4blcy?=
 =?utf-8?B?SC9lOEdpcGs0YzE0bzRFc09xWVc2UzZGTW1JeGh3WlVwaHFjcUxjL25xdTNP?=
 =?utf-8?B?Mmh3RHcyK0RUUmVRYys1TGxaa0pBbkVyQzdsMUVMeWY5UFNWbi9xVVlZOUI2?=
 =?utf-8?B?V1JjTEJuSEhKV09BdkZaQVdYQTRoZlNhK3Z0U2JLc0RJZVM3SnlKNU5vS1pr?=
 =?utf-8?B?UGplMUYrYTJjRTgyeVRwSlkwTGwxK25WSVlUZ3VteGk1dnZ4WldWaVJiVEFx?=
 =?utf-8?B?Rlk3YVJOK3RsUmNVSExrSTB6YzVia3N1NG9TUkYwSmNRVlAreHRaTEE0Z2Nl?=
 =?utf-8?B?cXJISS81VlFWanQ5WVNKSWZrVEZoUXZhckVmWjdGb3ZETFU4UGJRRHJiY2hq?=
 =?utf-8?B?VlFDbzE3TG45a3NvM25ycXY0WXZ6cjhDSWhMYzFPWHpjWi9EUXBDbmNDRlZF?=
 =?utf-8?B?V1BMSmFtRnVjRGF3NEhmR2NrMUZvbkJkdVE2RjlENit4SnlKcUttbjFkK3o5?=
 =?utf-8?B?TUU0MjVpb25VempmMDFkK3I5TEpmT1d3NGhVZDV5cktxQlZtanBjL09OdHlZ?=
 =?utf-8?B?eEpudU4vWWExNXVFUHpUdTVNTHdxSTZzeXdqTVFYNmh3QXJIblRITXQvVTdS?=
 =?utf-8?B?TEdhYjlHRlV3OGtXcGZMajA1OGdVdlhtbXlqTGNDQitISkZxSG1sU202NzZ0?=
 =?utf-8?B?dktTSy9ldTc2VVZoQkRUUFowSFpBSFdBb3cvRzdlR1FvU2dyeGFoNUZBWHJZ?=
 =?utf-8?B?bHhKSzhJcS9qRTZBRGNBY2JYY3Vsak9VSTd0S2RVWDdzZWVxcjlyM3RBVFox?=
 =?utf-8?B?NjhGeURTcmRGYnBFYjhPNjZSK1lEeWRQeVorUmRFV0xnNncyeW52a1VJeEtG?=
 =?utf-8?B?Qnd3NVUySHZHTlA0WEtSUzJGZW5MVHNHMHorT29xQ2JjakkyL205bHUya3dn?=
 =?utf-8?B?YXEzUnlDMVVqY0NZTGhXNHhONnpYYWt3RnVRWXFyT05FcjZSbW9xZkQwak5v?=
 =?utf-8?B?WXlRUmc1Y0Ixbk1oREF2RmU4SmQrdVlVS0dhRE5iL1IvUHNIV1psbjVaNmxJ?=
 =?utf-8?B?M2pTSGpEVkVFNE1zYU9JWGpqTlNWbG5WcUljWWNxYUlQZzVNZGx4bktFMXFs?=
 =?utf-8?B?RXJxTE5YN2RteXYvdHptbS9nMWtOd1UxWk4vUThrTGtWTHJvZTlENGF2aTVv?=
 =?utf-8?B?TzBFejV1ZkhMRGpMWHIycDNLdWk1b1JoN1hzT2ZYQ1FLWjEyYnNRQjVWbDMy?=
 =?utf-8?B?ajdpdUtjQXJRQXFNNVRiMTRZOXZwR2h6SW9ERFpFcC92MHNqVUMzNkhEZjE3?=
 =?utf-8?B?MVo2ekNURmwwQkRhaFpxak9DSUhiT1lGd3JNYUJuMkxQSTV3WFAzaXh2VVMx?=
 =?utf-8?B?RnppTTE1d3BlTG9BWVkzeWo3UkZGRHF1ekxWWkVsRTNta1dDb0RCOUhMRHZY?=
 =?utf-8?B?MnpvTEFKSE9KbmluYnk1QitaZ0tBRnhKdWtGeXNPS0hUanNJazczeENhdHVl?=
 =?utf-8?B?U1ZPaFE0ekpQbm5mUjN1NWM3WWVNbUMvVndPNVpQZjZaYWkzczBVdE5LRDZM?=
 =?utf-8?B?NnJ6WWNWUjVzaHhkTlhCSUs5VmRxK2dvbjU2YTV1aGxxbFVZWGdHWWMyK3pZ?=
 =?utf-8?B?ZU1YK0h0WElacW1JRmJTeXBoYUxrY29VWExWc1hUcVBhOGZGWmFLVnRFNTJy?=
 =?utf-8?B?VFp6VU5uQ2UyWGpYb0EydmloZnR0MGo0Y2tLTEJmUGZhU3VUdVVLYWJ0OGpk?=
 =?utf-8?B?cmNrU2d0Q0kvbjV2U2ZONjcwWXkzY3EzdnRabkFQSHlsV2lqdkVFVEJldlJK?=
 =?utf-8?B?U3FkTUJUK3V1WDhJYWN5WW0rOFFrNGwzUTFycEh2SDNtd2wwNERhKzVZUDBz?=
 =?utf-8?B?b3J0SFAyWm03SHp0c1NkWWgrZzFtRkYxdE8wSUFIRHhsa3R3UHJESU42bkJ0?=
 =?utf-8?Q?IgEVBKXfa/vXlP9X46rQfDc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c8502b3-dec4-43a9-ed12-08da91067b1a
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5488.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 19:23:44.9258
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7A8wcb/m/di4MQnPodTr30ynt50+uKZMbC3zEcACd3nlWA68KXJ42GhDahaYVHrpmeYh2/y3rNysAUFYCmm9t5gSV5P40J3wIaknkn4iORM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2560
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/7/2022 8:58 AM, Tomas Winkler wrote:
> From: Vitaly Lubart <vitaly.lubart@intel.com>
>
> Added transition to PXP mode in resume flow.
>
> CC: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>

This is unchanged from the previously reviewed rev, so this still applies:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/misc/mei/gsc-me.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/drivers/misc/mei/gsc-me.c b/drivers/misc/mei/gsc-me.c
> index 6b22726aed55..75765e4df4ed 100644
> --- a/drivers/misc/mei/gsc-me.c
> +++ b/drivers/misc/mei/gsc-me.c
> @@ -182,11 +182,22 @@ static int __maybe_unused mei_gsc_pm_suspend(struct device *device)
>   static int __maybe_unused mei_gsc_pm_resume(struct device *device)
>   {
>   	struct mei_device *dev = dev_get_drvdata(device);
> +	struct auxiliary_device *aux_dev;
> +	struct mei_aux_device *adev;
>   	int err;
> +	struct mei_me_hw *hw;
>   
>   	if (!dev)
>   		return -ENODEV;
>   
> +	hw = to_me_hw(dev);
> +	aux_dev = to_auxiliary_dev(device);
> +	adev = auxiliary_dev_to_mei_aux_dev(aux_dev);
> +	if (adev->ext_op_mem.start) {
> +		mei_gsc_set_ext_op_mem(hw, &adev->ext_op_mem);
> +		dev->pxp_mode = MEI_DEV_PXP_INIT;
> +	}
> +
>   	err = mei_restart(dev);
>   	if (err)
>   		return err;